From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6C0C43464 for ; Fri, 18 Sep 2020 08:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CB6621582 for ; Fri, 18 Sep 2020 08:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600417241; bh=LeUVi8N0SXoGjKelLIuhUz/0LftupivSYLHHOImTsdw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Oa/rH+HRPjTY/nTDoYYbpKbvl7/VUqZL6fqwB6QmTgQCcrGmwhVwftvLO0eWeSO4F Vz7BCnLrm9gsFk/HmZi4EOED67T3jtOBpv8ZYT56bz/OqVmvWFJhXRYbjafwwmFxCQ M95BFpm0l7JmsqirR2sbh8+TvxAE0I9XW022GCGA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbgIRIUk (ORCPT ); Fri, 18 Sep 2020 04:20:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:46602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgIRIUj (ORCPT ); Fri, 18 Sep 2020 04:20:39 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 276B720789; Fri, 18 Sep 2020 08:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600417239; bh=LeUVi8N0SXoGjKelLIuhUz/0LftupivSYLHHOImTsdw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bEUVJA28ZofZc6ZaTybGGXdfTKWgLhbCsy93Hbg9SRSz0Rm565ywR75PyCqWRuHwL Wqnspu+1xIhgp8l3Yb4XIOOVpceGVjx28EOV6FYM53ZSQ+26Rv+vSL9SAkc/FBevrE Mv0eWbylwHcI8M1woJoSg4RtW8YDYIgz5fWNnuHc= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kJBdF-00Cvpk-71; Fri, 18 Sep 2020 09:20:37 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 18 Sep 2020 09:20:37 +0100 From: Marc Zyngier To: Sergey Senozhatsky Cc: Leo Yan , Arnaldo Carvalho de Melo , Mark Rutland , Peter Zijlstra , Will Deacon , John Garry , Mathieu Poirier , Namhyung Kim , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 In-Reply-To: <20200918003219.GC3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> <20200917114231.GE12548@leoy-ThinkPad-X240s> <20200918003219.GC3049@jagdpanzerIV.localdomain> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sergey.senozhatsky@gmail.com, leo.yan@linaro.org, acme@kernel.org, mark.rutland@arm.com, peterz@infradead.org, will@kernel.org, john.garry@huawei.com, mathieu.poirier@linaro.org, namhyung@kernel.org, suleiman@google.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-18 01:32, Sergey Senozhatsky wrote: > On (20/09/17 12:53), Marc Zyngier wrote: >> Feel free to add a *new* tracepoint instead. > > Wouldn't we want a whole bunch of new tracepoints in this case? Yes. I don't have a better solution as long as tracepoints are ABI. Get someone to sign-off on it, and I'll happily change them. > (almost all of the existing ones with the extra vcpu_id field). > Right now we have 3 types of events: > - events with no vcpu at all // nil > - events with vcpu_pc // "0x%016lx", __entry->vcpu_pc > - events with (void *)vcpu // "vcpu: %p", __entry->vcpu > > It might be helpful if we could filter out events by vcpu_id. > But this, basically, doubles the number of events in the ringbuffer. Only if you enable them both, right? You define new tracepoints that do whatever you need them to do (hopefully in a cross-architecture compliant way), and have perf to only use the new ones on arm64. How would that double the number of events in the buffer? M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D437AC43463 for ; Fri, 18 Sep 2020 08:22:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F33121582 for ; Fri, 18 Sep 2020 08:22:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RngRG+wo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bEUVJA28" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F33121582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eDwI7RjdE97e3uCyPnKLGOEARIFQYomfSOnqI9ZMSUk=; b=RngRG+woCn/FvnHWImQS+jCKI qaaAkG/1ecmEQPVX8i6gXZCcrJ4IzE9ZReM3RD7AplmOafGnhTyOT7gfGCIssV9Ezzh9j0pnHiVEt L8JggHoyqEDH8q/Vmia1xwjcpVbkGAfZYs0JuwUBbil80m8zvJLTnjEAlUZFrRqtjFUAi3UuY7ELK JeNTNDuEpm98fWANzOjlrwzY0ClWdBCEio7c6H7ZgvwpRK3LFwLeW3NVvNdXpWk7pVJ6joWAzBZYT UwalyfeWP6mU8ZAFqKOTyBi10kHIBIHbabsR8s+JTsaczJP5FeU/0yttrFO1RsSUbBcY6SLGJTgkf zroRRCcew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBda-0005ku-6Z; Fri, 18 Sep 2020 08:20:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBdI-0005df-6H for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 08:20:42 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 276B720789; Fri, 18 Sep 2020 08:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600417239; bh=LeUVi8N0SXoGjKelLIuhUz/0LftupivSYLHHOImTsdw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bEUVJA28ZofZc6ZaTybGGXdfTKWgLhbCsy93Hbg9SRSz0Rm565ywR75PyCqWRuHwL Wqnspu+1xIhgp8l3Yb4XIOOVpceGVjx28EOV6FYM53ZSQ+26Rv+vSL9SAkc/FBevrE Mv0eWbylwHcI8M1woJoSg4RtW8YDYIgz5fWNnuHc= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kJBdF-00Cvpk-71; Fri, 18 Sep 2020 09:20:37 +0100 MIME-Version: 1.0 Date: Fri, 18 Sep 2020 09:20:37 +0100 From: Marc Zyngier To: Sergey Senozhatsky Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 In-Reply-To: <20200918003219.GC3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> <20200917114231.GE12548@leoy-ThinkPad-X240s> <20200918003219.GC3049@jagdpanzerIV.localdomain> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sergey.senozhatsky@gmail.com, leo.yan@linaro.org, acme@kernel.org, mark.rutland@arm.com, peterz@infradead.org, will@kernel.org, john.garry@huawei.com, mathieu.poirier@linaro.org, namhyung@kernel.org, suleiman@google.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_042040_362306_322B8A0F X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Suleiman Souhlal , Leo Yan , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-09-18 01:32, Sergey Senozhatsky wrote: > On (20/09/17 12:53), Marc Zyngier wrote: >> Feel free to add a *new* tracepoint instead. > > Wouldn't we want a whole bunch of new tracepoints in this case? Yes. I don't have a better solution as long as tracepoints are ABI. Get someone to sign-off on it, and I'll happily change them. > (almost all of the existing ones with the extra vcpu_id field). > Right now we have 3 types of events: > - events with no vcpu at all // nil > - events with vcpu_pc // "0x%016lx", __entry->vcpu_pc > - events with (void *)vcpu // "vcpu: %p", __entry->vcpu > > It might be helpful if we could filter out events by vcpu_id. > But this, basically, doubles the number of events in the ringbuffer. Only if you enable them both, right? You define new tracepoints that do whatever you need them to do (hopefully in a cross-architecture compliant way), and have perf to only use the new ones on arm64. How would that double the number of events in the buffer? M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel