All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] spmi: fix some coding style issues at the spmi core
Date: Tue, 29 Sep 2020 11:13:19 +0200	[thread overview]
Message-ID: <f60e9ada-490d-10f9-6221-9a7d9eb054ba@free.fr> (raw)
In-Reply-To: <fec878502147336cbf2cf86e476e9dd797cd7e6f.1601360391.git.mchehab+huawei@kernel.org>

On 29/09/2020 08:22, Mauro Carvalho Chehab wrote:

> @@ -487,7 +489,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
>  			continue;
>  
>  		sdev->dev.of_node = node;
> -		sdev->usid = (u8) reg[0];
> +		sdev->usid = (u8)reg[0];

typeof(sdev->usid) is u8.

What is the point of this cast?

Does GCC warn that u32 is being truncated to u8?

Regards.

  reply	other threads:[~2020-09-29  9:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29  6:22 [PATCH v2 0/2] Some small cleanup/fixes for SPMI driver Mauro Carvalho Chehab
2020-09-29  6:22 ` [PATCH v2 1/2] spmi: get rid of a warning when built with W=1 Mauro Carvalho Chehab
2020-11-13 20:47   ` Stephen Boyd
2020-09-29  6:22 ` [PATCH v2 2/2] spmi: fix some coding style issues at the spmi core Mauro Carvalho Chehab
2020-09-29  9:13   ` Marc Gonzalez [this message]
2020-11-13 20:47   ` Stephen Boyd
2020-10-02 21:22 ` [PATCH v2 0/2] Some small cleanup/fixes for SPMI driver Stephen Boyd
2020-10-03 10:56   ` Greg Kroah-Hartman
2020-10-14 21:26     ` Stephen Boyd
2020-10-15 12:55       ` Greg Kroah-Hartman
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f60e9ada-490d-10f9-6221-9a7d9eb054ba@free.fr \
    --to=marc.w.gonzalez@free.fr \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.