From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: yong.liu@intel.com, anatoly.burakov@intel.com
Subject: [PATCH 2/3] memalloc: fix wrong return value on freeing segment on fail
Date: Thu, 3 May 2018 11:11:26 +0100 [thread overview]
Message-ID: <f612ef58f4a92ccff88565f1cc8c9483ad69bab0.1525342009.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <556d606e3af8ab32e920611d166a0154e472fe25.1525342009.git.anatoly.burakov@intel.com>
In-Reply-To: <556d606e3af8ab32e920611d166a0154e472fe25.1525342009.git.anatoly.burakov@intel.com>
Return value should be zero for success, but if unlock and unlink
have succeeded, return value was 1, which triggered failure message
in calling code.
Fixes: a5ff05d60fc5 ("mem: support unmapping pages at runtime")
Cc: anatoly.burakov@intel.com
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
index c441c89..3282293 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
@@ -647,7 +647,7 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi,
memset(ms, 0, sizeof(*ms));
- return ret;
+ return ret < 0 ? -1 : 0;
}
struct alloc_walk_param {
--
2.7.4
next prev parent reply other threads:[~2018-05-03 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:11 [PATCH 1/3] mem: fix index for unmapping segments on failure Anatoly Burakov
2018-05-03 10:11 ` Anatoly Burakov [this message]
2018-05-10 16:03 ` [PATCH 2/3] memalloc: fix wrong return value on freeing segment on fail Ananyev, Konstantin
2018-05-03 10:11 ` [PATCH 3/3] memalloc: fix unmapping and marking segments as free Anatoly Burakov
2018-05-10 17:03 ` Ananyev, Konstantin
2018-05-04 8:13 ` [PATCH 1/3] mem: fix index for unmapping segments on failure Liu, Yong
2018-05-10 17:07 ` Ananyev, Konstantin
2018-05-14 1:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f612ef58f4a92ccff88565f1cc8c9483ad69bab0.1525342009.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.