From: Sagi Grimberg <sagi@grimberg.me>
To: "Wunderlich, Mark" <mark.wunderlich@intel.com>,
Potnuri Bharat Teja <bharat@chelsio.com>
Cc: Samuel Jones <sjones@kalrayinc.com>, "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: Request timeout seen with NVMEoF TCP
Date: Fri, 18 Dec 2020 17:04:12 -0800 [thread overview]
Message-ID: <f6162f73-ad03-c266-0289-4b8eb1c9f330@grimberg.me> (raw)
In-Reply-To: <BYAPR11MB2869100E0BA40ACB0CDDEFB0E5C60@BYAPR11MB2869.namprd11.prod.outlook.com>
> Wouldn't the addition of the change to io_work() itself result in step (4) above never occurring? Pending always being set if mutex can not be acquired, and if io_work() then exceeds time period it always re-queues itself. So io_work() should always end up draining any send list eventually. Unless io_work() exits early for some reason via the try_recv (ret < 0) return point without requeuing.
nvme_tcp_try_recv returns what it consumed, so it can return 0 if it did
not have anything to recv in the socket, hence it may not reschedule itself.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-19 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 17:19 Request timeout seen with NVMEoF TCP Potnuri Bharat Teja
2020-12-09 18:02 ` Sagi Grimberg
2020-12-10 17:06 ` Potnuri Bharat Teja
2020-12-10 21:47 ` Sagi Grimberg
2020-12-11 7:26 ` Potnuri Bharat Teja
2020-12-14 17:51 ` Sagi Grimberg
2020-12-14 18:05 ` Potnuri Bharat Teja
2020-12-14 19:27 ` Samuel Jones
2020-12-14 20:13 ` Sagi Grimberg
2020-12-15 1:53 ` Sagi Grimberg
2020-12-15 18:30 ` Wunderlich, Mark
2020-12-19 1:04 ` Sagi Grimberg [this message]
2020-12-16 5:51 ` Potnuri Bharat Teja
2020-12-19 1:35 ` Sagi Grimberg
2020-12-21 7:50 ` Potnuri Bharat Teja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6162f73-ad03-c266-0289-4b8eb1c9f330@grimberg.me \
--to=sagi@grimberg.me \
--cc=bharat@chelsio.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=mark.wunderlich@intel.com \
--cc=sjones@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.