From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67744C433B4 for ; Thu, 6 May 2021 15:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A1946109E for ; Thu, 6 May 2021 15:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235124AbhEFPVh (ORCPT ); Thu, 6 May 2021 11:21:37 -0400 Received: from linux.microsoft.com ([13.77.154.182]:38232 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235036AbhEFPVf (ORCPT ); Thu, 6 May 2021 11:21:35 -0400 Received: from [192.168.254.32] (unknown [47.187.223.33]) by linux.microsoft.com (Postfix) with ESMTPSA id BC3BD20B7178; Thu, 6 May 2021 08:20:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BC3BD20B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1620314437; bh=38FJmBMm62FNJbAmIqdoifYxsyXAhfVcnNsSEdMBgD0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BbcudnTW8r91m0v0K6ZtId3NOAYF0iHC2oWz4Ak1nCNi51+ES7ZOm0nmyx40i5cXC ZTW07gTcvVC6MJwR0BfbC+UvozkBqY/AJs3xNtgokGh97WHq2mAOQos1TbbIz3GsMm QkbVo2oH0N9c/dD/sgmUgkooiru1wlGmlBWYwAms= Subject: Re: [RFC PATCH v3 4/4] arm64: Handle funtion graph tracer better in the unwinder To: Mark Brown Cc: jpoimboe@redhat.com, mark.rutland@arm.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <65cf4dfbc439b010b50a0c46ec500432acde86d6> <20210503173615.21576-1-madvenka@linux.microsoft.com> <20210503173615.21576-5-madvenka@linux.microsoft.com> <20210506144352.GF4642@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: Date: Thu, 6 May 2021 10:20:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210506144352.GF4642@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/6/21 9:43 AM, Mark Brown wrote: > On Mon, May 03, 2021 at 12:36:15PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> The Function Graph Tracer modifies the return address of a traced function >> to a return trampoline (return_to_handler()) to gather tracing data on >> function return. When the unwinder encounters return_to_handler(), it calls >> ftrace_graph_get_ret_stack() to lookup the original return address in the >> return address stack. > > This makes sense to me, I'll need to re-review properly with the changes > earlier on in the series but should be fine. > I will make changes based on the comments I have received so far and send out version 4 so everything is current for the next round of review. Thanks! Madhavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA11CC43461 for ; Thu, 6 May 2021 15:23:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C8DB610A5 for ; Thu, 6 May 2021 15:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C8DB610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n3n5KJkh4+r/rHLb8S931kFLvxMmHj+XJ3RjFziHAls=; b=qXT1zBI1xq1rJxv3wsDTecIPe 6GWoNruEnZ3OPiX8TMnp/RbufXLtwm20wMyQtq+4CQQ04NnTWNWpxsp6Cr3ydUfIu8+R7z+O76+0B zfQPzJLwb7OK3OXA6gbR0YVYuM9/nHCSU29Aa2oixe5DZNNyGv6RFxzSBrawcrqLhmLeu7KlVrfr7 CphR9THxNVULySRrQG6PYu5Z5RwEecbXDY6C4207w3HWC7xHjVzxg9Jr9MoYZkMuWyhGxtUYf/67U xz9BbUgojcKFvUTj3S4CXtsIOHeX3kqLCxd70HrFql4C2r2xkrtyzAYmvifjldt7zJzIYaZhMcR8r rGnjSDoIw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lefnx-004WjZ-JS; Thu, 06 May 2021 15:20:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefnu-004WjJ-6E for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 15:20:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=38FJmBMm62FNJbAmIqdoifYxsyXAhfVcnNsSEdMBgD0=; b=D94wELTL+vhLOU98qKQpHqJeBQ k/WYrOjXwtiWWAE33GT+i3dgDE/ukQMPdwPH+pfvR/OlO5LZuhzpZ+oHM4UN2GbDVLZ3VsQpb6dB0 ua0T4CfBz7lTSIzIVhF2mJIhgbAR5p97zhrRmIbkHiiuTnkz2IBC/PR8jCv/7gcEi4NCnwyGPWETv Jr4lsdgz8UlmXV46SkcG48iQagbbgw0uuZld8bx5es1hbbFY2qq9dM7E9nA/u7OgUW89ARrOwtJNg JbjSsuEg/0vprH4cPxUx72ZhDfaXIdISE7FJ6++yVcPk9yBf9iKvb30HKUlcnoMKFpKC/h5zPE60N 4JbGS+ig==; Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lefnr-0068Ay-NY for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 15:20:40 +0000 Received: from [192.168.254.32] (unknown [47.187.223.33]) by linux.microsoft.com (Postfix) with ESMTPSA id BC3BD20B7178; Thu, 6 May 2021 08:20:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BC3BD20B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1620314437; bh=38FJmBMm62FNJbAmIqdoifYxsyXAhfVcnNsSEdMBgD0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BbcudnTW8r91m0v0K6ZtId3NOAYF0iHC2oWz4Ak1nCNi51+ES7ZOm0nmyx40i5cXC ZTW07gTcvVC6MJwR0BfbC+UvozkBqY/AJs3xNtgokGh97WHq2mAOQos1TbbIz3GsMm QkbVo2oH0N9c/dD/sgmUgkooiru1wlGmlBWYwAms= Subject: Re: [RFC PATCH v3 4/4] arm64: Handle funtion graph tracer better in the unwinder To: Mark Brown Cc: jpoimboe@redhat.com, mark.rutland@arm.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <65cf4dfbc439b010b50a0c46ec500432acde86d6> <20210503173615.21576-1-madvenka@linux.microsoft.com> <20210503173615.21576-5-madvenka@linux.microsoft.com> <20210506144352.GF4642@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: Date: Thu, 6 May 2021 10:20:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210506144352.GF4642@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_082039_828261_49354DBE X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/6/21 9:43 AM, Mark Brown wrote: > On Mon, May 03, 2021 at 12:36:15PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> The Function Graph Tracer modifies the return address of a traced function >> to a return trampoline (return_to_handler()) to gather tracing data on >> function return. When the unwinder encounters return_to_handler(), it calls >> ftrace_graph_get_ret_stack() to lookup the original return address in the >> return address stack. > > This makes sense to me, I'll need to re-review properly with the changes > earlier on in the series but should be fine. > I will make changes based on the comments I have received so far and send out version 4 so everything is current for the next round of review. Thanks! Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel