From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112E1C31E45 for ; Thu, 13 Jun 2019 03:30:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA79420851 for ; Thu, 13 Jun 2019 03:30:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YM++op6S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA79420851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbGR8-0007iu-V1 for qemu-devel@archiver.kernel.org; Wed, 12 Jun 2019 23:30:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54939) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbGQE-0007Bb-2W for qemu-devel@nongnu.org; Wed, 12 Jun 2019 23:29:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbGQA-0005Pv-6C for qemu-devel@nongnu.org; Wed, 12 Jun 2019 23:29:04 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:45064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbGQ9-0005O7-F2 for qemu-devel@nongnu.org; Wed, 12 Jun 2019 23:29:02 -0400 Received: by mail-pg1-x542.google.com with SMTP id w34so10052575pga.12 for ; Wed, 12 Jun 2019 20:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kPAjRA0VL56wavu8e0yujncvRDtEO/XuSjnj30YQgA4=; b=YM++op6SAZLXYY1NvBtxbGxJ/sZvlCyPm8BiLsOiszqUOtywdDdAnpR4bN1WnbNo24 w7ZH04FwaIgl00WVYkd8wUNheoYFMsbnZoXYeECu1b1e2kHZqVNNBcNjYizpU9YUVqqq iJ0UbajvztQkxjdZ1VwWG4Ti3f5eP80kyBcvsZevHVvNCavTfPmHynYP6H9urE/+iH2s gz6fq22M18IRv8ln3n5TrmBnxkniLZVerEsq4aOoO3MMcQ7M5WsGoxed1X1WNQXY8PRp BqkjwOgpry8c+0HX49AI6u97VKwdMvgJp5cDGxoYsFpcd3Gk/1r08yImgRMxyotQTLRp b6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kPAjRA0VL56wavu8e0yujncvRDtEO/XuSjnj30YQgA4=; b=RxaUNDgV+doIAtWK9y88puATCOeleo10Zgdq/Qvb8CmkQWS/+ZXKQ6WW7XyQQ87o3k crKKLOGXFpgSaVDj2rECna3hdmbajLZlQYgiCofY61s8Z1+WduB8BW+ZMI9h82MkIDH+ 1DfJMyBXu4BCIlc4HwywJpVnJpUSZ4Z7SloSlBjrLCg+rwhX+2kZh2FOvGGy79om6B8E s2XUDyp7IirhzKCrpnWcgaTwMtHPdT1XQeBxPBMS22STBuKEhL26If6rARr5QfNHSADC JuDYjkmpQzOlqQK90JpqX0CCeowFV2ySRIGcuJEFw5u/9wveP2dkv95Lzgll9cORvBtc RggA== X-Gm-Message-State: APjAAAV3/eRmbjb0IFmXliK88gw6N5i0m7jHbdD5ZfBMm/0TR4TuH0NW wzOA8rTOa/zHYsmEA0VLV5kb2RE95Xw= X-Google-Smtp-Source: APXvYqy4Auec2SmT+ooUoBqVe4XovrwDdppRh80x9YYVqMjB4E5tmRpiiKJC3aC6Q25hZrrAXMcepw== X-Received: by 2002:a62:4e48:: with SMTP id c69mr67627113pfb.176.1560396539548; Wed, 12 Jun 2019 20:28:59 -0700 (PDT) Received: from [10.1.2.220] (50-247-96-158-static.hfc.comcastbusiness.net. [50.247.96.158]) by smtp.gmail.com with ESMTPSA id a13sm870802pgh.6.2019.06.12.20.28.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2019 20:28:58 -0700 (PDT) To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net, gkurz@kaod.org References: <20190602110903.3431-1-mark.cave-ayland@ilande.co.uk> <20190602110903.3431-10-mark.cave-ayland@ilande.co.uk> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Wed, 12 Jun 2019 20:28:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190602110903.3431-10-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: Re: [Qemu-devel] [PATCH v2 09/15] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new GEN_VSX_HELPER_X1 macro which performs the decode based > upon xB at translation time. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/fpu_helper.c | 6 ++---- > target/ppc/helper.h | 8 ++++---- > target/ppc/translate/vsx-impl.inc.c | 24 ++++++++++++++++++++---- > 3 files changed, 26 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~