From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3656C4332F for ; Fri, 14 Oct 2022 15:35:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D889A84DFC; Fri, 14 Oct 2022 17:35:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="VTKvW9Hk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E4C1184E06; Fri, 14 Oct 2022 17:35:17 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2082.outbound.protection.outlook.com [40.107.105.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD74B8456E for ; Fri, 14 Oct 2022 17:35:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TV6/+cD4QNMGfeIKZEUiK0c4vG6hf075MpM76pLSKCvvxXgZ7rnEaa2evt9MT/ch+WjzQ12AG3eRSLASICnz28pEmRe1AUr38tr+KcSxgTlZqBrzcalJ0NWchX3WJQfn/5sojs41nxSVjIIEDhy1MtAmzKqIXJ/enrkZd4aS9I17Qo3WcwMUtpRueeMyPdBP93LkU3Ab+B93T4VzTRkDkyHTmUmsr4Y+mmrJRHzVOaA+Wtv29RKYh/g01d5IxySTAMh83GvMDr3dTeWsUc9kvMQ/G690Cq1EjEtAfRXff1sXqjmHBxcANFRwaJpI0xbUnH45RVmweVTnaMGdSJTRMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FWR8xvgXY1Ixo4R49Bf9QOs3y5TkCWwuX0tlsgeIEh4=; b=EdbbayYilQyM4uP7V9iREcwcbZwNK6+vxDSQa8fwLewdgVK9xGLsa3uoNl749BHMbikgvDqYu7g0d0nO23mvgHyBVfMebBWofO/3tKVr+jIcmbyUUT3KNJiHlJiZ45X5G89Q15Cmpb6p5mLKfE7t99qy3D5aba4RB5icXx2zGtx8x7xBKB9M0yfFl6OwzI5cKiZk8ssFJvwzdy1qDnK/iRhWnmkvacFGlv26hpec6Y2FmSRVlYmU+XtQ1TZZLDgSxu1coNka4HdweSg11bfHCX9HF5EQaks2cgIgBhfbO++L7go+crTsHT/GivmHN8wOoQODG+ajykY9tKRHi7x7ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.75) smtp.rcpttodomain=chromium.org smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FWR8xvgXY1Ixo4R49Bf9QOs3y5TkCWwuX0tlsgeIEh4=; b=VTKvW9Hkl4BJItMta4nbuEYvDJv9DeEED8U/1jZXYvavTplSHdc9vj9AIoC7LsYeedHqJf4t2drN93W+V/jig28cTl0ygx9Ts6tzlWPuyHMNGY92MIpqLtnSLEaVCTjjyky7DGffYyNZCIoJmOHlF+zg7fkVwdF1zIQ/5we4fqBPJHnv5qkpEPMFc4v8eYzIQTU+UNBefl3n5WNFYRHW7uNy1Qhy+tETo/SbVhuA5n3qC8txqAG7KUJYCjNfB0wlW8j88ceJ4itiKQa2R2Lfzxtyuixjpa5thyJXRdofJ8xUczX0/ez7yNmeYTlmbVBLgNoMeOKHoxWRZ7+aVqF4rw== Received: from DB9PR02CA0030.eurprd02.prod.outlook.com (2603:10a6:10:1d9::35) by GV2PR10MB6935.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 15:35:13 +0000 Received: from DB5EUR01FT018.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::83) by DB9PR02CA0030.outlook.office365.com (2603:10a6:10:1d9::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.25 via Frontend Transport; Fri, 14 Oct 2022 15:35:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.75) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.75 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.75; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.75) by DB5EUR01FT018.mail.protection.outlook.com (10.152.4.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 15:35:12 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VRA.ad011.siemens.net (194.138.21.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Fri, 14 Oct 2022 17:35:12 +0200 Received: from [139.21.18.154] (139.21.18.154) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Fri, 14 Oct 2022 17:35:11 +0200 Message-ID: Date: Fri, 14 Oct 2022 17:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Content-Language: en-US To: Simon Glass , Tom Rini CC: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014131315.GM2020586@bill-the-cat> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [139.21.18.154] X-ClientProxiedBy: DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--16.885700-8.000000 X-TMASE-MatchedRID: at/Sp2tYgyw5QaOxwNGfvo9bHfxDWoibW6eKzKKCgnPBjbyj5wYDmv6l pfpte41hWAuSz3ewb220QygafZjV1RvER19e8+LDuWcLt7UQTIALyuqgPh8WPp3bt4XlQMWjecm 5MLY/474da1Vk3RqxOIgnLdHU7oiOHPbzAuybsHyFvwEmnsW3vcHVNeDWrWSGdhnFihmbnwVp4x orO9dSmdzONa1Rspx34rl+FHG3VoDu6gyVCKrNt/5nI8KIHQ65Xnan/9QqlwtfvuAR8NI0nOJc6 hKWj0C1dQ3YO1g+ITKfTJvnqXF8K3mN0n5wvdMIY3SO8OGlRUbmo04fDUc7SyAI8aJmq0jw2FA7 wK9mP9ctferJ/d7Abz+tNnCph+AvYBA+EGmViA60mQYyW97dCMEElERnDJHCyPPRU9ScEDXyCvI CuK46cntTo0P1ssT+YG32ZLukpVN6ipWzVkuu8DN360kR9zHUXHEPHmpuRH2DGx/OQ1GV8rHlqZ YrZqdI+gtHj7OwNO0kL2NLniq3NUifgWDtEhJvskVCbFi+n0ZqARBrgSJwX6Tll1NsmK5v X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--16.885700-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 51229A999E867DF07FB39EEC8C0171D3E4AA51F382F3412E3C156E2320F44B4F2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5EUR01FT018:EE_|GV2PR10MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 48005515-fc5c-434f-ad3a-08daadf9af82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KjtVsyYj7gUwxvL1IFSF/R6X5chIOUxG5SevpsQu7Vi2S8pvrEewtJ6Jb+W73zluO4t7Oa3rOgzJpTB/cO/N1aUaTmffE756bQagpMiYV07ZP/HMl3H2V3KHLOM91jBM2enM+5sY7RPMLT4/bdy/fQ1o6kc7KnL9s4pYtDK36lxCinbZ+IgpGJqdZQyw9aNGrtxmJ8jUotERFr3JHRt2E6CgRdhLSN6r4sLnuAjCtCTDaG9rF8B5gR0KSPRPk0LNdh9/YLAPeZKWJn1PcBnIZnKTE7vbiKktKvSOZ3UhgDjbfJ5MMq7OVIrwahGjVAZNRHSgG/anY8JwrAlhbkLXJ2JrEJt1XJntK4uqUmtcW+0UauKaYn4Twat5otTnujsIv9Btwop3zNB/ZKqdWFqyzZT3LO0LlXhmyz7zXRl0EK+89UxjSI8qnGnMznfdQ+dnN77xotogg2vkKWuGcDPOQT/o37B+98Y6AqZbb9gGi92SeiSTzDwadNmWTVTmbX3zNVi51kN8WjY6kmybTtaSwjecm5MnIrohiEFOPUJe9rybf2PAQdeG3bcEVFxhyJCjTesH9Ln8vkcJ9SR3GnRDj+g2XOoQDOJI5/EV60cmB1fGr2D/fVDwuz5PrF6n/Ta6ygiDjmDrL2TBs/7IQGfAiYRM5Qmc7F93AdIDHNnrh/yQfqNLcXt19GuyeJvdZQ89BfEuW84DNbICkZPKKHIxVSLGtuplf6nYD7S+C2jIrVj+0ift36WOY+ByKrgd8scI+Y9+QoaC5DApEAgdebC7GCAl6gV263Vilx9j0uV6NdX7Xgeza36xF0uo/rYOA9rLnC/In+9QZ0mWGCC/IGs34qwAKZQZqr1+Xon2Q0PQ/pQ2XGQay/Xoxw8O6WKP/jptlwXza83sSdSF4mjD41Aiug== X-Forefront-Antispam-Report: CIP:194.138.21.75; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(66899015)(54906003)(70586007)(2906002)(70206006)(31686004)(8676002)(4326008)(8936002)(316002)(41300700001)(110136005)(16576012)(6706004)(81166007)(53546011)(82960400001)(82740400003)(356005)(34070700002)(40460700003)(40480700001)(26005)(82310400005)(6666004)(478600001)(5660300002)(44832011)(31696002)(16526019)(86362001)(956004)(36756003)(336012)(47076005)(36860700001)(186003)(2616005)(3940600001)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 15:35:12.8604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48005515-fc5c-434f-ad3a-08daadf9af82 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.75]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT018.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB6935 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 14.10.22 17:33, Simon Glass wrote: > Hi Tom, > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: >> >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: >>>> On 9/25/21 2:30 AM, Simon Glass wrote: >>>>> This code should never have been added as it builds a new feature on top >>>>> of legacy code. This has already been improved with the dependency on >>>>> BLK. >>>>> >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this old >>>>> code. >>>>> >>>>> Boards which want EFI_LOADER should migrate to driver model first. >>>>> >>>>> Note this patch is included to resolve the following build error: >>>>> >>>>> lib/efi_loader/efi_runtime.c:680:16: error: ‘CONFIG_SYS_TEXT_BASE’ >>>>> undeclared (first use in this function); did you mean >>>>> ‘CONFIG_SYS_SRAM_BASE’? >>>>> 680 | ulong base = CONFIG_SYS_TEXT_BASE; >>>>> | ^~~~~~~~~~~~~~~~~~~~ >>>>> | CONFIG_SYS_SRAM_BASE >>>>> >>>>> Signed-off-by: Simon Glass >>>> >>>> Reviewed-by: Heinrich Schuchardt >>>> >>> >>> How to deal with boards that need CONFIG_NET but do not actually >>> implement any driver (yet)? This now broke UEFI for the IOT2050 which >>> needs NET for network-related device tree setup (see also [1]) and >>> enforces a local hack for us. >> >> Yes, looking at the patch, this should probably use NETDEVICES and not >> NET as the test? Would that fix your problem, Jan? > > But that selects DM_ETH. You can still enable DM_ETH when there are no > devices, so I'm not sure what the problem is. Can you post an error? > > Things should be migrated to DM_ETH by now (end of 2020). > I am enable DM_ETH now at board-level, just to make EFI_LOADER happy, but that feels wrong. Jan -- Siemens AG, Technology Competence Center Embedded Linux