From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 05/10] net/virtio: refactor virtqueue structure Date: Thu, 21 Mar 2019 15:18:31 +0100 Message-ID: References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-6-tiwei.bie@intel.com> <20190319094432.iap4i7ffs6soukr7@jenstp.localdomain> <20190319100939.GA3839@dpdk-tbie.sh.intel.com> <20190319134751.ibgaalfravjm77lh@jenstp.localdomain> <1d05e311-c60b-cb1d-ff2b-974e01a0451b@redhat.com> <64884489-8cc7-7c3f-5b65-09f46112adb0@redhat.com> <20190320044026.GA23715@dpdk-tbie.sh.intel.com> <20190320105009.27ef685c@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Kevin Traynor , Jens Freimann , zhihong.wang@intel.com, dev@dpdk.org To: Stephen Hemminger , Tiwei Bie Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F0BBB1B4FA for ; Thu, 21 Mar 2019 15:18:37 +0100 (CET) In-Reply-To: <20190320105009.27ef685c@shemminger-XPS-13-9360> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/20/19 6:50 PM, Stephen Hemminger wrote: > On Wed, 20 Mar 2019 12:40:26 +0800 > Tiwei Bie wrote: > >>> I agree the vq_ prefix is not needed and I think the code is more >>> readable in general seeing the packed/split name when using the struct. >>> >>> Please also consider that cosmetic changes in multiple places likely >>> mean backports will not apply cleanly to the stable branches anymore, so >>> it does have a cost. >> >> Yeah, agree. > > > prefixing structure elements is an old school BSD thing back from when > compilers were not smart about namespaces for identifiers. Ha, good to know! I wasn't aware of that. > > Agree that it is no longer needed. >