From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218EBC43603 for ; Tue, 10 Dec 2019 22:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C818C2053B for ; Tue, 10 Dec 2019 22:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="CeFET6SF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ipJwzUWJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728811AbfLJWK7 (ORCPT ); Tue, 10 Dec 2019 17:10:59 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58847 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbfLJWK6 (ORCPT ); Tue, 10 Dec 2019 17:10:58 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 326DAF5A; Tue, 10 Dec 2019 17:10:57 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Tue, 10 Dec 2019 17:10:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=iTzj/LXruarNxkB4mF+5qgnxYnni345 HnB4zzW+dtao=; b=CeFET6SFvvOE8YyX5U34URQmorm1Zg3iCfE5rXF71XrLsVG giyMAGOcfVkLtVPHkfQNU1dCrua9wiUW9Np2OHESJiYHcc090vZyjEMIdEvkYxnn ZuYcMc7hmSP611btvl7KumhtA5vrmJwWtoMfLZuGLvseUMVk9kL16OmKjxXcgtVN MKmtwhlc6gP6P7hP3tNT1QNTg5quvUs6KpR466SRb51wv4XaEifDJJunVgPAgoZy ZepqZRxvMqx5TNoWdLacjk3E7vp5TwJdIpsnS5NzbCDQUHRxCGAfrO9LMHAZ34q2 Y7MK+ct62tW0jBiaXpmVdDoWx7oRqQGydg8hLvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iTzj/L XruarNxkB4mF+5qgnxYnni345HnB4zzW+dtao=; b=ipJwzUWJtdhmKRNun/ZAsR aMJ+C3uwPWPBTkCIeYbXdnP7phZ9WcW+P8DN8BVA1KwVrMQ23gTZkR2u//dwUCxe YroByIKLA3BfeSthfMMDPhhiE9938ISPW03bEr+VUMke1hA8K47MZwwjS5qjNgwC nZdTmoQIzW14j4XmYLjBHBky+x5jAkzDS1cMOWB+rRgQ4vfmemLCTZU/e0AJLNZ2 KFpmbFSDFxraP8nqzlPITpvd8EHvk+CLYO3fpGbP71hSHvtwbZ5ryeddofpZ42Uy l3jzqHr0Vyg+x15g2PLwA+VNjsJO4BfQzCeKH1m/miWQiELGOZYdZ6fTK4JCKB0A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelfedgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrg hrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 78AE2E00A2; Tue, 10 Dec 2019 17:10:55 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-679-g1f7ccac-fmstable-20191210v1 Mime-Version: 1.0 Message-Id: In-Reply-To: <20191210202842.2546758-1-arnd@arndb.de> References: <20191210202842.2546758-1-arnd@arndb.de> Date: Wed, 11 Dec 2019 08:42:35 +1030 From: "Andrew Jeffery" To: "Arnd Bergmann" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" Cc: "Hongwei Zhang" , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: aspeed: avoid return type warning Content-Type: text/plain Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 11 Dec 2019, at 06:58, Arnd Bergmann wrote: > gcc has a hard time tracking whether BUG_ON(1) ends > execution or not: > > drivers/gpio/gpio-aspeed-sgpio.c: In function 'bank_reg': > drivers/gpio/gpio-aspeed-sgpio.c:112:1: error: control reaches end of > non-void function [-Werror=return-type] > > Use the simpler BUG() that gcc knows cannot continue. > > Fixes: f8b410e3695a ("gpio: aspeed-sgpio: Rename and add Kconfig/Makefile") > Signed-off-by: Arnd Bergmann Acked-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B07EC2D0BF for ; Tue, 10 Dec 2019 22:11:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FC50207FF for ; Tue, 10 Dec 2019 22:11:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FAkNRUkG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="CeFET6SF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ipJwzUWJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC50207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UGvaXWNKWiM3UnSihIjxgne7HVaFF8kBPPWAqs4p7+g=; b=FAkNRUkGYTLOBO FglNHmG+r0TYZCjysRBQFLb04ZuTTRv7EsfTeysuusaWueu8ZSWu5YYMI4beTSwEchJrLk5JNOS8q 8WsMcgfN+oWJskBliOPuXrfiQFRWEGj0Ujd5AMl0Fx4GhIBsrNxocv+xnZCeryC3P9aQg4hEZMLbx ME7675BVMiTUaAzyyyPF/nBzIXSuAWtQ0ByNX6O7ALLlQVv9MnVKLqIZqlEVR4TjsEgbmZHBiqRys X3ByG3i3HEKCpcQyJjBwLQAQWoObxqYIJEnUoTVNh/i4CqCmJFYl5zU020sLYyLH+g32WrxgPECXW Tn4xKeccCbNCDn2nfbow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ienik-0005NS-IY; Tue, 10 Dec 2019 22:11:06 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ienih-0005M8-9t for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 22:11:04 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 326DAF5A; Tue, 10 Dec 2019 17:10:57 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Tue, 10 Dec 2019 17:10:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=iTzj/LXruarNxkB4mF+5qgnxYnni345 HnB4zzW+dtao=; b=CeFET6SFvvOE8YyX5U34URQmorm1Zg3iCfE5rXF71XrLsVG giyMAGOcfVkLtVPHkfQNU1dCrua9wiUW9Np2OHESJiYHcc090vZyjEMIdEvkYxnn ZuYcMc7hmSP611btvl7KumhtA5vrmJwWtoMfLZuGLvseUMVk9kL16OmKjxXcgtVN MKmtwhlc6gP6P7hP3tNT1QNTg5quvUs6KpR466SRb51wv4XaEifDJJunVgPAgoZy ZepqZRxvMqx5TNoWdLacjk3E7vp5TwJdIpsnS5NzbCDQUHRxCGAfrO9LMHAZ34q2 Y7MK+ct62tW0jBiaXpmVdDoWx7oRqQGydg8hLvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iTzj/L XruarNxkB4mF+5qgnxYnni345HnB4zzW+dtao=; b=ipJwzUWJtdhmKRNun/ZAsR aMJ+C3uwPWPBTkCIeYbXdnP7phZ9WcW+P8DN8BVA1KwVrMQ23gTZkR2u//dwUCxe YroByIKLA3BfeSthfMMDPhhiE9938ISPW03bEr+VUMke1hA8K47MZwwjS5qjNgwC nZdTmoQIzW14j4XmYLjBHBky+x5jAkzDS1cMOWB+rRgQ4vfmemLCTZU/e0AJLNZ2 KFpmbFSDFxraP8nqzlPITpvd8EHvk+CLYO3fpGbP71hSHvtwbZ5ryeddofpZ42Uy l3jzqHr0Vyg+x15g2PLwA+VNjsJO4BfQzCeKH1m/miWQiELGOZYdZ6fTK4JCKB0A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelfedgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrg hrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 78AE2E00A2; Tue, 10 Dec 2019 17:10:55 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-679-g1f7ccac-fmstable-20191210v1 Mime-Version: 1.0 Message-Id: In-Reply-To: <20191210202842.2546758-1-arnd@arndb.de> References: <20191210202842.2546758-1-arnd@arndb.de> Date: Wed, 11 Dec 2019 08:42:35 +1030 From: "Andrew Jeffery" To: "Arnd Bergmann" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" Subject: Re: [PATCH] gpio: aspeed: avoid return type warning X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_141103_686783_017BC53D X-CRM114-Status: UNSURE ( 5.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Hongwei Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Dec 2019, at 06:58, Arnd Bergmann wrote: > gcc has a hard time tracking whether BUG_ON(1) ends > execution or not: > > drivers/gpio/gpio-aspeed-sgpio.c: In function 'bank_reg': > drivers/gpio/gpio-aspeed-sgpio.c:112:1: error: control reaches end of > non-void function [-Werror=return-type] > > Use the simpler BUG() that gcc knows cannot continue. > > Fixes: f8b410e3695a ("gpio: aspeed-sgpio: Rename and add Kconfig/Makefile") > Signed-off-by: Arnd Bergmann Acked-by: Andrew Jeffery _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel