From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F5FC4332D for ; Thu, 19 Mar 2020 19:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CB122070A for ; Thu, 19 Mar 2020 19:29:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727982AbgCST3U (ORCPT ); Thu, 19 Mar 2020 15:29:20 -0400 Received: from mga05.intel.com ([192.55.52.43]:4273 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbgCST3S (ORCPT ); Thu, 19 Mar 2020 15:29:18 -0400 IronPort-SDR: bVWigo4Fv7jMZyA8pdsTJL894LCyvB4w8iMEtmVuDfE3IjJ2NMT/eGARjscM85dFS/oo7XS7PB p0fkxyguuBXA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 12:29:18 -0700 IronPort-SDR: MQXloGgtmfQmn2lTbl+0WLbHTx9QpCVk0qFlUxv6GOqn/OpUgA3EDvcUSRLeEL1HnuDHbQR4cA TjDyvYis4T+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,572,1574150400"; d="scan'208";a="391905475" Received: from mallani-mobl.amr.corp.intel.com (HELO [10.255.35.49]) ([10.255.35.49]) by orsmga004.jf.intel.com with ESMTP; 19 Mar 2020 12:29:16 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Cezary Rojewski , Dominik Brodowski Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, curtis@malainey.com, tiwai@suse.com, Keyon Jie , linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, Mark Brown References: <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> <20200319165157.GA2254@light.dominikbrodowski.net> <20200319182413.GA3968@light.dominikbrodowski.net> <750f7841-0b95-9fa8-d858-e0bff4d834d5@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 19 Mar 2020 14:05:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <750f7841-0b95-9fa8-d858-e0bff4d834d5@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/19/20 1:35 PM, Cezary Rojewski wrote: > On 2020-03-19 19:24, Dominik Brodowski wrote: >> On Thu, Mar 19, 2020 at 06:33:50PM +0100, Cezary Rojewski wrote: >>> >>> Could you confirm the same happens on your machine when revert of >>> mentioned >>> patch is not applied ("stream is NULL" messages occur)? Issue may be >>> harmless but explained sequence does not look right. >> >> Indeed, I still see >> >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to reset, ignore it. >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to free, ignore it. >> haswell-pcm-audio haswell-pcm-audio: FW loaded, mailbox readback FW >> info: type 01, - version: 00.00, build 77, source commit id: >> 876ac6906f31a43b6772b23c7c983ce9dcb18a19 >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to reset, ignore it. >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to free, ignore it. >> >> though sounds continues to work. >> > > Thanks once again for your input and time! > > I'll prepare patches for both issues. My guess is haswell-pcm could be > updated to handle 'platform' component param just fine, but it is > probably a change of more than few lines. I'd rather revert non-SOF > broadwell to its previous behavior and start a separate task from there. It'd be good to know why a dummy platform component is required though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A2AC4332D for ; Thu, 19 Mar 2020 19:30:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2574D20739 for ; Thu, 19 Mar 2020 19:30:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="F3w0i4Cv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2574D20739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8A37B17A8; Thu, 19 Mar 2020 20:29:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8A37B17A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584646230; bh=rq5oP6Ug5Od0LjTx0LNJMTIVmmDG7cUK91FxWANfZiE=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F3w0i4CvkO/iDcNWrI9iKPTRG6xz0jC2LpAwN39WOJRZ/obmwbMHwxrSDH5BimSWF 1g/DTUuybGFMeSgN4hqDHM9btJFq+NGfuDanI4BbEZXnmbShJ5p/Yvxqbm1ohsQZv6 R6OZUkZRf95506+IoSTZVD7bLq9o7JvmtXnJ3gGk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6F469F80254; Thu, 19 Mar 2020 20:29:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D9EF4F8023E; Thu, 19 Mar 2020 20:29:23 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8F8ADF80217 for ; Thu, 19 Mar 2020 20:29:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8F8ADF80217 IronPort-SDR: OaUd89KBLxc07poA4AcNTnzTOAmE3RY6dSTBXsBvYt4cp6Tke4i2NTK2zYo5iCTckRAhtDIXGX ZYBIuEZRoNaQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 12:29:17 -0700 IronPort-SDR: MQXloGgtmfQmn2lTbl+0WLbHTx9QpCVk0qFlUxv6GOqn/OpUgA3EDvcUSRLeEL1HnuDHbQR4cA TjDyvYis4T+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,572,1574150400"; d="scan'208";a="391905475" Received: from mallani-mobl.amr.corp.intel.com (HELO [10.255.35.49]) ([10.255.35.49]) by orsmga004.jf.intel.com with ESMTP; 19 Mar 2020 12:29:16 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Cezary Rojewski , Dominik Brodowski References: <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> <20200319165157.GA2254@light.dominikbrodowski.net> <20200319182413.GA3968@light.dominikbrodowski.net> <750f7841-0b95-9fa8-d858-e0bff4d834d5@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 19 Mar 2020 14:05:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <750f7841-0b95-9fa8-d858-e0bff4d834d5@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, curtis@malainey.com, Keyon Jie , tiwai@suse.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/19/20 1:35 PM, Cezary Rojewski wrote: > On 2020-03-19 19:24, Dominik Brodowski wrote: >> On Thu, Mar 19, 2020 at 06:33:50PM +0100, Cezary Rojewski wrote: >>> >>> Could you confirm the same happens on your machine when revert of >>> mentioned >>> patch is not applied ("stream is NULL" messages occur)? Issue may be >>> harmless but explained sequence does not look right. >> >> Indeed, I still see >> >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to reset, ignore it. >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to free, ignore it. >> haswell-pcm-audio haswell-pcm-audio: FW loaded, mailbox readback FW >> info: type 01, - version: 00.00, build 77, source commit id: >> 876ac6906f31a43b6772b23c7c983ce9dcb18a19 >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to reset, ignore it. >> haswell-pcm-audio haswell-pcm-audio: warning: stream is NULL, no >> stream to free, ignore it. >> >> though sounds continues to work. >> > > Thanks once again for your input and time! > > I'll prepare patches for both issues. My guess is haswell-pcm could be > updated to handle 'platform' component param just fine, but it is > probably a change of more than few lines. I'd rather revert non-SOF > broadwell to its previous behavior and start a separate task from there. It'd be good to know why a dummy platform component is required though.