From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org
Cc: khilman@baylibre.com, Jyri Sarha <jsarha@ti.com>,
bgolaszewski@baylibre.com, tomi.valkeinen@ti.com,
laurent.pinchart@ideasonboard.com
Subject: [PATCH v3 05/11] drm/tilcdc: Fix load mode bit-field setting in tilcdc_crtc_enable()
Date: Tue, 22 Nov 2016 18:54:04 +0200 [thread overview]
Message-ID: <f6c0dbd4b67f0ce7fc1f8709e25daa18b03749b1.1479832733.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1479832733.git.jsarha@ti.com>
Set LCDC_PALETTE_LOAD_MODE bit-field with new tilcdc_write_mask()
instead of tilcdc_set(). Setting a bit-fields with tilcdc_set() is
fundamentally broken.
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index b3f35dc..0f89422 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -236,7 +236,9 @@ static void tilcdc_crtc_enable(struct drm_crtc *crtc)
tilcdc_crtc_enable_irqs(dev);
tilcdc_clear(dev, LCDC_DMA_CTRL_REG, LCDC_DUAL_FRAME_BUFFER_ENABLE);
- tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_PALETTE_LOAD_MODE(DATA_ONLY));
+ tilcdc_write_mask(dev, LCDC_RASTER_CTRL_REG,
+ LCDC_PALETTE_LOAD_MODE(DATA_ONLY),
+ LCDC_PALETTE_LOAD_MODE_MASK);
tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_RASTER_ENABLE);
drm_crtc_vblank_on(crtc);
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-22 16:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 16:53 [PATCH v3 00/11] drm/tilcdc: LCDC Revision 1 related fixes Jyri Sarha
2016-11-22 16:54 ` [PATCH v3 01/11] drm/tilcdc: Enable sync lost error and recovery handling for rev 1 LCDC Jyri Sarha
2016-11-23 13:24 ` Bartosz Golaszewski
2016-11-22 16:54 ` [PATCH v3 02/11] drm/tilcdc: implement palette loading for rev1 Jyri Sarha
2016-11-24 9:29 ` Tomi Valkeinen
2016-11-24 9:39 ` Jyri Sarha
2016-11-24 9:43 ` Tomi Valkeinen
2016-11-24 10:03 ` Jyri Sarha
2016-11-24 10:25 ` Tomi Valkeinen
2016-11-24 10:38 ` Jyri Sarha
2016-11-24 11:10 ` Tomi Valkeinen
2016-11-24 12:03 ` Jyri Sarha
2016-11-24 12:56 ` Tomi Valkeinen
2016-11-24 20:32 ` Jyri Sarha
2016-11-25 6:42 ` Daniel Vetter
2016-11-22 16:54 ` [PATCH v3 03/11] drm/tilcdc: Fix tilcdc_crtc_create() return value handling Jyri Sarha
2016-11-24 9:34 ` Tomi Valkeinen
2016-11-22 16:54 ` [PATCH v3 04/11] drm/tilcdc: Add tilcdc_write_mask() to tilcdc_regs.h Jyri Sarha
2016-11-22 16:54 ` Jyri Sarha [this message]
2016-11-22 16:54 ` [PATCH v3 06/11] drm/tilcdc: Enable palette loading for revision 2 LCDC too Jyri Sarha
2016-11-23 15:12 ` Bartosz Golaszewski
2016-11-24 9:37 ` Tomi Valkeinen
2016-11-24 9:40 ` Jyri Sarha
2016-11-22 16:54 ` [PATCH v3 07/11] drm/tilcdc: Add timeout wait for palette loading to complete Jyri Sarha
2016-11-24 9:38 ` Tomi Valkeinen
2016-11-22 16:54 ` [PATCH v3 08/11] drm/tilcdc: Call reset() before loading the palette Jyri Sarha
2016-11-22 16:54 ` [PATCH v3 09/11] drm/tilcdc: Use complete_all() to indicate completed palette loading Jyri Sarha
2016-11-22 16:54 ` [PATCH v3 10/11] drm/tilcdc: Load palette at the end of mode_set_nofb() Jyri Sarha
2016-11-22 16:54 ` [PATCH v3 11/11] drm/tilcdc: Enable frame done irq and functionality for LCDC rev 1 Jyri Sarha
2016-11-23 17:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6c0dbd4b67f0ce7fc1f8709e25daa18b03749b1.1479832733.git.jsarha@ti.com \
--to=jsarha@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.