From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyLxe-00048G-Jp for qemu-devel@nongnu.org; Tue, 20 Mar 2018 14:26:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyLxd-0008NA-ON for qemu-devel@nongnu.org; Tue, 20 Mar 2018 14:26:14 -0400 References: <20180320173632.25480-1-kwolf@redhat.com> <20180320173632.25480-6-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Tue, 20 Mar 2018 13:26:07 -0500 MIME-Version: 1.0 In-Reply-To: <20180320173632.25480-6-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, den@openvz.org, jcody@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org On 03/20/2018 12:36 PM, Kevin Wolf wrote: > Commit e39e959e fixed an invalid assertion in the .bdrv_length > implementation, but left a similar assertion in place for > .bdrv_truncate. Instead of crashing when the user requests a too large > image size, fail gracefully. > > A file size of exactly INT64_MAX caused failure before, but is actually > legal. > > Signed-off-by: Kevin Wolf > --- > block/crypto.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org