From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD780C4332F for ; Mon, 3 Jan 2022 05:42:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231709AbiACFmw (ORCPT ); Mon, 3 Jan 2022 00:42:52 -0500 Received: from marcansoft.com ([212.63.210.85]:55962 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbiACFmv (ORCPT ); Mon, 3 Jan 2022 00:42:51 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 9BCA4424D9; Mon, 3 Jan 2022 05:42:41 +0000 (UTC) Message-ID: Date: Mon, 3 Jan 2022 14:42:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 10/34] brcmfmac: firmware: Allow platform to override macaddr Content-Language: en-US To: Linus Walleij Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-11-marcan@marcan.st> From: Hector Martin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022/01/02 14:50, Linus Walleij wrote: > On Sun, Dec 26, 2021 at 4:37 PM Hector Martin wrote: > >> On Device Tree platforms, it is customary to be able to set the MAC >> address via the Device Tree, as it is often stored in system firmware. >> This is particularly relevant for Apple ARM64 platforms, where this >> information comes from system configuration and passed through by the >> bootloader into the DT. >> >> Implement support for this by fetching the platform MAC address and >> adding or replacing the macaddr= property in nvram. This becomes the >> dongle's default MAC address. >> >> On platforms with an SROM MAC address, this overrides it. On platforms >> without one, such as Apple ARM64 devices, this is required for the >> firmware to boot (it will fail if it does not have a valid MAC at all). >> >> Signed-off-by: Hector Martin > > This looks very helpful. > >> + /* Add space for properties we may add */ >> + size += strlen(BRCMF_FW_DEFAULT_BOARDREV) + 1; >> + size += BRCMF_FW_MACADDR_LEN + 1; > > Add some note to the commit log why you also make space for > boardrev? (Looks useful.) Is the boardrev spacing in the right > patch? Ah, that was a drive-by fix. While adding the MACADDR space I noticed we weren't allocating space for BOARDREV... not sure if any platforms hit this; it would cause an overflow if there are platforms with no board_rev in the nvram that also don't have enough comments/junk to otherwise make space for it. I'll move it to another patch so it's more evident, and it should get a Fixes: too. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub