From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965487AbdDZSul (ORCPT ); Wed, 26 Apr 2017 14:50:41 -0400 Received: from mout.web.de ([212.227.17.12]:59642 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbdDZSub (ORCPT ); Wed, 26 Apr 2017 14:50:31 -0400 Subject: Re: Checking error messages for failed memory allocations To: Joe Perches Cc: Subhash Jadavani , linux-scsi@vger.kernel.org, "James E. J. Bottomley" , "Martin K. Petersen" , Vinayak Holikatti , LKML , kernel-janitors@vger.kernel.org, Wolfram Sang , linux-scsi-owner@vger.kernel.org References: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net> <3d355c13-159a-2570-9ead-af93ad95c210@users.sourceforge.net> <019b6365c15b0764c156d6453648f7a2@codeaurora.org> <1493231242.18659.28.camel@perches.com> From: SF Markus Elfring Message-ID: Date: Wed, 26 Apr 2017 20:50:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <1493231242.18659.28.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:bjK2I6P8D4h527RjwkVzGidkbgIHZ+J+MEWyZPPYSo5pGyOOGd8 ZJteBw5AJHsiW5ZYG/wiXOg+fItdo8kJb0buo/2Sv0POWPq80E7od2IsFMOTdtFl3wxnmlZ tdYHqJqoy5D4whm0nZ3OVxxH1n8ToE0gTmu9g3KDuTNHIC7PQjRZmP6HBHj+EDVB+oxRyyQ YP+RtUkTlrV0+w7eNVtnQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:U+b+6d1yo/M=:gGn4X9fPILRBVtPdwP2kqj TyOhR6gYi2F8gJax4PxzGBC0+aZwP7lkuzFcHVNwWRJ+EEHILYE64Ji37mrvtmxDSPx054DHO u1e0TdUQAjzlheISWA0z4b8SUTmu21urednuT6ZCgsyEohlp3qFKs2sMGPlRgwJ1v2XqmXNJ9 JGqSMmmHDaTdizPKI6izgC/qF2SAK5XZbgUP4S3cq7QYS333gd+SI59u4vO2WLZIkcSDjbgjf NAjRFwIaVA54GI/nph8+QrXuauiJk5E49Yp50GDfE3GBhgMmBk5vtIgevO2Nc1FThUywxtlM1 xXkUdGx93rl6fehKHSlV4Vr18290vxFrdQATqDXM91L6LrK0EO5cXUTqOiO0UuZgdNuUsggSW 1mhviqMUAn3gP5dlj9pik4X8NwzMZ4Zz8EMpRhjl5IiLpmiSW98PvWcBFluKQav/tAd/zHEkr TGDeczKx8nA0R6FgnhBqmAyaeAccyaCX/r6xdKvuNwq166bfrxUFQherZTY0ZghT9IUwJWP9y jH3org2BMul3OE8OSrNomKXDtRQrkMvPZG2RJGPKsJ1Fxo+Paex34/GjZ324pNNg7gvY7OLjW F6h1of/UStmyIisOTHX5xP9pj8bYWJcBaO4ptm/hHLIP4Zq5lRb3kwb3gXcRbxqU0a6vIRhGk Lk7jBBW/Vnn1GbmcjJwl+HLfaecg3e407KfcZnF/MFLWpC85ABLc4WvJnfGINZkMK1a11cJNj cptd5yDyk47IGXThqHyBnlrbP9hDJ3Adsrw8m4E90itqouFqjHjoTXRj6pq+sl1hFkpSv2dWf lJ8eb0b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Basically most everything that has a gfp_t argument does a > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t. How do you think about to improve any programming interface documentation around such a function property? Are there any special checks needed for function implementations which can pass the flag “__GFP_NOWARN”? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 26 Apr 2017 18:50:13 +0000 Subject: Re: Checking error messages for failed memory allocations Message-Id: List-Id: References: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net> <3d355c13-159a-2570-9ead-af93ad95c210@users.sourceforge.net> <019b6365c15b0764c156d6453648f7a2@codeaurora.org> <1493231242.18659.28.camel@perches.com> In-Reply-To: <1493231242.18659.28.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Joe Perches Cc: Subhash Jadavani , linux-scsi@vger.kernel.org, "James E. J. Bottomley" , "Martin K. Petersen" , Vinayak Holikatti , LKML , kernel-janitors@vger.kernel.org, Wolfram Sang , linux-scsi-owner@vger.kernel.org > Basically most everything that has a gfp_t argument does a > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t. How do you think about to improve any programming interface documentation around such a function property? Are there any special checks needed for function implementations which can pass the flag “__GFP_NOWARN”? Regards, Markus