From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>
Subject: [PATCH] usb: core: hcd: merge repetitive strings in usb_hcd_request_irqs()
Date: Sat, 21 Aug 2021 23:48:38 +0300 [thread overview]
Message-ID: <f6ee0fdf-097b-797f-3f8c-beea7c73496e@omp.ru> (raw)
Two dev_info() calls in usb_hcd_request_irqs() have the same "io " strings
needlessly repeated. Merge these strings into the format strings of those
dev_info() calls...
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo...
drivers/usb/core/hcd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Index: usb/drivers/usb/core/hcd.c
===================================================================
--- usb.orig/drivers/usb/core/hcd.c
+++ usb/drivers/usb/core/hcd.c
@@ -2730,16 +2730,16 @@ static int usb_hcd_request_irqs(struct u
return retval;
}
hcd->irq = irqnum;
- dev_info(hcd->self.controller, "irq %d, %s 0x%08llx\n", irqnum,
- (hcd->driver->flags & HCD_MEMORY) ?
- "io mem" : "io base",
- (unsigned long long)hcd->rsrc_start);
+ dev_info(hcd->self.controller, "irq %d, io %s 0x%08llx\n",
+ irqnum, (hcd->driver->flags & HCD_MEMORY) ?
+ "mem" : "base",
+ (unsigned long long)hcd->rsrc_start);
} else {
hcd->irq = 0;
if (hcd->rsrc_start)
- dev_info(hcd->self.controller, "%s 0x%08llx\n",
+ dev_info(hcd->self.controller, "io %s 0x%08llx\n",
(hcd->driver->flags & HCD_MEMORY) ?
- "io mem" : "io base",
+ "mem" : "base",
(unsigned long long)hcd->rsrc_start);
}
return 0;
next reply other threads:[~2021-08-21 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 20:48 Sergey Shtylyov [this message]
2021-08-26 11:32 ` [PATCH] usb: core: hcd: merge repetitive strings in usb_hcd_request_irqs() Greg Kroah-Hartman
2021-08-26 17:39 ` Sergey Shtylyov
2021-08-27 15:56 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ee0fdf-097b-797f-3f8c-beea7c73496e@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.