From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Date: Mon, 11 Jun 2018 12:24:07 +0000 Subject: Re: [kvm-unit-tests PATCH] powerpc: Make code compilable with -Wmissing-prototypes Message-Id: List-Id: References: <1528717300-27112-1-git-send-email-thuth@redhat.com> In-Reply-To: <1528717300-27112-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On 11/06/2018 13:41, Thomas Huth wrote: > It's always better to check whether the implementations match the > prototypes, so make the code compilable with the -Wmissing-prototypes > compiler flag. (However, the flag is not turned on yet since the other > architectures are not ready for this yet) > > Signed-off-by: Thomas Huth > --- > lib/powerpc/asm/setup.h | 2 ++ > lib/powerpc/hcall.c | 2 ++ > lib/powerpc/io.c | 3 ++- > lib/powerpc/io.h | 8 ++++++++ > lib/powerpc/setup.c | 2 +- > powerpc/reloc64.c | 2 ++ > 6 files changed, 17 insertions(+), 2 deletions(-) > create mode 100644 lib/powerpc/io.h Reviewed-by: Laurent Vivier