From: Sibi Sankar <sibis@codeaurora.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: robh+dt@kernel.org, bjorn.andersson@linaro.org,
agross@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Date: Thu, 22 Aug 2019 12:09:46 +0530 [thread overview]
Message-ID: <f6f36181660057325742318519e541ad@codeaurora.org> (raw)
In-Reply-To: <1566383523.4193.5.camel@pengutronix.de>
Hey Philipp,
Thanks for the review!
On 2019-08-21 16:02, Philipp Zabel wrote:
> On Wed, 2019-08-21 at 15:24 +0530, Sibi Sankar wrote:
>> Add SC7180 AOSS reset to the list of possible bindings.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> index 510c748656ec5..8f0bbdc6afd91 100644
>> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> @@ -8,7 +8,8 @@ Required properties:
>> - compatible:
>> Usage: required
>> Value type: <string>
>> - Definition: must be:
>> + Definition: must be one of:
>> + "qcom,sc7180-aoss-cc"
>> "qcom,sdm845-aoss-cc"
>>
>> - reg:
>
> Does sc7180 have exactly the same resets (mss, camss, venus, gpu,
> dispss, wcss, and lpass) as sdm845? If so, it could be considered
> compatible, and the driver changes wouldn't be needed at all:
Yes they are identical both
AOSS and PDC resets.
>
> - Definition: must be:
> + Definition: must be one of:
> + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
>
> "qcom,sdm845-aoss-cc"
>
> Is there a reason not to do this?
I am fine with ^^, will change
them in v2.
>
> regards
> Philipp
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-08-22 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 9:54 [PATCH 0/4] Add PDC Global and AOSS reset support Sibi Sankar
2019-08-21 9:54 ` [PATCH 1/4] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar
2019-08-21 10:32 ` Philipp Zabel
2019-08-22 6:39 ` Sibi Sankar [this message]
2019-08-21 9:54 ` [PATCH 2/4] reset: qcom: aoss: Add support " Sibi Sankar
2019-08-21 9:54 ` [PATCH 3/4] dt-bindings: reset: pdc: Add PDC Global binding " Sibi Sankar
2019-08-21 9:54 ` [PATCH 4/4] reset: qcom: pdc: Add support " Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6f36181660057325742318519e541ad@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.