From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A0ACCA47F for ; Mon, 13 Jun 2022 19:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244476AbiFMTkQ (ORCPT ); Mon, 13 Jun 2022 15:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245294AbiFMTkH (ORCPT ); Mon, 13 Jun 2022 15:40:07 -0400 Received: from smtp-bc0b.mail.infomaniak.ch (smtp-bc0b.mail.infomaniak.ch [IPv6:2001:1600:3:17::bc0b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED2C213D3D for ; Mon, 13 Jun 2022 11:06:12 -0700 (PDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4LMKJ12cnCzMqMX3; Mon, 13 Jun 2022 20:06:09 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4LMKHx4fv8zlqQHK; Mon, 13 Jun 2022 20:06:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1655143569; bh=6V0xLAgnaKegpa6qvcm9opCXJieMVgO6NIinoOfSkmQ=; h=Date:To:Cc:References:From:Subject:In-Reply-To:From; b=B4dVtViDU3L7AvfOcgxrH+CTy/oyH6pNvblHsoGEy4jJ+KsICrtKzt/AwU1ndUlf7 O2UmFxfBQfnkJ3m69/GGGjclPGZf3OBSAKGAuc3MWf21IbPwsBmnGVruUTpjdTp/4k z1LkPxgOJqO+z55Fav51erAELvxVmLaprQF/cwMo= Message-ID: Date: Mon, 13 Jun 2022 20:06:04 +0200 MIME-Version: 1.0 User-Agent: Content-Language: en-US To: Masahiro Yamada Cc: Linux Kbuild mailing list , David Howells , Jarkko Sakkinen , David Woodhouse , keyrings@vger.kernel.org, Linux Kernel Mailing List , Eric Snowberg , Herbert Xu , Tyler Hicks References: <20220611172233.1494073-1-masahiroy@kernel.org> <20220611172233.1494073-2-masahiroy@kernel.org> <58a20890-557e-f31c-ed59-7e256445a26c@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Subject: Re: [PATCH 2/4] certs: fix and refactor CONFIG_SYSTEM_BLACKLIST_HASH_LIST build In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On 13/06/2022 16:55, Masahiro Yamada wrote: > On Mon, Jun 13, 2022 at 9:34 PM Mickaël Salaün wrote: >> >> >> >> On 11/06/2022 19:22, Masahiro Yamada wrote: >>> Commit addf466389d9 ("certs: Check that builtin blacklist hashes are >>> valid") was applied 8 months after the submission. >>> >>> In the meantime, the base code had been removed by commit b8c96a6b466c >>> ("certs: simplify $(srctree)/ handling and remove config_filename >>> macro"). >>> >>> Fix the Makefile. >>> >>> Create a local copy of $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST). It is >>> included from certs/blacklist_hashes.c and also works as a timestamp. >>> >>> Send error messages from check-blacklist-hashes.awk to stderr instead >>> of stdout. >>> >>> Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are valid") >>> Signed-off-by: Masahiro Yamada >> >> Reviewed-by: Mickaël Salaün >> >> As a side note, it may let an orphan certs/blacklist_hashes_checked file >> but we can't really do something about that and it's OK. > > > GNU Make uses timestamps of files for dependency tracking, > so Kbuild keeps all intermediate files. > > Keeping certs/blacklist_hashes_checked > is the right thing to do. blacklist_hashes_checked is the file you replaced with blacklist_hash_list, and is then not used in any Makefile anymore. There is then no timestamp issue. I just wanted to mention that it is normal that a git status will show it on build directories also used as source directories that were already using such feature. > > > >> Thanks! >> >>> --- >>> >>> certs/.gitignore | 2 +- >>> certs/Makefile | 20 ++++++++++---------- >>> certs/blacklist_hashes.c | 2 +- >>> 3 files changed, 12 insertions(+), 12 deletions(-) >>> >>> diff --git a/certs/.gitignore b/certs/.gitignore >>> index 56637aceaf81..cec5465f31c1 100644 >>> --- a/certs/.gitignore >>> +++ b/certs/.gitignore >>> @@ -1,5 +1,5 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> -/blacklist_hashes_checked >>> +/blacklist_hash_list >>> /extract-cert >>> /x509_certificate_list >>> /x509_revocation_list >>> diff --git a/certs/Makefile b/certs/Makefile >>> index cb1a9da3fc58..a8d628fd5f7b 100644 >>> --- a/certs/Makefile >>> +++ b/certs/Makefile >>> @@ -7,22 +7,22 @@ obj-$(CONFIG_SYSTEM_TRUSTED_KEYRING) += system_keyring.o system_certificates.o c >>> obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist.o common.o >>> obj-$(CONFIG_SYSTEM_REVOCATION_LIST) += revocation_certificates.o >>> ifneq ($(CONFIG_SYSTEM_BLACKLIST_HASH_LIST),) >>> -quiet_cmd_check_blacklist_hashes = CHECK $(patsubst "%",%,$(2)) >>> - cmd_check_blacklist_hashes = $(AWK) -f $(srctree)/scripts/check-blacklist-hashes.awk $(2); touch $@ >>> >>> -$(eval $(call config_filename,SYSTEM_BLACKLIST_HASH_LIST)) >>> +$(obj)/blacklist_hashes.o: $(obj)/blacklist_hash_list >>> +CFLAGS_blacklist_hashes.o := -I $(obj) >>> >>> -$(obj)/blacklist_hashes.o: $(obj)/blacklist_hashes_checked >>> +quiet_cmd_check_and_copy_blacklist_hash_list = GEN $@ >>> + cmd_check_and_copy_blacklist_hash_list = \ >>> + $(AWK) -f $(srctree)/scripts/check-blacklist-hashes.awk $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) >&2; \ >>> + cat $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) > $@ >>> >>> -CFLAGS_blacklist_hashes.o += -I$(srctree) >>> - >>> -targets += blacklist_hashes_checked >>> -$(obj)/blacklist_hashes_checked: $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) scripts/check-blacklist-hashes.awk FORCE >>> - $(call if_changed,check_blacklist_hashes,$(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(CONFIG_SYSTEM_BLACKLIST_HASH_LIST)) >>> +$(obj)/blacklist_hash_list: $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) FORCE >>> + $(call if_changed,check_and_copy_blacklist_hash_list) >>> obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_hashes.o >>> else >>> obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_nohashes.o >>> endif >>> +targets += blacklist_hash_list >>> >>> quiet_cmd_extract_certs = CERT $@ >>> cmd_extract_certs = $(obj)/extract-cert $(extract-cert-in) $@ >>> @@ -33,7 +33,7 @@ $(obj)/system_certificates.o: $(obj)/x509_certificate_list >>> $(obj)/x509_certificate_list: $(CONFIG_SYSTEM_TRUSTED_KEYS) $(obj)/extract-cert FORCE >>> $(call if_changed,extract_certs) >>> >>> -targets += x509_certificate_list blacklist_hashes_checked >>> +targets += x509_certificate_list >>> >>> # If module signing is requested, say by allyesconfig, but a key has not been >>> # supplied, then one will need to be generated to make sure the build does not >>> diff --git a/certs/blacklist_hashes.c b/certs/blacklist_hashes.c >>> index d5961aa3d338..86d66fe11348 100644 >>> --- a/certs/blacklist_hashes.c >>> +++ b/certs/blacklist_hashes.c >>> @@ -2,6 +2,6 @@ >>> #include "blacklist.h" >>> >>> const char __initconst *const blacklist_hashes[] = { >>> -#include CONFIG_SYSTEM_BLACKLIST_HASH_LIST >>> +#include "blacklist_hash_list" >>> , NULL >>> }; > > > > -- > Best Regards > Masahiro Yamada