From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sat, 12 Oct 2019 13:47:06 +0200
Subject: [U-Boot] [PATCH v1 03/11] include: kernel.h: include printk.h
In-Reply-To: <20191011074200.30269-4-takahiro.akashi@linaro.org>
References: <20191011074200.30269-1-takahiro.akashi@linaro.org>
 <20191011074200.30269-4-takahiro.akashi@linaro.org>
Message-ID: <f6fd51c2-dd6a-1a52-a871-31c127048589@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/11/19 9:41 AM, AKASHI Takahiro wrote:
> Adding "printk.h" will help improve portability from linux kernel
> code (in my case, lib/asn1_decoder.c).
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>   include/linux/kernel.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index a85c15d8dc28..919d12bdf89c 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -2,7 +2,9 @@
>   #define _LINUX_KERNEL_H
>
>
> +#include <vsprintf.h> /* for printf utilities */

Kernel code has no vsprintf.h. Linux's lib/asn1_decoder.c has not a
single print statement. So why are you inserting vsprintf.h here?

>   #include <linux/types.h>
> +#include <linux/printk.h>

Linux include/linux/kernel.h also includes printk.h. OK.

Best regards

Heinrich
>
>   #define USHRT_MAX	((u16)(~0U))
>   #define SHRT_MAX	((s16)(USHRT_MAX>>1))
>