From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351B4C11F65 for ; Wed, 30 Jun 2021 11:46:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18AC161481 for ; Wed, 30 Jun 2021 11:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234255AbhF3LtG (ORCPT ); Wed, 30 Jun 2021 07:49:06 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:42838 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234148AbhF3LtG (ORCPT ); Wed, 30 Jun 2021 07:49:06 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F068C1FE78; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id BED97118DD; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id 3PCMLZxZ3GC3OQAALh3uQQ (envelope-from ); Wed, 30 Jun 2021 11:46:36 +0000 Subject: Re: [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer To: Greg KH Cc: matthew.brost@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, stable@vger.kernel.org, lucas.demarchi@intel.com References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: Date: Wed, 30 Jun 2021 13:46:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: multipart/mixed; boundary="3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb"; protected-headers="v1" From: Thomas Zimmermann To: Greg KH Cc: matthew.brost@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, stable@vger.kernel.org, lucas.demarchi@intel.com Message-ID: Subject: Re: [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> In-Reply-To: --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 30.06.21 um 12:06 schrieb Greg KH: > On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: >> Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrup= t >> functions directly. >> >> v2: >> * also remove an outdated comment >> * move IRQ fix into separate patch >> * update Fixes tag (Daniel) >> >> Signed-off-by: Thomas Zimmermann >> Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Cc: Chris Wilson >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: intel-gfx@lists.freedesktop.org >> Cc: # v5.4+ >> --- >> drivers/gpu/drm/i915/i915_drv.c | 1 - >> drivers/gpu/drm/i915/i915_irq.c | 5 ----- >> 2 files changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i9= 15_drv.c >> index 850b499c71c8..73de45472f60 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -42,7 +42,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> =20 >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i9= 15_irq.c >> index 2203dca19895..1d4c683c9de9 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -33,7 +33,6 @@ >> #include >> =20 >> #include >> -#include >> =20 >> #include "display/intel_de.h" >> #include "display/intel_display_types.h" >> @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct = drm_i915_private *dev_priv) >> =20 >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv) >> { >> - /* >> - * We only use drm_irq_uninstall() at unload and VT switch, so >> - * this is the only thing we need to check. >> - */ >> return dev_priv->runtime_pm.irqs_enabled; >> } >> =20 >> --=20 >> 2.32.0 >> >=20 > How is this a stable-kernel-related fix? Sorry, it isn't. I forgot to remove the rsp Cc tag. Best regards Thomas >=20 > thanks, >=20 > greg k-h >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb-- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmDcWZwFAwAAAAAACgkQlh/E3EQov+A2 ew/+Mj6/gdeqqVkIBhzsJb9KT8UBkWGzxg38FP4FNtE1dzU/3Ej3cZqns09ga7Jgx7CJQNkDDmVk DT4IVotp6d+0vUjm4IrBHf4YrfM1HFfWb0xlwPz5Ku7GbAfwL7JVEoOc/zx7oJyWwx5xmwOWpoQ6 SUynEmC4/G9Hwd8YpH66u+26bVNb/94ungvIT1ag7wwMSmNZTHHPAz3MXLEMW7ExCNRXhaAR+ELm CH4Qu3KUO1BgAuS7bAs4xBWq+S7SEnL3cj5XJ56GQYJYtILhSQ5coIjY5Py9Rkw4niQQMBNaYrh9 /TLUTDtPjXOkTNhEbb2wD6MvzxgTx42nV0oVjNDYpqefMxdAvs3GHfsWL73Q/Pe35B6WRzsYZ8ie L3A9wIrdrwoR945Gpp+iepECiiM6bDyWsLOFg9I2IHuYhsaAQmXJN1OCFe6EqNOT/Nm+i3I9HAGw +SG1ufL3CjxBvMI5DinnmeKHIaQIo7Zjc8uXjj8zJeLJgzMZ9Y5pe/UYf2d7haMZ3HdUfq6pNTPE GU+7t0+jOB1hQhWtJbmTrOqyNNFT50g+woAPjEU/GzNxzk4ufwkr1v6IGM4bfA09/lFQ9XgKIV/0 89LwaGDgDdv1LsR4oTvUBjuSUt1IKdijI0Bdw90zE30EThRSF4wz4ugIvrwzAmWjdEsW4A0bO/zu fUA= =RLlo -----END PGP SIGNATURE----- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22374C11F6A for ; Wed, 30 Jun 2021 11:46:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD4B461481 for ; Wed, 30 Jun 2021 11:46:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD4B461481 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D4BB6E999; Wed, 30 Jun 2021 11:46:40 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 486956E998; Wed, 30 Jun 2021 11:46:38 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F068C1FE78; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id BED97118DD; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id 3PCMLZxZ3GC3OQAALh3uQQ (envelope-from ); Wed, 30 Jun 2021 11:46:36 +0000 Subject: Re: [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer To: Greg KH References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: Date: Wed, 30 Jun 2021 13:46:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: matthew.brost@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, stable@vger.kernel.org, rodrigo.vivi@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: multipart/mixed; boundary="3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb"; protected-headers="v1" From: Thomas Zimmermann To: Greg KH Cc: matthew.brost@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, stable@vger.kernel.org, lucas.demarchi@intel.com Message-ID: Subject: Re: [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> In-Reply-To: --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 30.06.21 um 12:06 schrieb Greg KH: > On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: >> Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrup= t >> functions directly. >> >> v2: >> * also remove an outdated comment >> * move IRQ fix into separate patch >> * update Fixes tag (Daniel) >> >> Signed-off-by: Thomas Zimmermann >> Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Cc: Chris Wilson >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: intel-gfx@lists.freedesktop.org >> Cc: # v5.4+ >> --- >> drivers/gpu/drm/i915/i915_drv.c | 1 - >> drivers/gpu/drm/i915/i915_irq.c | 5 ----- >> 2 files changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i9= 15_drv.c >> index 850b499c71c8..73de45472f60 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -42,7 +42,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> =20 >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i9= 15_irq.c >> index 2203dca19895..1d4c683c9de9 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -33,7 +33,6 @@ >> #include >> =20 >> #include >> -#include >> =20 >> #include "display/intel_de.h" >> #include "display/intel_display_types.h" >> @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct = drm_i915_private *dev_priv) >> =20 >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv) >> { >> - /* >> - * We only use drm_irq_uninstall() at unload and VT switch, so >> - * this is the only thing we need to check. >> - */ >> return dev_priv->runtime_pm.irqs_enabled; >> } >> =20 >> --=20 >> 2.32.0 >> >=20 > How is this a stable-kernel-related fix? Sorry, it isn't. I forgot to remove the rsp Cc tag. Best regards Thomas >=20 > thanks, >=20 > greg k-h >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb-- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmDcWZwFAwAAAAAACgkQlh/E3EQov+A2 ew/+Mj6/gdeqqVkIBhzsJb9KT8UBkWGzxg38FP4FNtE1dzU/3Ej3cZqns09ga7Jgx7CJQNkDDmVk DT4IVotp6d+0vUjm4IrBHf4YrfM1HFfWb0xlwPz5Ku7GbAfwL7JVEoOc/zx7oJyWwx5xmwOWpoQ6 SUynEmC4/G9Hwd8YpH66u+26bVNb/94ungvIT1ag7wwMSmNZTHHPAz3MXLEMW7ExCNRXhaAR+ELm CH4Qu3KUO1BgAuS7bAs4xBWq+S7SEnL3cj5XJ56GQYJYtILhSQ5coIjY5Py9Rkw4niQQMBNaYrh9 /TLUTDtPjXOkTNhEbb2wD6MvzxgTx42nV0oVjNDYpqefMxdAvs3GHfsWL73Q/Pe35B6WRzsYZ8ie L3A9wIrdrwoR945Gpp+iepECiiM6bDyWsLOFg9I2IHuYhsaAQmXJN1OCFe6EqNOT/Nm+i3I9HAGw +SG1ufL3CjxBvMI5DinnmeKHIaQIo7Zjc8uXjj8zJeLJgzMZ9Y5pe/UYf2d7haMZ3HdUfq6pNTPE GU+7t0+jOB1hQhWtJbmTrOqyNNFT50g+woAPjEU/GzNxzk4ufwkr1v6IGM4bfA09/lFQ9XgKIV/0 89LwaGDgDdv1LsR4oTvUBjuSUt1IKdijI0Bdw90zE30EThRSF4wz4ugIvrwzAmWjdEsW4A0bO/zu fUA= =RLlo -----END PGP SIGNATURE----- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2810CC11F69 for ; Wed, 30 Jun 2021 11:46:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E094161481 for ; Wed, 30 Jun 2021 11:46:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E094161481 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D82D6E998; Wed, 30 Jun 2021 11:46:39 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 486956E998; Wed, 30 Jun 2021 11:46:38 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F068C1FE78; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id BED97118DD; Wed, 30 Jun 2021 11:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=tJGnx50LItyXg+3ay7yc5RxaubPmuUJ2C6VEeJRSmR7KVoZd3twsQqmIILl5q5yHqjUNSc bPo/EVCReukxBjMnFenqiIGIXyoKJK3KnEt8zSEBB0DUjNtK0D9XuGGcpomqaRfwUkwT3p GXU6EwCx+BWRNBgQnxMU9sESnysLWV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625053596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJlJKRCeEkCggsWzP6gvoOKOja7JUXFm1Gs9/8pxrws=; b=BH/5z9IcCR4lrwkENCPdTwZF+sspQ8TL9VzmrE61rdFbANMPsJSNuyx5UMJBtSnn267tGv aZw6yqAABSPwQ/AA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id 3PCMLZxZ3GC3OQAALh3uQQ (envelope-from ); Wed, 30 Jun 2021 11:46:36 +0000 To: Greg KH References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: Date: Wed, 30 Jun 2021 13:46:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, stable@vger.kernel.org Content-Type: multipart/mixed; boundary="===============2093770284==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2093770284== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: multipart/mixed; boundary="3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb"; protected-headers="v1" From: Thomas Zimmermann To: Greg KH Cc: matthew.brost@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, stable@vger.kernel.org, lucas.demarchi@intel.com Message-ID: Subject: Re: [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer References: <20210630095228.6665-1-tzimmermann@suse.de> <20210630095228.6665-3-tzimmermann@suse.de> In-Reply-To: --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 30.06.21 um 12:06 schrieb Greg KH: > On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: >> Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrup= t >> functions directly. >> >> v2: >> * also remove an outdated comment >> * move IRQ fix into separate patch >> * update Fixes tag (Daniel) >> >> Signed-off-by: Thomas Zimmermann >> Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Cc: Chris Wilson >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: intel-gfx@lists.freedesktop.org >> Cc: # v5.4+ >> --- >> drivers/gpu/drm/i915/i915_drv.c | 1 - >> drivers/gpu/drm/i915/i915_irq.c | 5 ----- >> 2 files changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i9= 15_drv.c >> index 850b499c71c8..73de45472f60 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -42,7 +42,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> =20 >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i9= 15_irq.c >> index 2203dca19895..1d4c683c9de9 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -33,7 +33,6 @@ >> #include >> =20 >> #include >> -#include >> =20 >> #include "display/intel_de.h" >> #include "display/intel_display_types.h" >> @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct = drm_i915_private *dev_priv) >> =20 >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv) >> { >> - /* >> - * We only use drm_irq_uninstall() at unload and VT switch, so >> - * this is the only thing we need to check. >> - */ >> return dev_priv->runtime_pm.irqs_enabled; >> } >> =20 >> --=20 >> 2.32.0 >> >=20 > How is this a stable-kernel-related fix? Sorry, it isn't. I forgot to remove the rsp Cc tag. Best regards Thomas >=20 > thanks, >=20 > greg k-h >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --3S6GyhA9ETC7gdifDc31QiS0vgvwdsfJb-- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmDcWZwFAwAAAAAACgkQlh/E3EQov+A2 ew/+Mj6/gdeqqVkIBhzsJb9KT8UBkWGzxg38FP4FNtE1dzU/3Ej3cZqns09ga7Jgx7CJQNkDDmVk DT4IVotp6d+0vUjm4IrBHf4YrfM1HFfWb0xlwPz5Ku7GbAfwL7JVEoOc/zx7oJyWwx5xmwOWpoQ6 SUynEmC4/G9Hwd8YpH66u+26bVNb/94ungvIT1ag7wwMSmNZTHHPAz3MXLEMW7ExCNRXhaAR+ELm CH4Qu3KUO1BgAuS7bAs4xBWq+S7SEnL3cj5XJ56GQYJYtILhSQ5coIjY5Py9Rkw4niQQMBNaYrh9 /TLUTDtPjXOkTNhEbb2wD6MvzxgTx42nV0oVjNDYpqefMxdAvs3GHfsWL73Q/Pe35B6WRzsYZ8ie L3A9wIrdrwoR945Gpp+iepECiiM6bDyWsLOFg9I2IHuYhsaAQmXJN1OCFe6EqNOT/Nm+i3I9HAGw +SG1ufL3CjxBvMI5DinnmeKHIaQIo7Zjc8uXjj8zJeLJgzMZ9Y5pe/UYf2d7haMZ3HdUfq6pNTPE GU+7t0+jOB1hQhWtJbmTrOqyNNFT50g+woAPjEU/GzNxzk4ufwkr1v6IGM4bfA09/lFQ9XgKIV/0 89LwaGDgDdv1LsR4oTvUBjuSUt1IKdijI0Bdw90zE30EThRSF4wz4ugIvrwzAmWjdEsW4A0bO/zu fUA= =RLlo -----END PGP SIGNATURE----- --AhhbWt4vrssvgdxfMnbJHBB34rATnM0Rf-- --===============2093770284== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2093770284==--