From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A70C433EF for ; Wed, 23 Mar 2022 15:06:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242895AbiCWPHn (ORCPT ); Wed, 23 Mar 2022 11:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237698AbiCWPHi (ORCPT ); Wed, 23 Mar 2022 11:07:38 -0400 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A13CF13F6C; Wed, 23 Mar 2022 08:06:07 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id bi12so3455727ejb.3; Wed, 23 Mar 2022 08:06:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=cNxSQx97vgtvb107U/L1ql0G+sBh/iewmtdw4bJS2bw=; b=iaIMmy59Tutmd3P8Ji7Zmyw/LVBL71gQAkdI+U8FNN6tJbPLWS6q2cBlmSFrWcWSj8 15kK8HEgWMNmzUaqqDkIdacm8Fqr5R8EToYP6l+3NP9+R7X6IM7mFVkN8/SejSDONvfm ZUIoymQHMjJ54m1Jlj0TF8ab43x/yDFrcJq/XZB3+PQDt65EjtXCXKwtSJUUr5s9E3wr tJEHrdpg+H3vfI7enIYbDdjFacCXKGkwkTpAKkvxaJQYOb/se450qIWCmvgWemyaYYr3 od0vyrVl0FW5F0lRUdxVDJ6cVh+MEpyz1WR2lhFLAwCCGCOJpRQUYRFnJiEJrVUzsaVC cQIg== X-Gm-Message-State: AOAM533YusMqlabcOdKqvhCsDsIGsQBF/zfDmr8JufLo+bK3ve98bHB7 Nq+vRcOrNJg4r4yHmr6JmpA8YQiIJticpw== X-Google-Smtp-Source: ABdhPJxB195zpfiu3gCQWy7ZE1/RrY52u6+CtkeCsd4ZpF2kkg4TPNd/m84pPRlB+Kt55l2EHvzFCg== X-Received: by 2002:a17:906:7751:b0:6ce:e3c:81a6 with SMTP id o17-20020a170906775100b006ce0e3c81a6mr435071ejn.278.1648047966103; Wed, 23 Mar 2022 08:06:06 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id v4-20020a170906338400b006d5aca9fc80sm50074eja.106.2022.03.23.08.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 08:06:05 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 16:06:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec Content-Language: en-US To: Jonathan Bakker , alim.akhtar@samsung.com Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220322201144.20320-1-xc-racer2@live.ca> <51007577-52a2-60a5-0720-7b2c7f78ae3e@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/2022 15:59, Jonathan Bakker wrote: > Hi Krzysztof, > > On 2022-03-23 3:54 a.m., Krzysztof Kozlowski wrote: >> On 22/03/2022 21:11, Jonathan Bakker wrote: >>> Memory nodes should only have a singular reg property in them, so >>> split the memory nodes such that there is only per node. >>> >>> Signed-off-by: Jonathan Bakker >>> --- >>> arch/arm/boot/dts/s5pv210-aquila.dts | 8 ++++++-- >>> arch/arm/boot/dts/s5pv210-aries.dtsi | 14 +++++++++++--- >>> arch/arm/boot/dts/s5pv210-goni.dts | 14 +++++++++++--- >>> 3 files changed, 28 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts >>> index 6423348034b6..6984479ddba3 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aquila.dts >>> +++ b/arch/arm/boot/dts/s5pv210-aquila.dts >>> @@ -29,8 +29,12 @@ >>> >>> memory@30000000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x18000000>; >>> + reg = <0x30000000 0x05000000>; >>> + }; >>> + >>> + memory@40000000 { >>> + device_type = "memory"; >>> + reg = <0x40000000 0x18000000>; >>> }; >>> >>> pmic_ap_clk: clock-0 { >>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> index 160f8cd9a68d..70ff56daf4cb 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi >>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> @@ -24,9 +24,17 @@ >>> >>> memory@30000000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x10000000 >>> - 0x50000000 0x08000000>; >> >> 0x40000000 to 0x58000000 is continues, so I wonder why it is split? Look >> at Aquila DTS. >> >> > > Yes, it was split in the vendor kernel as well [1], and that's been continued along > here. I personally don't see a reason to keep it split, but there might be something > I'm not aware of. > I guess they wanted maybe to express the physical banks. Fine with me. Just your explanation is not entirely correct: > Memory nodes should only have a singular reg property in them, one reg but it can have multiple items. Why do think multiple reg items is not allowed? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91CE3C433EF for ; Wed, 23 Mar 2022 15:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vtao+0pwIPXpg65aPu/Ibp0KUx7VC43txZgV9Ip8leU=; b=u5RD3+vZnZ1IP6 V3pshOAk86MghqY3JY23eoMDs37pvN6Qv/ZhYl01L41Cdd1+5woth1jJE7SIFJg/0ZZC1B2V4GE4q MCiBGS6Ql6FC2E1V769j+mZGG3ZOX1BNdUubvPb7VfZlqnkaq/vjQY6yOEbUtIuD7618S0tt6Tfak Z2TZ3IgxHfKWfxC1/5xLO0lxn4PBslDvOg9E1FvzRKQh0xgO8snj3PZoU45J6MbL1ZYlxOtfR5q4w laQY0BVoDBJ46W12RYauACda9ss3kDL4Q1B0P31HDPwhDH73NsyRFQOBpM93S4uQ1NctaQwnwbzpM IW0xmuJIP1FhPuo+s+UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX2Yu-00E0Ck-Ly; Wed, 23 Mar 2022 15:06:12 +0000 Received: from mail-ej1-f50.google.com ([209.85.218.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX2Yr-00E0C4-Bz for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 15:06:10 +0000 Received: by mail-ej1-f50.google.com with SMTP id qx21so3384244ejb.13 for ; Wed, 23 Mar 2022 08:06:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=cNxSQx97vgtvb107U/L1ql0G+sBh/iewmtdw4bJS2bw=; b=Pj6wdpQjdQyZ1Dlamx7j5YX8ByaXzCU3Bxv/flha1KAwgRrj4wUQ0W3yYPXq+JbDZm en87GD6Xk4NNJp56w41UjSCr3SCl43MLNPewa8Uf3KnPsb00kB7hxkLhxtXqu5PTFj3Q rj9CWp5i6kw/AORg+YOSfdMy1F3rnP8mF9NX0YPBamtvPH29AMkLDgWAYeDiHjdHhZYr ZXDyHT/xWNR9UTKzF/DwhjWgtMHOKpwD21EkK1N8SEwMP5T7eB5AbIL+Beauaw93O0Ni GxImddgNUZI3/tzuW4kIUg6X/uxaCEDp9EeIjkzz3kxH6pDpNDgPMniFqJX6ZboOJ6YI +S6A== X-Gm-Message-State: AOAM532OusW7397a2zDJqsR6Q5xDB+Os00zepEvl8FB7tvYo8K3fnU9M eidGjEpYSSY5KlVXQz3Coc0= X-Google-Smtp-Source: ABdhPJxB195zpfiu3gCQWy7ZE1/RrY52u6+CtkeCsd4ZpF2kkg4TPNd/m84pPRlB+Kt55l2EHvzFCg== X-Received: by 2002:a17:906:7751:b0:6ce:e3c:81a6 with SMTP id o17-20020a170906775100b006ce0e3c81a6mr435071ejn.278.1648047966103; Wed, 23 Mar 2022 08:06:06 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id v4-20020a170906338400b006d5aca9fc80sm50074eja.106.2022.03.23.08.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 08:06:05 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 16:06:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec Content-Language: en-US To: Jonathan Bakker , alim.akhtar@samsung.com Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220322201144.20320-1-xc-racer2@live.ca> <51007577-52a2-60a5-0720-7b2c7f78ae3e@kernel.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_080609_448869_DE996DC5 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/03/2022 15:59, Jonathan Bakker wrote: > Hi Krzysztof, > > On 2022-03-23 3:54 a.m., Krzysztof Kozlowski wrote: >> On 22/03/2022 21:11, Jonathan Bakker wrote: >>> Memory nodes should only have a singular reg property in them, so >>> split the memory nodes such that there is only per node. >>> >>> Signed-off-by: Jonathan Bakker >>> --- >>> arch/arm/boot/dts/s5pv210-aquila.dts | 8 ++++++-- >>> arch/arm/boot/dts/s5pv210-aries.dtsi | 14 +++++++++++--- >>> arch/arm/boot/dts/s5pv210-goni.dts | 14 +++++++++++--- >>> 3 files changed, 28 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts >>> index 6423348034b6..6984479ddba3 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aquila.dts >>> +++ b/arch/arm/boot/dts/s5pv210-aquila.dts >>> @@ -29,8 +29,12 @@ >>> >>> memory@30000000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x18000000>; >>> + reg = <0x30000000 0x05000000>; >>> + }; >>> + >>> + memory@40000000 { >>> + device_type = "memory"; >>> + reg = <0x40000000 0x18000000>; >>> }; >>> >>> pmic_ap_clk: clock-0 { >>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> index 160f8cd9a68d..70ff56daf4cb 100644 >>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi >>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi >>> @@ -24,9 +24,17 @@ >>> >>> memory@30000000 { >>> device_type = "memory"; >>> - reg = <0x30000000 0x05000000 >>> - 0x40000000 0x10000000 >>> - 0x50000000 0x08000000>; >> >> 0x40000000 to 0x58000000 is continues, so I wonder why it is split? Look >> at Aquila DTS. >> >> > > Yes, it was split in the vendor kernel as well [1], and that's been continued along > here. I personally don't see a reason to keep it split, but there might be something > I'm not aware of. > I guess they wanted maybe to express the physical banks. Fine with me. Just your explanation is not entirely correct: > Memory nodes should only have a singular reg property in them, one reg but it can have multiple items. Why do think multiple reg items is not allowed? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel