From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792AbdBVBk1 (ORCPT ); Tue, 21 Feb 2017 20:40:27 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:48762 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbdBVBkS (ORCPT ); Tue, 21 Feb 2017 20:40:18 -0500 X-AuditID: b6c32a35-f79d66d000001a37-b7-58acebffb46e Subject: Re: [PATCH v10 0/3] Add support for the S6E3HA2 panel on TM2 board To: thierry.reding@gmail.com, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kgene@kernel.org, krzk@kernel.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, javier@osg.samsung.com, inki.dae@samsung.com, a.hajda@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, Andi Shyti , Hoegeun Kwon From: Hoegeun Kwon Message-id: Date: Wed, 22 Feb 2017 10:40:14 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <50768133-aabc-6050-c9b2-8898bb8046a6@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHJsWRmVeSWpSXmKPExsWy7bCmru7/12siDGY1SVvcWneO1aL33Ekm i+1HnrFavF/Ww2hx/ctzVov5R4ASV76+Z7N4v7yLzWLS/QksFm/ermGyuPGrjdWi//FrZovz 5zewW2x6fI3V4vKuOWwWM87vY7JYev0ik0Xr3iPsFj93zWOxePnxBIuDiMeaeWsYPXbOusvu sWlVJ5vH9m8PWD3udx9n8ti8pN5jSz9QvG/LKkaPz5vkAjijUm0yUhNTUosUUvOS81My89Jt lbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgF5TUihLzCkFCgUkFhcr6dvZFOWXlqQq ZOQXl9gqRRsaGukZGpjrGRkZ6ZkYx1oZmQKVJKRmdF7UKWhVqFj7tZe5gfGrRBcjJ4eEgIlE 84t5LBC2mMSFe+vZuhi5OIQEdjBKrLy3mxnCaWeSOLXzCDtMx9lt6xkhEssZJTZOboBy7jJK HDg0hQmkSljAW2LKhBdgs0QE1jJKNBx+CFbFLPCOSWLO/4+sIFVsAroSX3uuA3VwcPAK2Em8 /GEBEmYRUJXo/30GrERUIEJix40eNhCbV0BQ4sfke2DHcgrYS6zfdYURxGYWcJR4sGgnK4Qt L7F5zVuwuyUElnJIdK7exgwyX0JAVmLTAWaIF1wkjt9vgHpHWOLV8S1QtrTEqn+3mCB6uxkl vjetgBo0gVHiZ8MGqG5jifsP7jFDbOOTePe1hxViAa9ER5sQRImHxOGtjVBDgY77uA8aqpMY JZ72/WCZwCg/C8lDs5A8MQvJEwsYmVcxiqUWFOempxYbFhjqFSfmFpfmpesl5+duYgSnbS3T HYxTzvkcYhTgYFTi4X3gviZCiDWxrLgy9xCjBAezkgjvpJ1AId6UxMqq1KL8+KLSnNTiQ4ym wECeyCwlmpwPzCl5JfGGJmaGJkYmhobmRgZGSuK8rAYTI4QE0hNLUrNTUwtSi2D6mDg4pRoY ++riKw9+1f7q/L04hu3HmgOPvP/8fLxRXfpBp8asvnflOxuDpp5cXaq7811TfpjH99xLEyap 1GTcfPuV/ZC7f/nuJG2Z5QwmkRtPv79xbpmJyrc9UvIid09FnrhX3abWspdV0CIl2XXVnlXt tdz/ShlOzLg10elSoOmtfz6S86f+kVXUXZetpMRSnJFoqMVcVJwIAIzI4ujxAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xgO7/12siDK73sVncWneO1aL33Ekm i+1HnrFavF/Ww2hx/ctzVov5R4ASV76+Z7N4v7yLzWLS/QksFm/ermGyuPGrjdWi//FrZovz 5zewW2x6fI3V4vKuOWwWM87vY7JYev0ik0Xr3iPsFj93zWOxePnxBIuDiMeaeWsYPXbOusvu sWlVJ5vH9m8PWD3udx9n8ti8pN5jSz9QvG/LKkaPz5vkAjij3GwyUhNTUosUUvOS81My89Jt lUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X4JbReVGnoFWhYu3XXuYG xq8SXYycHBICJhJnt61nhLDFJC7cW8/WxcjFISSwlFGiZf1qdgjnPqPEiUczWUCqhAW8JaZM eAFWJSKwllFi45LLbCAJIYEpjBK/rnqA2MwC75gkek9JgdhsAroSX3uuM3UxcnDwCthJvPxh ARJmEVCV6P99hhXEFhWIkJj/dBUTiM0rICjxY/I9sF2cAvYS63ddYYQYaSux4P06FghbXmLz mrfMExgFZiFpmYWkbBaSsgWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxglPBM6kd jAd3uR9iFOBgVOLhfeC+JkKINbGsuDL3EKMEB7OSCO+knUAh3pTEyqrUovz4otKc1OJDjKZA j0xklhJNzgemqbySeEMTcxNzYwMLc0tLEyMlcd7G2c/ChQTSE0tSs1NTC1KLYPqYODilGhg3 Lm/2/B+hWFQ1J17U+fCb88EyBy+fPP4hU101N6KhceEOzYXMrn3B0sKTni89vPxOf9Z/6fr5 US/u5jvmtDjNd9LgjtuScpSh2O5N/MKEHaeerzNxazX82DnHZseNrs/LmwUPFr7XWDV5eua0 cPZtziXyq+JnVHm+XCkYe1lr05Fi/qy0I1eVWIozEg21mIuKEwGyhKtMGwMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170222014015epcas1p188f9a683bd70ce267f02a077f3d80a12 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzMo7IKs7JuQKS/sgqzsm5A=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTMy9Bc3Npc3RhbnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170220071000epcas1p38e002e5064bdf4c3b1b4886207dcaaf4 X-RootMTR: 20170220071000epcas1p38e002e5064bdf4c3b1b4886207dcaaf4 References: <50768133-aabc-6050-c9b2-8898bb8046a6@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, This patchset is resent patchset. Because I have a missing TO, CC, I sent it again. Sorry, I will send it in the correct format next time. Best Regards, Hoegeun On 02/22/2017 10:09 AM, Hoegeun Kwon wrote: > Dear Thierry, > > I understand that your opinion is: > It is better to handle the error every time it is input to the > register, rather than error handling at once in the struct using > error. This not only makes the code easier to maintain, but also > reduces unnecessary computation. > > So I modified the panel driver to code-by-code error handling. > If this is not your opinion, could you tell me what your opinion? > > Best Regards, > Hoegeun > > > Changes for V10: > - Fixed code-by-code error handling. > > Changes for V9: > - Fixed the te-gpio to optional in bindings > > Changes for V8: > - Applied below two patches: (drm/exynos) > : drm/exynos: mic: Add mode_set callback function > : drm/exynos: mic: Fix parse_dt function > - The dt-binding patch and driver patch were divided. > - Rebase these patches on samsung SoC tree[1] and tm2 touckey patch[2]. > > Change for V7: > - Fixed the mode_set callback function of mic device driver. > because the mic register is initialized when entering suspend > mode, so should set the reg value whenever pre_enable is > called. > > Changes for V6: > - Fixed the parse_dt function of dsi device driver. > - Removed OF graph of panel in DT and DT binding document. > - Fixed the s6e3ha2 panel device driver. > - Fixed from number size to ARRAY_SIZE(). > - Fixed error handling in mipi_dsi_dcs_* functions. > - Fixed the clock of display_mode. > - Removed unnecessary casting and error log. > > Change for V5: > - The V5 has only one fix in V4 below. > - Removed the enable check of the mic driver in mode_set > callback, because mode_set should be performed every time. > > Changes for V4: > - Removed display-timings in devicetree, the display-timings has > been fixed to be provided by the device driver. > - Added the mode_set callback function into exynos_drm_mic, > because the exynos_drm_mic driver can not parse a videomode > struct by removing the display-timings from the devicetree. > > Changes for V3: > - In the DT binding document, made it clearly that the panel is a > child node of dsi. > - Fix reset-gpio active from high to low. > - Is the OF graph saying related to patch2? > Althogh the panel is a child of dsi, I think OF graph necessary. > because if a remote-endpoint is not specified, the dsi also > panel is not probed. > - The display-timings has been fixed to be provided by the device > driver. however, I think display-timings is necessary in dts. > because if dts does not have display-timings, dsi will not load. > > Changes for V2: > - Fixed the samsung,s6e3ha2.txt DT document. > - Added active high or low after the description of the GPIOs. > - Removed the reg and added a description of the virtual > channel number of a DSI peripheral. > > Depends on: > [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/ > (for-next branch) > [2] https://patchwork.kernel.org/patch/9504131/ > - ("arm64: dts: exynos: Add tm2 touchkey node") > > Hoegeun Kwon (2): > dt-bindings: Add support for samsung s6e3ha2 panel binding > drm/panel: Add support for S6E3HA2 panel driver on TM2 board > > Hyungwon Hwang (1): > arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board > > .../bindings/display/panel/samsung,s6e3ha2.txt | 28 + > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 + > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 739 > +++++++++++++++++++++ > 5 files changed, 786 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hoegeun Kwon Subject: Re: [PATCH v10 0/3] Add support for the S6E3HA2 panel on TM2 board Date: Wed, 22 Feb 2017 10:40:14 +0900 Message-ID: References: <50768133-aabc-6050-c9b2-8898bb8046a6@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <50768133-aabc-6050-c9b2-8898bb8046a6-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Andi Shyti , Hoegeun Kwon List-Id: devicetree@vger.kernel.org Hi all, This patchset is resent patchset. Because I have a missing TO, CC, I sent it again. Sorry, I will send it in the correct format next time. Best Regards, Hoegeun On 02/22/2017 10:09 AM, Hoegeun Kwon wrote: > Dear Thierry, > > I understand that your opinion is: > It is better to handle the error every time it is input to the > register, rather than error handling at once in the struct using > error. This not only makes the code easier to maintain, but also > reduces unnecessary computation. > > So I modified the panel driver to code-by-code error handling. > If this is not your opinion, could you tell me what your opinion? > > Best Regards, > Hoegeun > > > Changes for V10: > - Fixed code-by-code error handling. > > Changes for V9: > - Fixed the te-gpio to optional in bindings > > Changes for V8: > - Applied below two patches: (drm/exynos) > : drm/exynos: mic: Add mode_set callback function > : drm/exynos: mic: Fix parse_dt function > - The dt-binding patch and driver patch were divided. > - Rebase these patches on samsung SoC tree[1] and tm2 touckey patch[2]. > > Change for V7: > - Fixed the mode_set callback function of mic device driver. > because the mic register is initialized when entering suspend > mode, so should set the reg value whenever pre_enable is > called. > > Changes for V6: > - Fixed the parse_dt function of dsi device driver. > - Removed OF graph of panel in DT and DT binding document. > - Fixed the s6e3ha2 panel device driver. > - Fixed from number size to ARRAY_SIZE(). > - Fixed error handling in mipi_dsi_dcs_* functions. > - Fixed the clock of display_mode. > - Removed unnecessary casting and error log. > > Change for V5: > - The V5 has only one fix in V4 below. > - Removed the enable check of the mic driver in mode_set > callback, because mode_set should be performed every time. > > Changes for V4: > - Removed display-timings in devicetree, the display-timings has > been fixed to be provided by the device driver. > - Added the mode_set callback function into exynos_drm_mic, > because the exynos_drm_mic driver can not parse a videomode > struct by removing the display-timings from the devicetree. > > Changes for V3: > - In the DT binding document, made it clearly that the panel is a > child node of dsi. > - Fix reset-gpio active from high to low. > - Is the OF graph saying related to patch2? > Althogh the panel is a child of dsi, I think OF graph necessary. > because if a remote-endpoint is not specified, the dsi also > panel is not probed. > - The display-timings has been fixed to be provided by the device > driver. however, I think display-timings is necessary in dts. > because if dts does not have display-timings, dsi will not load. > > Changes for V2: > - Fixed the samsung,s6e3ha2.txt DT document. > - Added active high or low after the description of the GPIOs. > - Removed the reg and added a description of the virtual > channel number of a DSI peripheral. > > Depends on: > [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/ > (for-next branch) > [2] https://patchwork.kernel.org/patch/9504131/ > - ("arm64: dts: exynos: Add tm2 touchkey node") > > Hoegeun Kwon (2): > dt-bindings: Add support for samsung s6e3ha2 panel binding > drm/panel: Add support for S6E3HA2 panel driver on TM2 board > > Hyungwon Hwang (1): > arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board > > .../bindings/display/panel/samsung,s6e3ha2.txt | 28 + > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 + > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 739 > +++++++++++++++++++++ > 5 files changed, 786 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hoegeun.kwon@samsung.com (Hoegeun Kwon) Date: Wed, 22 Feb 2017 10:40:14 +0900 Subject: [PATCH v10 0/3] Add support for the S6E3HA2 panel on TM2 board In-Reply-To: <50768133-aabc-6050-c9b2-8898bb8046a6@samsung.com> References: <50768133-aabc-6050-c9b2-8898bb8046a6@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi all, This patchset is resent patchset. Because I have a missing TO, CC, I sent it again. Sorry, I will send it in the correct format next time. Best Regards, Hoegeun On 02/22/2017 10:09 AM, Hoegeun Kwon wrote: > Dear Thierry, > > I understand that your opinion is: > It is better to handle the error every time it is input to the > register, rather than error handling at once in the struct using > error. This not only makes the code easier to maintain, but also > reduces unnecessary computation. > > So I modified the panel driver to code-by-code error handling. > If this is not your opinion, could you tell me what your opinion? > > Best Regards, > Hoegeun > > > Changes for V10: > - Fixed code-by-code error handling. > > Changes for V9: > - Fixed the te-gpio to optional in bindings > > Changes for V8: > - Applied below two patches: (drm/exynos) > : drm/exynos: mic: Add mode_set callback function > : drm/exynos: mic: Fix parse_dt function > - The dt-binding patch and driver patch were divided. > - Rebase these patches on samsung SoC tree[1] and tm2 touckey patch[2]. > > Change for V7: > - Fixed the mode_set callback function of mic device driver. > because the mic register is initialized when entering suspend > mode, so should set the reg value whenever pre_enable is > called. > > Changes for V6: > - Fixed the parse_dt function of dsi device driver. > - Removed OF graph of panel in DT and DT binding document. > - Fixed the s6e3ha2 panel device driver. > - Fixed from number size to ARRAY_SIZE(). > - Fixed error handling in mipi_dsi_dcs_* functions. > - Fixed the clock of display_mode. > - Removed unnecessary casting and error log. > > Change for V5: > - The V5 has only one fix in V4 below. > - Removed the enable check of the mic driver in mode_set > callback, because mode_set should be performed every time. > > Changes for V4: > - Removed display-timings in devicetree, the display-timings has > been fixed to be provided by the device driver. > - Added the mode_set callback function into exynos_drm_mic, > because the exynos_drm_mic driver can not parse a videomode > struct by removing the display-timings from the devicetree. > > Changes for V3: > - In the DT binding document, made it clearly that the panel is a > child node of dsi. > - Fix reset-gpio active from high to low. > - Is the OF graph saying related to patch2? > Althogh the panel is a child of dsi, I think OF graph necessary. > because if a remote-endpoint is not specified, the dsi also > panel is not probed. > - The display-timings has been fixed to be provided by the device > driver. however, I think display-timings is necessary in dts. > because if dts does not have display-timings, dsi will not load. > > Changes for V2: > - Fixed the samsung,s6e3ha2.txt DT document. > - Added active high or low after the description of the GPIOs. > - Removed the reg and added a description of the virtual > channel number of a DSI peripheral. > > Depends on: > [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/ > (for-next branch) > [2] https://patchwork.kernel.org/patch/9504131/ > - ("arm64: dts: exynos: Add tm2 touchkey node") > > Hoegeun Kwon (2): > dt-bindings: Add support for samsung s6e3ha2 panel binding > drm/panel: Add support for S6E3HA2 panel driver on TM2 board > > Hyungwon Hwang (1): > arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board > > .../bindings/display/panel/samsung,s6e3ha2.txt | 28 + > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 + > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 739 > +++++++++++++++++++++ > 5 files changed, 786 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c >