From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82895C77B7A for ; Wed, 17 May 2023 07:43:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2AF8786205; Wed, 17 May 2023 09:43:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=mysnt.onmicrosoft.com header.i=@mysnt.onmicrosoft.com header.b="WJB78Mzi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D60108667D; Wed, 17 May 2023 09:43:51 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070a.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::70a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EF127861F1 for ; Wed, 17 May 2023 09:43:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frieder.schrempf@kontron.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBlbFN7guTWOjorYmy7+nB8seUwj13QYDK88TpMmf593dZl2T0bvSWzzPtlcbSl3TF58gZrij4Kj6f8YyNajvY/XKU8rawL7E9ZUBusWCQOKksD3/a6ZozEzasIKf0uY9j37VlcARvqVgrWobC8Wz7qyAIZvisaPM7a+zRy007xjEuE3oux1EzI109i/DHEOwlo4WmRYZ+Z876guXIGNiiAxcWbP6G6d8EST9zbxL+Bj0zbOq+3cnar5ilmFDdN0th9xqPzso2sKxU5kPByQtV/q4inSFaRARUK/VbqOvFHxRY4F4TF7xEtZzaCCPlV9OPhxtoHZkVHgyN87nYDIMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pjSMB/vMkIkl1cIsYIwSyim6VvbAU0wQePFE1BYxeKs=; b=j0zKIJTHPx85ycH/1HVuGtKnU3g7I9akVVC3cbY0sI3z6K+06RlB6oadLKGnfB7ioio64gs0tXKhuoVqRJSR+OPsB/hC5+BqhwKpNGwpVUZd64J/x3W6JeJ/1VLrkMGJBSj/9oJULz782BmK9zkAGtozTPCZzprzizcpx/MV9y3C6PctA7Uv3iH1qaHa6rM78wflhxrvCleLIhRWvnVR1C/1Ip9jRtabktakbjhrKmYUUwQrDXForuA/KiFNRbXmbp05UiA7OAyx7WRpH0StNYHcuLGKRW8AKdpdJ3oMv4FCN2YfcVtfaPWLAEeM705NMbz76Lw87P1M+5eIjmvu+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjSMB/vMkIkl1cIsYIwSyim6VvbAU0wQePFE1BYxeKs=; b=WJB78MzidN628fMUhmjJtNVa5NQtptlH+7ymb3nutMDFIFJsquIyFqal5DgXtTEvYB9arCrLbALSAz04QA/BFnORd9zu9SL2p2yIqoMCJDFtllHalsWBNYltRtXlPhSLWQHUvdUuT+YfkGUMkwTA9H9k5/HJ7w3H6Xen3CwWkqk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kontron.de; Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) by PAXPR10MB5351.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:282::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.34; Wed, 17 May 2023 07:43:47 +0000 Received: from PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::280c:cfeb:c9df:35d6]) by PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM ([fe80::280c:cfeb:c9df:35d6%3]) with mapi id 15.20.6387.032; Wed, 17 May 2023 07:43:47 +0000 Message-ID: Date: Wed, 17 May 2023 09:43:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation Content-Language: en-US, de-DE To: Michael Nazzareno Trimarchi , Dario Binacchi , Tom Rini Cc: Frieder Schrempf , U-Boot-Denx , Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese References: <20230110115843.391630-1-frieder@fris.de> <9d83d7ae-a69c-1584-fabf-c2dd0e1d1b67@kontron.de> <20230515211227.GP2398826@bill-the-cat> From: Frieder Schrempf In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-ClientProxiedBy: BE1P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:26::7) To PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:263::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5681:EE_|PAXPR10MB5351:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a48cfe6-98ab-46a3-40b2-08db56aa72a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k3aZnKprPh+9Weo4MRYjo6jdGWevsKIC7OCHQZI5h51hqyEvUVfNdCwkwtZRjhCu2g4zasj7mhg8PSPwi4HsSG7VpY/xh3sNthAO1RXJqnvPDB+BjGzh09aEF2lQ2j2CT2VVDEgTxcrpN4+BIaXdNyCBu6kBU7Qa2yIFYAoba0Xv9yyxO8K1no6sT0WBIF9yk/H3dJjqWznMb9yXZTl39PGXI9eOHInvoFcDpMJMVvXJ3tPUJrxBIuOT2vPrhXIBcghC2BpP+kQyUIbxBR0ohPYkzqWPYX767sXI/IqhMP8NrAtvqzZv9vMkLgNcDNUzGvQWJV93re7AAOL7z/o4MZIXAw4a5uJ2V60vDSVCOlfpyx2xI3xHpynAuyVZQM4ZVDSkhJsFfSEL5FIz97qJFEQG7/GKhqekxa7rh+PcoChayvPWfwmTzJfRlqFJUSoNkQJpifRbct8MMYFrXx2liyTwooDZIgCUnXFZpj85rEC6V9O1FhQ0ybVOT9eceuzT7p/R1MBbQtIomT0L6jz9GMJBOcrr6Sy2+NLRqyI3WUfvRDChCYZmfVft9uekmpXVAvO5G/wRrNL/QYgIoCVzdPHd0OH2FNq+RJ8ReqnFqu1p1YQ6kDsN4V5L5FBpMaLDjtH5t8zilOwb6Vu2j2e2Jg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199021)(66556008)(66476007)(66946007)(2906002)(41300700001)(316002)(7416002)(44832011)(4326008)(31686004)(8676002)(8936002)(478600001)(110136005)(54906003)(45080400002)(5660300002)(6666004)(53546011)(6512007)(6506007)(26005)(6486002)(186003)(83380400001)(36756003)(86362001)(2616005)(31696002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW1jL0VFOTJ6cnhEdldCRzd3alNsUGZZNmswVndoYVBDVG12cFV5V2d0V0hG?= =?utf-8?B?VWtONUc3cnlrVThqa3E4OUNHRkR3REtoWlBFNGQxdExUc0hlWTVHMVhwMnBY?= =?utf-8?B?L2thaFhhYmRUdXgrdjVCeU9JUXpMaGdKZnpaaStHTWpUYkZlQVVwMWV4UThr?= =?utf-8?B?ZDkwYlJjNWV3bVVkM0Jjd1V1WHIwM1g3UEFBZ01Na3JCU3VmT3Z5VFNRVDlr?= =?utf-8?B?VDNyZVRkN1BHbkFsQ1RBaFJodCtMMnZlNFluRWZKQlNmRzVWNEFYQ1MvM3Jk?= =?utf-8?B?Zi83UURhYlR2NWVnbjVXdkk5TEc2dGUxaHYxV2JqQzB6U3VKOGE0cm1VeTBj?= =?utf-8?B?MU1wTDBhYXpieVRZNzduUThBMzFkZUs4ZmwyNmtZYkN6dTFZUDRNOTExUTBF?= =?utf-8?B?aXdoanFGL1dVWWZER1BucDhXeVNnYTJLYlFUMkJCT0RMQURuRTg1SElaaTRT?= =?utf-8?B?cWdDMXhyVGNkMC9TQmxCMnlJeFFYOFpJaGtBR2F0N1B2V1NYZ1lPNkJYK0hv?= =?utf-8?B?VG9rb2cvamhOMmM3Z2pYaEtYQnFBVWJkQjU4UEdHVWQ2VkEySjFQQWlFVVlw?= =?utf-8?B?cjd3M2hadTFQZkYyN3hxQ3g1ejFyVnQ0WFR0aFFyUmtscVlZaXc2OUVyTnd2?= =?utf-8?B?d21sVlk0NWhUcnBJY2tIU1IrS2l0U1YyNTkwQ2FWN0xNZGMycm9IMmxkNmph?= =?utf-8?B?dk55eENndHEyUTFLd0k0ZkU2Z25IRy9uWHpVWGR3RGhGL3VTamhMNEdxVWc3?= =?utf-8?B?S21uU04xb1FUUTJ5TTVvNjVQeG5RakEvd3luZUJSUzBMVGR5NjNpc09wOHhK?= =?utf-8?B?d0hyZEFtTTA1REdqeUgxU0RUY0EvNHB4ZnhtMEJZeHJwTHRKQUNnZ09MS0ox?= =?utf-8?B?eHJqV0JvVmo5blhuL1VaM3VwRVE3R1UzMGZId016NW43VjRoOFNld3Q0Nm1E?= =?utf-8?B?WnNpeDJpcHdmU2JWUHphWGMyZ1lickRUNitGTmZFL09jZHBrNFB5VGswcVJ1?= =?utf-8?B?OHBkeUFUcE5yOXg1RXd2MEtDWitHdUlNUEpjNGI2OXNGRURDTERJWGw3WjYy?= =?utf-8?B?SU42dDcweGNoc0N6OGI5SHFPRUZhc3c4MzJKYzNWY1BoRWxEdURlWXVWTzFS?= =?utf-8?B?d2tXOW1sdnh6VWlFY2Zkb0YvdGU2aGJHZlFYZmhxNXR4MHhXQzIvK3JnYitV?= =?utf-8?B?VW1uWG1UdFQzVDVQL2pUUXoyTFFMcXBYSElmajh5cnN5dTJLRms5aG9YWVo5?= =?utf-8?B?Vmx6VW9ZbkU2VlFVbDIzMHI2YXg2cFM3cTN0Z0xFM0hjWXRObVU2d01sbGRr?= =?utf-8?B?ellMWGJ2bzd5amtzZlZmOUhkZGhvY3R1M3BtaFd3SllueWFIR1J0SVdrRUVV?= =?utf-8?B?VnU1NWlqTVowQ2QxWjNMbXZDN3lYZG1hTkdsNjQvcjY0OHkyWjFINWROQ3dE?= =?utf-8?B?dTFhQ2hLQStubTRob2tQRWhqS25CVGdYQ2RqRWhEYm9Zbm9RUFpZQ0lVV3Vs?= =?utf-8?B?dmZVWml4V0tMOWd0Y3VqRXBQRHd2ei9KSDdrUjhrZ2pkRVpJcytVTU94OVFr?= =?utf-8?B?cmM3RGJiUmVabFpyNHJLbE5hanJWeU1FQU0vVm96UXNaZVZSL2Z2WFJwdlFG?= =?utf-8?B?bmdRYy9PMWtJL2hoZWkrR2M2QitHZlFQb2c3YXoyV2RRTm9DK0xLeUZxbFlV?= =?utf-8?B?ZlZKeGtHUnNaWFRiYWd6eUtYcE5FNE8wTWRtVkFORkhwTG54TFIxcVlyQWdR?= =?utf-8?B?Znh0N3dWM2dDM0J4TU9peEZKVlpYcjFOaDU5V1I0Z3RZL1VYK1RtUzRpK3NN?= =?utf-8?B?NXdxQlJzaWZXSlo4L3lVQmkvb2l5NERKc1RaTzZsM3g4WXZuRzhEaGtMbmcr?= =?utf-8?B?SW8wWnpZblgyWEswUG9raGljdkVaOEdJUEJHOHM4ZXMzQTZrQnB3MGFCK1dl?= =?utf-8?B?MDc3dllxSTZrZGo4WWdQa1dOWkdQZStUcFQ1NEFOSTVIaC9uVGIwRDJUVzRV?= =?utf-8?B?bFdLU2M2SS85ZVlUWXoxOGdHMHFubjJsc3VIUDVBOW1WN0dpNlNYd1FCVTd3?= =?utf-8?B?MFJoMlhOdkttZGU0MXZtcFNNSkRVN0dSTDNBbWUzREZNQkRWNm1KNjdyaHZB?= =?utf-8?B?RWduMnlDaWgvbHlQNzZ6d3Q2Zm8rK3NzYjltK3J1ZnNYMitMSDhGNEE0ZEJy?= =?utf-8?B?RFE9PQ==?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: 1a48cfe6-98ab-46a3-40b2-08db56aa72a5 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 07:43:47.3705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eA3pxTrTUh8ey80iuEkS4Cp6upIuG6nd3K86Hsd+Vk7nh/+UAZpTpsINVhxe1JSnC15k+aO5RtnIZkI8PIY7iN+kt9saDdNDIMvWmURFVEY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5351 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Michael, hi Dario, On 15.05.23 23:33, Michael Nazzareno Trimarchi wrote: > Hi > > Il lun 15 mag 2023, 23:12 Tom Rini > ha scritto: > > On Tue, May 09, 2023 at 09:09:28AM +0200, Frieder Schrempf wrote: > > Hi Michael, hi Dario, > > > > On 18.04.23 15:46, Frieder Schrempf wrote: > > > Hi Michael, Dario, > > > > > > On 28.03.23 09:57, Frieder Schrempf wrote: > > >> Hi Michael, > > >> > > >> On 10.02.23 12:57, Michael Nazzareno Trimarchi wrote: > > >>> Hi > > >>> > > >>> I will review > > >>> > > >>> On Thu, Feb 9, 2023 at 5:52 PM Tom Rini > wrote: > > >>>> > > >>>> On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > > >>>>> Hi, > > >>>>> > > >>>>> On 10.01.23 12:58, Frieder Schrempf wrote: > > >>>>>> From: Mikhail Kshevetskiy > > > >>>>>> > > >>>>>> Currently there are 3 different variants of read_id > implementation: > > >>>>>> 1. opcode only. Found in GD5FxGQ4xF. > > >>>>>> 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > > >>>>>> 3. opcode + 1 dummy byte. Found in other currently > supported chips. > > >>>>>> > > >>>>>> Original implementation was for variant 1 and let detect > function > > >>>>>> of chips with variant 2 and 3 to ignore the first byte. > This isn't > > >>>>>> robust: > > >>>>>> > > >>>>>> 1. For chips of variant 2, if SPI master doesn't keep MOSI low > > >>>>>> during read, chip will get a random id offset, and the > entire id > > >>>>>> buffer will shift by that offset, causing detect failure. > > >>>>>> > > >>>>>> 2. For chips of variant 1, if it happens to get a devid > that equals > > >>>>>> to manufacture id of variant 2 or 3 chips, it'll get > incorrectly > > >>>>>> detected. > > >>>>>> > > >>>>>> This patch reworks detect procedure to address problems > above. New > > >>>>>> logic do detection for all variants separatedly, in 1-2-3 > order. > > >>>>>> Since all current detect methods do exactly the same id > matching > > >>>>>> procedure, unify them into core.c and remove detect method from > > >>>>>> manufacture_ops. > > >>>>>> > > >>>>>> This is a rework of Chuanhong Guo > patch > > >>>>>> submitted to linux kernel > > >>>>>> > > >>>>>> Signed-off-by: Mikhail Kshevetskiy > > > > >>>>>> Signed-off-by: Frieder Schrempf > > > > >>>>> > > >>>>> +Cc: Jagan, Tom > > >>>>> > > >>>>> Who is supposed to pick up these patches? Some of them have > been around > > >>>>> for some months (before I resent them). > > >>>>> > > >>>>> There is no maintainer for drivers/mtd/spinand/ and no > maintainer for > > >>>>> drivers/mtd/ in general. > > >>>>> > > >>>>> In Patchwork Jagan got assigned, but the get_maintainer.pl > script didn't > > >>>>> even add him to Cc, of course. > > >>>>> > > >>>>> Any ideas how to proceed? > > >>>> > > >>>> We don't have anyone dedicated to that area, yes, sadly. I've > added > > >>>> Michael and Dario as they've also been doing mtd-but-not-spi > work of > > >>>> late to see if they're interested. Or since you've long been > working > > >>>> here, would you like to more formally maintain the area? Thanks! > > >>> > > >>> They can come from our tree. I will try to sort out all my > duties weeked > > >> > > >> Any news regarding reviewing/picking these patches? > > > > > > Ping! > > > > > > Can you please apply these patches, that have been waiting for > so long? > > > > I still can't see this applied anywhere. You already told me to take > > care of it multiple times. Can you please get it done? > > Yes, I'd really like to see a PR at least vs -next at this point so > things aren't lost, thanks! > > > I think that we pick already it so it will happen. I can see patch 1/5 of this series in the nand-next tree. What about the other four patches of this series? Please pick them up, too! Thanks Frieder