From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02D3C2D0F8 for ; Wed, 13 May 2020 06:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5B6A2492C for ; Wed, 13 May 2020 06:06:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A65PPSpX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729361AbgEMF5p (ORCPT ); Wed, 13 May 2020 01:57:45 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47510 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729179AbgEMF5e (ORCPT ); Wed, 13 May 2020 01:57:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589349453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oS9s06FImqWmW3Ha3Sx3lNv173yHCer4HwNEWY7z8Lw=; b=A65PPSpXo6wkymPTMbSzVCOjkTAScE3Kn/2REO4bEmbMLEGQrDgTJve5g8wavyIAveswuH 1W04B/NDyavO76cPeGkzmnJf/AWb3HyEDK78eW/z/N34fmx5W0SIcSLyXp3CFaRjtY25F/ bQgmj3tybBafmhCypbMAxxJrzjxhQYc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-pMwZ543xOua3WL8Aq33VRw-1; Wed, 13 May 2020 01:57:29 -0400 X-MC-Unique: pMwZ543xOua3WL8Aq33VRw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90DC21841931; Wed, 13 May 2020 05:57:28 +0000 (UTC) Received: from [10.72.13.188] (ovpn-13-188.pek2.redhat.com [10.72.13.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id E36F05D9E8; Wed, 13 May 2020 05:57:20 +0000 (UTC) Subject: Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers To: "Zhu, Lingshan" , mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: lulu@redhat.com, dan.daly@intel.com, cunming.liang@intel.com References: <1589270444-3669-1-git-send-email-lingshan.zhu@intel.com> <8aca85c3-3bf6-a1ec-7009-cd9a635647d7@redhat.com> <5bbe0c21-8638-45e4-04e8-02ad0df44b38@intel.com> From: Jason Wang Message-ID: Date: Wed, 13 May 2020 13:57:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5bbe0c21-8638-45e4-04e8-02ad0df44b38@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/13 下午12:42, Zhu, Lingshan wrote: > > > On 5/13/2020 12:12 PM, Jason Wang wrote: >> >> On 2020/5/12 下午4:00, Zhu Lingshan wrote: >>> This commit move IRQ request and free operations from probe() >>> to VIRTIO status change handler to comply with VIRTIO spec. >>> >>> VIRTIO spec 1.1, section 2.1.2 Device Requirements: Device Status Field >>> The device MUST NOT consume buffers or send any used buffer >>> notifications to the driver before DRIVER_OK. >> >> >> This comment needs to be checked as I said previously. It's only >> needed if we're sure ifcvf can generate interrupt before DRIVER_OK. >> >> >>> >>> Signed-off-by: Zhu Lingshan >>> --- >>> changes from V1: >>> remove ifcvf_stop_datapath() in status == 0 handler, we don't need >>> to do this >>> twice; handle status == 0 after DRIVER_OK -> !DRIVER_OK handler >>> (Jason Wang) >> >> >> Patch looks good to me, but with this patch ping cannot work on my >> machine. (It works without this patch). >> >> Thanks > This is strange, it works on my machines, let's have a check offline. > > Thanks, > BR > Zhu Lingshan Note that I tested the patch with vhost-vpda. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH V2] ifcvf: move IRQ request/free to status change handlers Date: Wed, 13 May 2020 13:57:19 +0800 Message-ID: References: <1589270444-3669-1-git-send-email-lingshan.zhu@intel.com> <8aca85c3-3bf6-a1ec-7009-cd9a635647d7@redhat.com> <5bbe0c21-8638-45e4-04e8-02ad0df44b38@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5bbe0c21-8638-45e4-04e8-02ad0df44b38@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: "Zhu, Lingshan" , mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: lulu@redhat.com List-Id: virtualization@lists.linuxfoundation.org Ck9uIDIwMjAvNS8xMyDkuIvljYgxMjo0MiwgWmh1LCBMaW5nc2hhbiB3cm90ZToKPgo+Cj4gT24g NS8xMy8yMDIwIDEyOjEyIFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pgo+PiBPbiAyMDIwLzUvMTIg 5LiL5Y2INDowMCwgWmh1IExpbmdzaGFuIHdyb3RlOgo+Pj4gVGhpcyBjb21taXQgbW92ZSBJUlEg cmVxdWVzdCBhbmQgZnJlZSBvcGVyYXRpb25zIGZyb20gcHJvYmUoKQo+Pj4gdG8gVklSVElPIHN0 YXR1cyBjaGFuZ2UgaGFuZGxlciB0byBjb21wbHkgd2l0aCBWSVJUSU8gc3BlYy4KPj4+Cj4+PiBW SVJUSU8gc3BlYyAxLjEsIHNlY3Rpb24gMi4xLjIgRGV2aWNlIFJlcXVpcmVtZW50czogRGV2aWNl IFN0YXR1cyBGaWVsZAo+Pj4gVGhlIGRldmljZSBNVVNUIE5PVCBjb25zdW1lIGJ1ZmZlcnMgb3Ig c2VuZCBhbnkgdXNlZCBidWZmZXIKPj4+IG5vdGlmaWNhdGlvbnMgdG8gdGhlIGRyaXZlciBiZWZv cmUgRFJJVkVSX09LLgo+Pgo+Pgo+PiBUaGlzIGNvbW1lbnQgbmVlZHMgdG8gYmUgY2hlY2tlZCBh cyBJIHNhaWQgcHJldmlvdXNseS4gSXQncyBvbmx5IAo+PiBuZWVkZWQgaWYgd2UncmUgc3VyZSBp ZmN2ZiBjYW4gZ2VuZXJhdGUgaW50ZXJydXB0IGJlZm9yZSBEUklWRVJfT0suCj4+Cj4+Cj4+Pgo+ Pj4gU2lnbmVkLW9mZi1ieTogWmh1IExpbmdzaGFuIDxsaW5nc2hhbi56aHVAaW50ZWwuY29tPgo+ Pj4gLS0tCj4+PiBjaGFuZ2VzIGZyb20gVjE6Cj4+PiByZW1vdmUgaWZjdmZfc3RvcF9kYXRhcGF0 aCgpIGluIHN0YXR1cyA9PSAwIGhhbmRsZXIsIHdlIGRvbid0IG5lZWQgCj4+PiB0byBkbyB0aGlz Cj4+PiB0d2ljZTsgaGFuZGxlIHN0YXR1cyA9PSAwIGFmdGVyIERSSVZFUl9PSyAtPiAhRFJJVkVS X09LIGhhbmRsZXIgCj4+PiAoSmFzb24gV2FuZykKPj4KPj4KPj4gUGF0Y2ggbG9va3MgZ29vZCB0 byBtZSwgYnV0IHdpdGggdGhpcyBwYXRjaCBwaW5nIGNhbm5vdCB3b3JrIG9uIG15IAo+PiBtYWNo aW5lLiAoSXQgd29ya3Mgd2l0aG91dCB0aGlzIHBhdGNoKS4KPj4KPj4gVGhhbmtzCj4gVGhpcyBp cyBzdHJhbmdlLCBpdCB3b3JrcyBvbiBteSBtYWNoaW5lcywgbGV0J3MgaGF2ZSBhIGNoZWNrIG9m ZmxpbmUuCj4KPiBUaGFua3MsCj4gQlIKPiBaaHUgTGluZ3NoYW4KCgpOb3RlIHRoYXQgSSB0ZXN0 ZWQgdGhlIHBhdGNoIHdpdGggdmhvc3QtdnBkYS4KClRoYW5rcy4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlz dApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3Rz LmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==