From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] ARM: socfpga: Add support for selecting bridges in bridge command
Date: Mon, 22 Apr 2019 20:22:02 +0200 [thread overview]
Message-ID: <f766362b-3218-805b-7aef-5c97ab17c655@gmail.com> (raw)
In-Reply-To: <464350db-d3ec-0d4b-cfea-b6f0595291e1@denx.de>
Am 22.04.2019 um 20:01 schrieb Marek Vasut:
> On 4/19/19 10:00 PM, Simon Goldschmidt wrote:
>>
>>
>> On 17.04.19 22:15, Marek Vasut wrote:
>>> Add optional "mask" argument to the SoCFPGA bridge command, to select
>>> which bridges should be enabled/disabled. This allows the user to avoid
>>> enabling bridges which are not connected into the FPGA fabric. Default
>>> behavior is to enable/disable all bridges.
>>
>> So does this change the command? Seems like leaving away the new 'mask'
>> argument would now lead to enabling all bridges by overwriting whatever
>> the handoff values were before?
>
> That's how it behaved before though -- all the bridges were enabled.
> Now it's possible to explicitly select which bridges to enable/disable.
As I read the code, before it wrote iswgrp_handoff[x] to the registers.
The question is what is iswgrp_handoff[x]. It's not the bridges status
from Quartus (as the "handoff" suffix might suggest). Instead (if I
remember correctly), it's either "all bridges" or "no bridges",
depending on the FPGA configuration status at SPL runtime.
In this case, we're probably better off with leaving it to the command
line scripts to say which bridges shall be enabled...
Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
next prev parent reply other threads:[~2019-04-22 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 20:15 [U-Boot] [PATCH 1/4] ARM: socfpga: Factor out handoff register configuration Marek Vasut
2019-04-17 20:15 ` [U-Boot] [PATCH 2/4] ARM: socfpga: Disable bridges in SPL unless booting from FPGA Marek Vasut
2019-04-19 19:53 ` Simon Goldschmidt
2019-04-17 20:15 ` [U-Boot] [PATCH 3/4] ARM: socfpga: Fully unmap the FPGA bridges from L3 space Marek Vasut
2019-04-19 19:54 ` Simon Goldschmidt
2019-04-17 20:15 ` [U-Boot] [PATCH 4/4] ARM: socfpga: Add support for selecting bridges in bridge command Marek Vasut
2019-04-19 20:00 ` Simon Goldschmidt
2019-04-22 18:01 ` Marek Vasut
2019-04-22 18:22 ` Simon Goldschmidt [this message]
2019-04-22 18:41 ` Marek Vasut
2019-04-22 19:18 ` Simon Goldschmidt
2019-04-22 19:24 ` Marek Vasut
2019-04-26 6:36 ` Simon Goldschmidt
2019-04-29 8:35 ` Marek Vasut
2019-04-19 19:47 ` [U-Boot] [PATCH 1/4] ARM: socfpga: Factor out handoff register configuration Simon Goldschmidt
2019-04-22 17:59 ` Marek Vasut
2019-04-22 18:17 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f766362b-3218-805b-7aef-5c97ab17c655@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.