From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF793C3A5A9 for ; Mon, 4 May 2020 23:46:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DD6320663 for ; Mon, 4 May 2020 23:46:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="YznSQji9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728329AbgEDXqY (ORCPT ); Mon, 4 May 2020 19:46:24 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:61369 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgEDXqX (ORCPT ); Mon, 4 May 2020 19:46:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588635983; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=dKZZ/hAPbwDEOiC8H0xBFIIzVsviiHYPlAkqYm2g84Q=; b=YznSQji9N/lWi1u76erOcvrq1sdSRAT4q0Q23eW6QtsgFP3H+M3O/Nj+reFCZsLxOn3wXkH6 fHrDz9TInf8ZfRoW9ji5nDcvbdJvGQ0YDOvedvedORA7BkcCdDIHlByuNgKQB3q68QvezCW3 vl5djc7coamFldtIUZsATHMfoj8= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eb0a944.7f72fd9e7ed8-smtp-out-n03; Mon, 04 May 2020 23:46:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CA5D2C432C2; Mon, 4 May 2020 23:46:12 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rmanohar) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5435AC433CB; Mon, 4 May 2020 23:46:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 May 2020 16:46:12 -0700 From: Rajkumar Manoharan To: Markus Theil Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> Message-ID: X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-04 08:41, Markus Theil wrote: > ath10k currently reports survey results for the last interval between > each > invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this > can lead to unexpectedly small results, e.g. when hostapd uses survey > data and iw survey dump is invoked in parallel. Fix this by returning > cumulative results, that don't depend on the last invocation. Other > drivers, e.g. ath9k or mt76 also use this behavior. > > Signed-off-by: Markus Theil > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. Simple one line change is enough. https://patchwork.kernel.org/patch/10550707/ -Rajkumar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVkmw-0007A0-Rw for ath11k@lists.infradead.org; Mon, 04 May 2020 23:46:23 +0000 MIME-Version: 1.0 Date: Mon, 04 May 2020 16:46:12 -0700 From: Rajkumar Manoharan Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org On 2020-05-04 08:41, Markus Theil wrote: > ath10k currently reports survey results for the last interval between > each > invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this > can lead to unexpectedly small results, e.g. when hostapd uses survey > data and iw survey dump is invoked in parallel. Fix this by returning > cumulative results, that don't depend on the last invocation. Other > drivers, e.g. ath9k or mt76 also use this behavior. > > Signed-off-by: Markus Theil > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. Simple one line change is enough. https://patchwork.kernel.org/patch/10550707/ -Rajkumar _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVkmu-00079l-Fh for ath10k@lists.infradead.org; Mon, 04 May 2020 23:46:21 +0000 MIME-Version: 1.0 Date: Mon, 04 May 2020 16:46:12 -0700 From: Rajkumar Manoharan Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org On 2020-05-04 08:41, Markus Theil wrote: > ath10k currently reports survey results for the last interval between > each > invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this > can lead to unexpectedly small results, e.g. when hostapd uses survey > data and iw survey dump is invoked in parallel. Fix this by returning > cumulative results, that don't depend on the last invocation. Other > drivers, e.g. ath9k or mt76 also use this behavior. > > Signed-off-by: Markus Theil > IIRC this was fixed a while ago by below patch. Somehow it never landed in ath.git. Simple one line change is enough. https://patchwork.kernel.org/patch/10550707/ -Rajkumar _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k