From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EECC4338F for ; Tue, 27 Jul 2021 17:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2CDB60F91 for ; Tue, 27 Jul 2021 17:59:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhG0R7l (ORCPT ); Tue, 27 Jul 2021 13:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhG0R7l (ORCPT ); Tue, 27 Jul 2021 13:59:41 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF17C061760 for ; Tue, 27 Jul 2021 10:59:40 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id m13so23142724lfg.13 for ; Tue, 27 Jul 2021 10:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cqBzCBYK/WCh9fycS4ezNBnEiKw44dAJEHWTfNPIy0U=; b=c+MTlrWFU+6XLsvvTAgmQoRu6JG4hFHL7PCc9CGlg+QHotx0+E9GWWwgE7j2v629ZV 2OGpyO/TeEfOUJHCzL0kQcEeN86a/ONA9L4FHtt26y2263IRBo1GvgOJ6EJWfxpCevdh rKHMQx4jSHfeqcIdr7d5/QxwS1fVEYG1WMlwBj6iJM+Jr2QDaAsul5cH5dTPj/i62boy YBa53QOoyXwE4H8J1yKVkeJuXiGwgGZaGFzmak9jQyk4/N6eHFxOH9gJ6tmWBQw6Dm0t 5Gb0uidqiT0HxX+9+8i5/TbY91qYhcz1IGPdLACy3MhV98+LxUdg1KkZqqMjmKuCZ6wG yNjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cqBzCBYK/WCh9fycS4ezNBnEiKw44dAJEHWTfNPIy0U=; b=LM7sRC5qAe+gWR70kbQpnV9i2xnAVOiCV7vV07UZXuA1QzBK3zaqVmkQE0gReGIE0R Rf5Aa+UFR/TWYBQrMiJ89msuq/D8bxokNMIVQ7qjgeK9FZZzR0CJB4aa3hZSe/5WgWnU FoQV2WlInrF/jkuojB8P7QPp8i+4ckPUBTJwE+Opr+xZT8yF8IuSWWmhpONR8M3vGdy9 XjBw1g/H5ogl1hpbxC9wcjYDqv8RfyAHYhR6GnR5BOZamDGayA8l9BL2c/OrsHuJTLce kyvX/SHI+wo02veB+VHUqWJxvc3QQIdAA8u/MDgP3r25v7rVOuGLzbF/J/lKUwgQQEdR przw== X-Gm-Message-State: AOAM53295dxwL2AvnMa6XAXMrwIvode8cRh7tBmKFGByiMwWcQi793Eq L6K7ByUyeS29yy52TRI/PMvLaZOFZOdZuA== X-Google-Smtp-Source: ABdhPJwukGjgB72jD7seeBnE75lkf5Eai5MBBJGu4pl4BkBTJt7OIQdo8ByoSHNkxtWwh6fZ5ulPNQ== X-Received: by 2002:a19:6d06:: with SMTP id i6mr18682045lfc.295.1627408778751; Tue, 27 Jul 2021 10:59:38 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id r16sm354131lfm.91.2021.07.27.10.59.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 10:59:38 -0700 (PDT) Subject: Re: [PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration To: Sean Paul , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Sean Paul , Rob Clark , linux-arm-msm@vger.kernel.org References: <20210714152910.55093-1-sean@poorly.run> From: Dmitry Baryshkov Message-ID: Date: Tue, 27 Jul 2021 20:59:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210714152910.55093-1-sean@poorly.run> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/07/2021 18:28, Sean Paul wrote: > From: Sean Paul > > Avoids the following WARN: > [ 3.009556] ------------[ cut here ]------------ > [ 3.014306] WARNING: CPU: 7 PID: 109 at > drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac > [ 3.024209] Modules linked in: > [ 3.027351] CPU: 7 PID: 109 Comm: kworker/7:8 Not tainted 5.10.47 #69 > [ 3.033958] Hardware name: Google Lazor (rev1 - 2) (DT) > [ 3.039323] Workqueue: events deferred_probe_work_func > [ 3.044596] pstate: 60c00009 (nZCv daif +PAN +UAO -TCO BTYPE=--) > [ 3.050761] pc : drm_dp_aux_register+0xa4/0xac > [ 3.055329] lr : dp_aux_register+0x40/0x88 > [ 3.059538] sp : ffffffc010ad3920 > [ 3.062948] x29: ffffffc010ad3920 x28: ffffffa64196ac70 > [ 3.067239] mmc1: Command Queue Engine enabled > [ 3.068406] x27: ffffffa64196ac68 x26: 0000000000000001 > [ 3.068407] x25: 0000000000000002 x24: 0000000000000060 > [ 3.068409] x23: ffffffa642ab3400 x22: ffffffe126c10e5b > [ 3.068410] x21: ffffffa641dc3188 x20: ffffffa641963c10 > [ 3.068412] x19: ffffffa642aba910 x18: 00000000ffff0a00 > [ 3.068414] x17: 000000476f8e002a x16: 00000000000000b8 > [ 3.073008] mmc1: new HS400 Enhanced strobe MMC card at address 0001 > [ 3.078448] x15: ffffffffffffffff x14: ffffffffffffffff > [ 3.078450] x13: 0000000000000030 x12: 0000000000000030 > [ 3.078452] x11: 0101010101010101 x10: ffffffe12647a914 > [ 3.078453] x9 : ffffffe12647a8cc x8 : 0000000000000000 > [ 3.084452] mmcblk1: mmc1:0001 DA4032 29.1 GiB > [ 3.089372] > [ 3.089372] x7 : 6c6064717372fefe x6 : ffffffa642b11494 > [ 3.089374] x5 : 0000000000000000 x4 : 6d006c657869ffff > [ 3.089375] x3 : 000000006c657869 x2 : 000000000000000c > [ 3.089376] x1 : ffffffe126c3ae3c x0 : ffffffa642aba910 > [ 3.089381] Call trace: > [ 3.094931] mmcblk1boot0: mmc1:0001 DA4032 partition 1 4.00 MiB > [ 3.100291] drm_dp_aux_register+0xa4/0xac > [ 3.100292] dp_aux_register+0x40/0x88 > [ 3.100294] dp_display_bind+0x64/0xcc > [ 3.100295] component_bind_all+0xdc/0x210 > [ 3.100298] msm_drm_bind+0x1e8/0x5d4 > [ 3.100301] try_to_bring_up_master+0x168/0x1b0 > [ 3.105861] mmcblk1boot1: mmc1:0001 DA4032 partition 2 4.00 MiB > [ 3.112282] __component_add+0xa0/0x158 > [ 3.112283] component_add+0x1c/0x28 > [ 3.112284] dp_display_probe+0x33c/0x380 > [ 3.112286] platform_drv_probe+0x9c/0xbc > [ 3.112287] really_probe+0x140/0x35c > [ 3.112289] driver_probe_device+0x84/0xc0 > [ 3.112292] __device_attach_driver+0x94/0xb0 > [ 3.117967] mmcblk1rpmb: mmc1:0001 DA4032 partition 3 16.0 MiB, > chardev (239:0) > [ 3.123201] bus_for_each_drv+0x8c/0xd8 > [ 3.123202] __device_attach+0xc4/0x150 > [ 3.123204] device_initial_probe+0x1c/0x28 > [ 3.123205] bus_probe_device+0x3c/0x9c > [ 3.123206] deferred_probe_work_func+0x90/0xcc > [ 3.123211] process_one_work+0x218/0x3ec > [ 3.131976] mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 > [ 3.134123] worker_thread+0x288/0x3e8 > [ 3.134124] kthread+0x148/0x1b0 > [ 3.134127] ret_from_fork+0x10/0x30 > [ 3.134128] ---[ end trace cfb9fce3f70f824d ]--- > > Signed-off-by: Sean Paul Reviewed-by: Dmitry Baryshkov Any Fixes: tag? > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..987f9e330138 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -219,6 +219,7 @@ static int dp_display_bind(struct device *dev, struct device *master, > goto end; > } > > + dp->aux->drm_dev = drm; > rc = dp_aux_register(dp->aux); > if (rc) { > DRM_ERROR("DRM DP AUX register failed\n"); > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA20C432BE for ; Tue, 27 Jul 2021 17:59:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18F7460F9F for ; Tue, 27 Jul 2021 17:59:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 18F7460F9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52D336E804; Tue, 27 Jul 2021 17:59:41 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A3886E929 for ; Tue, 27 Jul 2021 17:59:40 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id g13so23117422lfj.12 for ; Tue, 27 Jul 2021 10:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cqBzCBYK/WCh9fycS4ezNBnEiKw44dAJEHWTfNPIy0U=; b=c+MTlrWFU+6XLsvvTAgmQoRu6JG4hFHL7PCc9CGlg+QHotx0+E9GWWwgE7j2v629ZV 2OGpyO/TeEfOUJHCzL0kQcEeN86a/ONA9L4FHtt26y2263IRBo1GvgOJ6EJWfxpCevdh rKHMQx4jSHfeqcIdr7d5/QxwS1fVEYG1WMlwBj6iJM+Jr2QDaAsul5cH5dTPj/i62boy YBa53QOoyXwE4H8J1yKVkeJuXiGwgGZaGFzmak9jQyk4/N6eHFxOH9gJ6tmWBQw6Dm0t 5Gb0uidqiT0HxX+9+8i5/TbY91qYhcz1IGPdLACy3MhV98+LxUdg1KkZqqMjmKuCZ6wG yNjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cqBzCBYK/WCh9fycS4ezNBnEiKw44dAJEHWTfNPIy0U=; b=H7bYS4xiKnMpq9b0zS8VQUTCX9KMgIGPXANRYd+Turewr6fEic6T3myjL7N6BLQDfe TTxvVSeb97YfRZq/PQwI73ZlEtUCtPcj7bgWQuVVkBjkiZGxHGd99tcIaRWehf73rIqW zIZa+IOiaKPRyCfZJj8fipvAsmKKq47Q2vkEfN0bV987wZ4JaUTtuOhhLUFmBLOpeyvR U7YmdV/pey8eL8q3HNhFeM0jgvaEeH0QqPJvn7IofIVS3CIml50Fb/TOiUsjJBd7hr67 gHE9pzXnnvG8NHFG6UE2F7MQKT/55/boE+G9SS97R529NCyR9pgptFh6nY4nJe3+lOLa 5oUg== X-Gm-Message-State: AOAM531Kf5VXMayUJZWZa5GSdOVV+Rfizgc9X64GcX7GdrZkUQbJuXc6 ec2mp9HrOGVozWDDG88PMkOupA== X-Google-Smtp-Source: ABdhPJwukGjgB72jD7seeBnE75lkf5Eai5MBBJGu4pl4BkBTJt7OIQdo8ByoSHNkxtWwh6fZ5ulPNQ== X-Received: by 2002:a19:6d06:: with SMTP id i6mr18682045lfc.295.1627408778751; Tue, 27 Jul 2021 10:59:38 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id r16sm354131lfm.91.2021.07.27.10.59.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 10:59:38 -0700 (PDT) Subject: Re: [PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration To: Sean Paul , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210714152910.55093-1-sean@poorly.run> From: Dmitry Baryshkov Message-ID: Date: Tue, 27 Jul 2021 20:59:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210714152910.55093-1-sean@poorly.run> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 14/07/2021 18:28, Sean Paul wrote: > From: Sean Paul > > Avoids the following WARN: > [ 3.009556] ------------[ cut here ]------------ > [ 3.014306] WARNING: CPU: 7 PID: 109 at > drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac > [ 3.024209] Modules linked in: > [ 3.027351] CPU: 7 PID: 109 Comm: kworker/7:8 Not tainted 5.10.47 #69 > [ 3.033958] Hardware name: Google Lazor (rev1 - 2) (DT) > [ 3.039323] Workqueue: events deferred_probe_work_func > [ 3.044596] pstate: 60c00009 (nZCv daif +PAN +UAO -TCO BTYPE=--) > [ 3.050761] pc : drm_dp_aux_register+0xa4/0xac > [ 3.055329] lr : dp_aux_register+0x40/0x88 > [ 3.059538] sp : ffffffc010ad3920 > [ 3.062948] x29: ffffffc010ad3920 x28: ffffffa64196ac70 > [ 3.067239] mmc1: Command Queue Engine enabled > [ 3.068406] x27: ffffffa64196ac68 x26: 0000000000000001 > [ 3.068407] x25: 0000000000000002 x24: 0000000000000060 > [ 3.068409] x23: ffffffa642ab3400 x22: ffffffe126c10e5b > [ 3.068410] x21: ffffffa641dc3188 x20: ffffffa641963c10 > [ 3.068412] x19: ffffffa642aba910 x18: 00000000ffff0a00 > [ 3.068414] x17: 000000476f8e002a x16: 00000000000000b8 > [ 3.073008] mmc1: new HS400 Enhanced strobe MMC card at address 0001 > [ 3.078448] x15: ffffffffffffffff x14: ffffffffffffffff > [ 3.078450] x13: 0000000000000030 x12: 0000000000000030 > [ 3.078452] x11: 0101010101010101 x10: ffffffe12647a914 > [ 3.078453] x9 : ffffffe12647a8cc x8 : 0000000000000000 > [ 3.084452] mmcblk1: mmc1:0001 DA4032 29.1 GiB > [ 3.089372] > [ 3.089372] x7 : 6c6064717372fefe x6 : ffffffa642b11494 > [ 3.089374] x5 : 0000000000000000 x4 : 6d006c657869ffff > [ 3.089375] x3 : 000000006c657869 x2 : 000000000000000c > [ 3.089376] x1 : ffffffe126c3ae3c x0 : ffffffa642aba910 > [ 3.089381] Call trace: > [ 3.094931] mmcblk1boot0: mmc1:0001 DA4032 partition 1 4.00 MiB > [ 3.100291] drm_dp_aux_register+0xa4/0xac > [ 3.100292] dp_aux_register+0x40/0x88 > [ 3.100294] dp_display_bind+0x64/0xcc > [ 3.100295] component_bind_all+0xdc/0x210 > [ 3.100298] msm_drm_bind+0x1e8/0x5d4 > [ 3.100301] try_to_bring_up_master+0x168/0x1b0 > [ 3.105861] mmcblk1boot1: mmc1:0001 DA4032 partition 2 4.00 MiB > [ 3.112282] __component_add+0xa0/0x158 > [ 3.112283] component_add+0x1c/0x28 > [ 3.112284] dp_display_probe+0x33c/0x380 > [ 3.112286] platform_drv_probe+0x9c/0xbc > [ 3.112287] really_probe+0x140/0x35c > [ 3.112289] driver_probe_device+0x84/0xc0 > [ 3.112292] __device_attach_driver+0x94/0xb0 > [ 3.117967] mmcblk1rpmb: mmc1:0001 DA4032 partition 3 16.0 MiB, > chardev (239:0) > [ 3.123201] bus_for_each_drv+0x8c/0xd8 > [ 3.123202] __device_attach+0xc4/0x150 > [ 3.123204] device_initial_probe+0x1c/0x28 > [ 3.123205] bus_probe_device+0x3c/0x9c > [ 3.123206] deferred_probe_work_func+0x90/0xcc > [ 3.123211] process_one_work+0x218/0x3ec > [ 3.131976] mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 > [ 3.134123] worker_thread+0x288/0x3e8 > [ 3.134124] kthread+0x148/0x1b0 > [ 3.134127] ret_from_fork+0x10/0x30 > [ 3.134128] ---[ end trace cfb9fce3f70f824d ]--- > > Signed-off-by: Sean Paul Reviewed-by: Dmitry Baryshkov Any Fixes: tag? > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..987f9e330138 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -219,6 +219,7 @@ static int dp_display_bind(struct device *dev, struct device *master, > goto end; > } > > + dp->aux->drm_dev = drm; > rc = dp_aux_register(dp->aux); > if (rc) { > DRM_ERROR("DRM DP AUX register failed\n"); > -- With best wishes Dmitry