From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA2EC352A4 for ; Tue, 11 Feb 2020 02:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 300F620733 for ; Tue, 11 Feb 2020 02:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IaFne+tJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgBKCwJ (ORCPT ); Mon, 10 Feb 2020 21:52:09 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:29193 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727667AbgBKCwJ (ORCPT ); Mon, 10 Feb 2020 21:52:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581389527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KywBuU09rYNz429kY0Ae4epXMjSlQsHT1yqP8FKWMc=; b=IaFne+tJH5eEycUvo1G4behCAaNIc0kPjJkqfPdVkuLPqYIUNCnHXoqm5BcsTZ2x8z0HOp DxixjoLVl/c9BhsqLtb38FVCQJ8OuoUHAwBtp7jJ04mbJT/RDDwtpQ6q/s2zBDxWzlfELg ikAW9n/Y7npSeq0xS8+t9e0BEYGqeIc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-NLmRvZ56OAWtuJp8fyX7Vw-1; Mon, 10 Feb 2020 21:52:05 -0500 X-MC-Unique: NLmRvZ56OAWtuJp8fyX7Vw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17EE510054E3; Tue, 11 Feb 2020 02:52:04 +0000 (UTC) Received: from [10.72.12.184] (ovpn-12-184.pek2.redhat.com [10.72.12.184]) by smtp.corp.redhat.com (Postfix) with ESMTP id 733365C10E; Tue, 11 Feb 2020 02:51:56 +0000 (UTC) Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso To: Anton Ivanov , netdev@vger.kernel.org Cc: linux-um@lists.infradead.org, mst@redhat.com, virtualization@lists.linux-foundation.org References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> From: Jason Wang Message-ID: Date: Tue, 11 Feb 2020 10:51:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/2/11 =E4=B8=8A=E5=8D=8812:55, Anton Ivanov wrote: > > > On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: >> From: Anton Ivanov >> >> Some of the frames marked as GSO which arrive at >> virtio_net_hdr_from_skb() have no GSO_TYPE, no >> fragments (data_len =3D 0) and length significantly shorter >> than the MTU (752 in my experiments). >> >> This is observed on raw sockets reading off vEth interfaces >> in all 4.x and 5.x kernels I tested. >> >> These frames are reported as invalid while they are in fact >> gso-less frames. >> >> This patch marks the vnet header as no-GSO for them instead >> of reporting it as invalid. >> >> Signed-off-by: Anton Ivanov >> --- >> =C2=A0 include/linux/virtio_net.h | 8 ++++++-- >> =C2=A0 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >> index 0d1fe9297ac6..d90d5cff1b9a 100644 >> --- a/include/linux/virtio_net.h >> +++ b/include/linux/virtio_net.h >> @@ -112,8 +112,12 @@ static inline int virtio_net_hdr_from_skb(const=20 >> struct sk_buff *skb, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_TCPV4; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if (sinfo-= >gso_type & SKB_GSO_TCPV6) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_TCPV6; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn -EINVAL; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if= (skb->data_len =3D=3D 0) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_NONE; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 el= se >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 return -EINVAL; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (sinfo->gso_= type & SKB_GSO_TCP_ECN) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 hdr->gso_type |=3D VIRTIO_NET_HDR_GSO_ECN; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else >> > > ping. > Do you mean gso_size is set but gso_type is not? Looks like a bug elsewhe= re. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1LfK-00038m-Rx for linux-um@lists.infradead.org; Tue, 11 Feb 2020 02:52:47 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> From: Jason Wang Message-ID: Date: Tue, 11 Feb 2020 10:51:54 +0800 MIME-Version: 1.0 In-Reply-To: <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Anton Ivanov , netdev@vger.kernel.org Cc: virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org, mst@redhat.com Ck9uIDIwMjAvMi8xMSDkuIrljYgxMjo1NSwgQW50b24gSXZhbm92IHdyb3RlOgo+Cj4KPiBPbiAw OS8xMi8yMDE5IDEwOjQ4LCBhbnRvbi5pdmFub3ZAY2FtYnJpZGdlZ3JleXMuY29tIHdyb3RlOgo+ PiBGcm9tOiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4+ Cj4+IFNvbWUgb2YgdGhlIGZyYW1lcyBtYXJrZWQgYXMgR1NPIHdoaWNoIGFycml2ZSBhdAo+PiB2 aXJ0aW9fbmV0X2hkcl9mcm9tX3NrYigpIGhhdmUgbm8gR1NPX1RZUEUsIG5vCj4+IGZyYWdtZW50 cyAoZGF0YV9sZW4gPSAwKSBhbmQgbGVuZ3RoIHNpZ25pZmljYW50bHkgc2hvcnRlcgo+PiB0aGFu IHRoZSBNVFUgKDc1MiBpbiBteSBleHBlcmltZW50cykuCj4+Cj4+IFRoaXMgaXMgb2JzZXJ2ZWQg b24gcmF3IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4+IGluIGFsbCA0Lngg YW5kIDUueCBrZXJuZWxzIEkgdGVzdGVkLgo+Pgo+PiBUaGVzZSBmcmFtZXMgYXJlIHJlcG9ydGVk IGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+PiBnc28tbGVzcyBmcmFtZXMuCj4+ Cj4+IFRoaXMgcGF0Y2ggbWFya3MgdGhlIHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhlbSBp bnN0ZWFkCj4+IG9mIHJlcG9ydGluZyBpdCBhcyBpbnZhbGlkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4+IC0tLQo+ PiDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysrLS0KPj4gwqAgMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oIGIvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0 LmgKPj4gaW5kZXggMGQxZmU5Mjk3YWM2Li5kOTBkNWNmZjFiOWEgMTAwNjQ0Cj4+IC0tLSBhL2lu Y2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4+ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlvX25l dC5oCj4+IEBAIC0xMTIsOCArMTEyLDEyIEBAIHN0YXRpYyBpbmxpbmUgaW50IHZpcnRpb19uZXRf aGRyX2Zyb21fc2tiKGNvbnN0IAo+PiBzdHJ1Y3Qgc2tfYnVmZiAqc2tiLAo+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RDUFY0 Owo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZSBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dT T19UQ1BWNikKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSA9IFZJ UlRJT19ORVRfSERSX0dTT19UQ1BWNjsKPj4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPj4gLcKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+ICvCoMKgwqDCoMKgwqDCoCBlbHNl IHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNrYi0+ZGF0YV9sZW4gPT0gMCkKPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05F VF9IRFJfR1NPX05PTkU7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVsc2UKPj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPj4gK8KgwqDCoMKgwqDC oMKgIH0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChzaW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NP X1RDUF9FQ04pCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgfD0g VklSVElPX05FVF9IRFJfR1NPX0VDTjsKPj4gwqDCoMKgwqDCoCB9IGVsc2UKPj4KPgo+IHBpbmcu Cj4KCkRvIHlvdSBtZWFuIGdzb19zaXplIGlzIHNldCBidXQgZ3NvX3R5cGUgaXMgbm90PyBMb29r cyBsaWtlIGEgYnVnIGVsc2V3aGVyZS4KClRoYW5rcwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1haWxpbmcgbGlzdApsaW51eC11bUBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtdW0K