Re: [PATCH rdma-next 07/11] RDMA/erdma: Add verbs implementation

[Cheng Xu <chengyou@linux.alibaba.com>]

On 12/21/21 9:32 PM, Leon Romanovsky wrote:
> On Tue, Dec 21, 2021 at 10:48:54AM +0800, Cheng Xu wrote:
>> The RDMA verbs implementation of erdma is divided into three files:
>> erdma_qp.c, erdma_cq.c, and erdma_verbs.c. Internal used functions and
>> datapath functions of QP/CQ are put in erdma_qp.c and erdma_cq.c, the reset
>> is in erdma_verbs.c.
>>
>> Signed-off-by: Cheng Xu <chengyou@linux.alibaba.com>
>> ---
>>   drivers/infiniband/hw/erdma/erdma_cq.c    |  201 +++
>>   drivers/infiniband/hw/erdma/erdma_qp.c    |  624 +++++++++
>>   drivers/infiniband/hw/erdma/erdma_verbs.c | 1477 +++++++++++++++++++++
>>   3 files changed, 2302 insertions(+)
>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_cq.c
>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_qp.c
>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_verbs.c
> 
> 
> Please no inline functions in .c files and no void casting for the
> return values of functions.

Will fix it.

> <...>
> 
>> diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c
>> new file mode 100644
>> index 000000000000..8c02215cee04
>> --- /dev/null
>> +++ b/drivers/infiniband/hw/erdma/erdma_qp.c
>> @@ -0,0 +1,624 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Authors: Cheng Xu <chengyou@linux.alibaba.com>
>> + *          Kai Shen <kaishen@linux.alibaba.com>
>> + * Copyright (c) 2020-2021, Alibaba Group.
>> + *
>> + * Authors: Bernard Metzler <bmt@zurich.ibm.com>
>> + *          Fredy Neeser <nfd@zurich.ibm.com>
>> + * Copyright (c) 2008-2016, IBM Corporation
> 
> What does it mean?
> 
> Thanks

As mentioned in patch 08, parts of our code come from siw with some
modification. In "erdma_qp.c" and "erdma_verbs.c", the code related with
CM module is also developed based on siw, mainly including qp state
machine implementation. So we keep original authors and copyright
information in the files.

Thanks,
Cheng Xu