All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 7/9] gnttab: no need to translate handle for gnttab_get_status_frames()
Date: Fri, 7 Oct 2022 18:24:23 +0000	[thread overview]
Message-ID: <f797f122-2fd7-3acb-3c0b-ec790c16be0f@citrix.com> (raw)
In-Reply-To: <ed6a8403-dc91-05c8-25e5-81b5fb706cc2@suse.com>

On 26/08/2021 11:14, Jan Beulich wrote:
> Unlike for GNTTABOP_setup_table native and compat frame lists are arrays

"GNTTABOP_setup_table, native"

But I think it would also be clearer to follow with

"frame lists for GNTTABOP_get_status_frames are of".

> of the same type (uint64_t). Hence there's no need to translate the frame
> values. This then also renders unnecessary the limit_max parameter of
> gnttab_get_status_frames().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

  reply	other threads:[~2022-10-07 18:24 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 10:06 [PATCH 0/9] gnttab: further work from XSA-380 / -382 context Jan Beulich
2021-08-26 10:09 ` [PATCH 1/9] gnttab: defer allocation of maptrack frames table Jan Beulich
2021-09-06 13:13   ` Julien Grall
2021-09-06 13:29     ` Jan Beulich
2021-09-06 13:33       ` Julien Grall
2021-09-06 13:58         ` Jan Beulich
2021-09-06 14:05   ` Andrew Cooper
2021-09-06 14:43     ` Jan Beulich
2021-08-26 10:11 ` [PATCH 2/9] gnttab: drop a redundant expression from gnttab_release_mappings() Jan Beulich
2021-09-06 13:15   ` Julien Grall
2021-08-26 10:12 ` [PATCH 3/9] gnttab: fold recurring is_iomem_page() Jan Beulich
2021-09-06 13:35   ` Julien Grall
2021-09-06 14:02     ` Jan Beulich
2021-08-26 10:13 ` [PATCH 4/9] gnttab: drop GNTMAP_can_fail Jan Beulich
2021-08-26 11:45   ` Andrew Cooper
2021-08-26 13:03     ` Jan Beulich
2021-08-26 13:13       ` Andrew Cooper
2021-08-26 10:13 ` [PATCH 5/9] gnttab: defer allocation of status frame tracking array Jan Beulich
2021-08-26 10:13 ` [PATCH 6/9] gnttab: check handle early in gnttab_get_status_frames() Jan Beulich
2021-09-06 13:41   ` Julien Grall
2021-08-26 10:14 ` [PATCH 7/9] gnttab: no need to translate handle for gnttab_get_status_frames() Jan Beulich
2022-10-07 18:24   ` Andrew Cooper [this message]
2021-08-26 10:14 ` [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of error Jan Beulich
2022-10-07 19:36   ` Andrew Cooper
2022-10-10  9:30     ` Jan Beulich
2021-08-26 10:15 ` [PATCH 9/9] gnttab: don't silently truncate GFNs in compat setup-table handling Jan Beulich
2022-10-07 19:57   ` Andrew Cooper
2022-10-10  8:46     ` Jan Beulich
2022-01-05  7:42 ` Ping: [PATCH 0/9] gnttab: further work from XSA-380 / -382 context Jan Beulich
2022-10-07 13:49 ` Jan Beulich
2022-10-07 18:09   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f797f122-2fd7-3acb-3c0b-ec790c16be0f@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.