All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Volodymyr Babchuk <volodymyr_babchuk@epam.com>, xen-devel@lists.xen.org
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
	Volodymyr Babchuk <vlad.babchuk@gmail.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/7] arm: make processor-specific functions from traps.c globaly visible
Date: Wed, 9 Aug 2017 10:53:43 +0100	[thread overview]
Message-ID: <f79b61a9-095b-b5a8-8ffc-98003de0f243@arm.com> (raw)
In-Reply-To: <1502222922-25821-3-git-send-email-volodymyr_babchuk@epam.com>

Hi Volodymyr,

On 08/08/17 21:08, Volodymyr Babchuk wrote:
> From: Volodymyr Babchuk <vlad.babchuk@gmail.com>
>
> The following list of functions:
>
>  - advance_pc()
>  - check_conditional_instr()
>  - inject_undef_exception()
>  - inject_iabt_exception()
>  - inject_dabt_exception()
>  - inject_vabt_exception()
>
> are now globaly visible. This change is needed becase we plan to handle SMCs
> in different file and handler code needs to alter state of a guest.
>
> Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
> ---
>  xen/arch/arm/traps.c            | 16 ++++++----------
>  xen/include/asm-arm/processor.h | 11 +++++++++++

I would much prefer if you introduce a new header traps.h rather than 
piggy-back on the now growing processor.h.

I have actually a series that will do that, but I am happy if you 
introduce it before me.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-08-09  9:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 20:08 [PATCH v3 0/7] Handle SMCs and HVCs in conformance with SMCCC Volodymyr Babchuk
2017-08-08 20:08 ` [PATCH 1/7] arm: traps: psci: use generic register accessors Volodymyr Babchuk
2017-08-08 20:37   ` Andrew Cooper
2017-08-08 20:46     ` Volodymyr Babchuk
2017-08-09  9:52     ` Julien Grall
2017-08-09 11:12       ` Andrew Cooper
2017-08-09 11:43         ` Julien Grall
2017-08-08 20:08 ` [PATCH 2/7] arm: make processor-specific functions from traps.c globaly visible Volodymyr Babchuk
2017-08-09  9:53   ` Julien Grall [this message]
2017-08-09 19:26     ` Volodymyr Babchuk
2017-08-09 20:13       ` Julien Grall
2017-08-08 20:08 ` [PATCH 3/7] arm: traps: check if SMC was conditional before handling it Volodymyr Babchuk
2017-08-09  9:56   ` Julien Grall
2017-08-08 20:08 ` [PATCH 4/7] arm: smccc: handle SMCs according to SMCCC Volodymyr Babchuk
2017-08-09 10:10   ` Julien Grall
2017-08-09 11:58     ` Jan Beulich
2017-08-09 21:39       ` Volodymyr Babchuk
2017-08-10  7:30         ` Jan Beulich
2017-08-10 10:48           ` Julien Grall
2017-08-16 21:41       ` Volodymyr Babchuk
2017-08-17  7:45         ` Jan Beulich
2017-08-17 12:35           ` Volodymyr Babchuk
2017-08-17 12:52             ` Julien Grall
2017-08-17 12:56             ` Jan Beulich
2017-08-10 15:33     ` Volodymyr Babchuk
2017-08-10 16:11       ` Julien Grall
2017-08-10 17:40         ` Volodymyr Babchuk
2017-08-10 18:18           ` Julien Grall
2017-08-10 20:09             ` Volodymyr Babchuk
2017-08-10 21:09               ` Julien Grall
2017-08-11 10:47                 ` Julien Grall
2017-08-11 13:08                 ` Volodymyr Babchuk
2017-08-08 20:08 ` [PATCH 5/7] arm: traps: handle PSCI calls inside `smccc.c` Volodymyr Babchuk
2017-08-09 11:02   ` Julien Grall
2017-08-08 20:08 ` [PATCH 6/7] arm: psci: use definitions provided by vsmc.h Volodymyr Babchuk
2017-08-09 11:36   ` Julien Grall
2017-08-08 20:08 ` [PATCH 7/7] arm: vsmc: remove 64 bit mode check in psci handler Volodymyr Babchuk
2017-08-09 11:38   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f79b61a9-095b-b5a8-8ffc-98003de0f243@arm.com \
    --to=julien.grall@arm.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=sstabellini@kernel.org \
    --cc=vlad.babchuk@gmail.com \
    --cc=volodymyr_babchuk@epam.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.