From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
programmingkidx@gmail.com
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)
Date: Wed, 23 Nov 2016 10:59:58 -0600 [thread overview]
Message-ID: <f7b4beba-3e82-10d0-567c-6aad63854544@redhat.com> (raw)
In-Reply-To: <8737iim8xi.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On 11/23/2016 10:56 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> On 11/23/2016 08:17 AM, Markus Armbruster wrote:
>>
>>>
>>> The first two patches are bug fixes, and as such they should be
>>> considered for 2.8.
>>>
>>> This patch doesn't fix anything, and it might conceivably break
>>> something. Too late for 2.8.
>>
>> Ah, but it DOES fix check-qjson on Mac OS.
>
> PATCH 1+2 do, don't they?
No, patch 1 fixes emission of QMP events, patch 2 fixes check-qga. Also
reported broken by G 3 was check-qjson, and my audit revealed that
test-qobject-input-visitor is also affected.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-11-23 17:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:16 [Qemu-devel] [PATCH for-2.8 0/3] Fix MacOS runtime failure of qobject_from_jsonf() Eric Blake
2016-11-23 4:16 ` [Qemu-devel] [PATCH 1/3] qmp-event: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 13:45 ` Markus Armbruster
2016-11-23 13:56 ` Eric Blake
2016-11-23 14:04 ` Eric Blake
2016-11-23 4:16 ` [Qemu-devel] [PATCH 2/3] test-qga: " Eric Blake
2016-11-23 9:23 ` Paolo Bonzini
2016-11-23 10:36 ` Eric Blake
2016-11-23 11:08 ` Eric Blake
2016-11-23 12:06 ` Paolo Bonzini
2016-11-23 14:05 ` Markus Armbruster
2016-11-23 14:14 ` Eric Blake
2016-11-23 16:55 ` Markus Armbruster
2016-11-23 4:16 ` [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 9:25 ` Paolo Bonzini
2016-11-23 10:54 ` Eric Blake
2016-11-23 14:17 ` Markus Armbruster
2016-11-23 14:24 ` Eric Blake
2016-11-23 16:56 ` Markus Armbruster
2016-11-23 16:59 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b4beba-3e82-10d0-567c-6aad63854544@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.