From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2947EC433ED for ; Fri, 9 Apr 2021 12:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F19DB610E7 for ; Fri, 9 Apr 2021 12:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbhDIM4P (ORCPT ); Fri, 9 Apr 2021 08:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233759AbhDIM4P (ORCPT ); Fri, 9 Apr 2021 08:56:15 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36FB5C061760 for ; Fri, 9 Apr 2021 05:56:02 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id z1so6440363edb.8 for ; Fri, 09 Apr 2021 05:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citymesh-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kvoch3I7dH1Borope1QoU/3kV19MJ6NYyNXR2koLaZQ=; b=Ofh9yB9b3ptIysHXeCvSt4gLfRa231Qv/0DfeDuqTTxOBFD9MXOXA9G8ZA2pCvXW0B WeH58xd9IO7WHPic7gQlGm/WVzBEq/6jqDfVmiGUuRpK4ff6VGB8l8yMTt3LzOB/K2Gv I9HsdkWrkdz3pxf/KaHzFL2md8B/Xsn8eua0KxJA7YRBy9/7dyzBEkkl/4hisspieaVH V6Kxo2ss2p/zUoQigfBaXOm2SfDtm/zVjhMtcwiNpc1EgBtIMBJmgKAQjdYBM64bzKW+ +MPS0fbBjETb6fiVb9XXbLU0XYZycarw/5HRkFeqN+tGTkN1tD4hFzbOP+/nP7LELZ86 KIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kvoch3I7dH1Borope1QoU/3kV19MJ6NYyNXR2koLaZQ=; b=TKTTkwj5imNLdBwWlT1wXX9xN8DFnsG6pk7Iezo/KBfT37T55YYdCZ56nSwpgSw4V7 gBrfuTGMCvM4zTvcyVSMsxoTrNatnrz6WpCqm1ao8MLcuUVVuVEUMsOjF4lzVadfs47E 9PwQjkj1kOeh+kznibjZgrTk/tYODBq5ajoibDq8mtfCEj7xNS0sghGx1NQIP7DGRZtg tPz86grnFPXWffNscas3ohOhZmBqyXxDmnGG73jB1OXoNRmzxjvVEQzeXfK64/3ETckc EeUlI9vP+uRBEVOjW68Thpzjl+c7qoPaInki43msxsUZftz1A+ANQJBX/fab53rNizCk x5AA== X-Gm-Message-State: AOAM532Yad5QGDO52aGWmmU1Bvq4/ANBKPWi5nFaR+rQ3zzxOiPZOXg6 UntiokSmGeAWLugKhyza0RBXRQ== X-Google-Smtp-Source: ABdhPJxXuyERTLCe84nRJRD0IMXBvhEwcKd1tM/u03fdGXcXchboST8Um+NAuTRcZkFjI3/gpwAaAA== X-Received: by 2002:aa7:c683:: with SMTP id n3mr6269330edq.214.1617972960926; Fri, 09 Apr 2021 05:56:00 -0700 (PDT) Received: from [10.202.0.7] ([31.31.140.89]) by smtp.gmail.com with ESMTPSA id h24sm1217935ejl.9.2021.04.09.05.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Apr 2021 05:56:00 -0700 (PDT) Subject: Re: flexcan introduced a DIV/0 in kernel To: Marc Kleine-Budde , linux-can@vger.kernel.org Cc: wg@grandegger.com, netdev@vger.kernel.org, qiangqing.zhang@nxp.com, gregkh@linuxfoundation.org References: <5bdfcccb-0b02-e46b-eefe-7df215cc9d02@citymesh.com> <27f66de1-42bc-38d9-8a1c-7062eb359958@pengutronix.de> From: Koen Vandeputte Message-ID: Date: Fri, 9 Apr 2021 14:55:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <27f66de1-42bc-38d9-8a1c-7062eb359958@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On 09.04.21 13:21, Marc Kleine-Budde wrote: > On 4/9/21 12:18 PM, Koen Vandeputte wrote: >> Hi All, >> >> I just updated kernel 4.14 within OpenWRT from 4.14.224 to 4.14.229 >> Booting it shows the splat below on each run. [1] >> >> >> It seems there are 2 patches regarding flexcan which were introduced in >> 4.14.226 >> >> --> ce59ffca5c49 ("can: flexcan: enable RX FIFO after FRZ/HALT valid") >> --> bb7c9039a396 ("can: flexcan: assert FRZ bit in flexcan_chip_freeze()") >> >> Reverting these fixes the splat. > This patch should fix the problem: > > 47c5e474bc1e can: flexcan: flexcan_chip_freeze(): fix chip freeze for missing > bitrate > > Greg, can you pick this up for v4.14? > > regards, > Marc > Checking kernels 4.4 & 4.9 shows that this fix is also missing over there. Marc, Can you confirm that it's also required for these? Thanks, Koen