Re: [PATCH v2] perf test: Workload test of metric and metricgroups

From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	Jin Yao <yao.jin@linux.intel.com>,
	<linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <eranian@google.com>
Subject: Re: [PATCH v2] perf test: Workload test of metric and metricgroups
Date: Thu, 16 Sep 2021 08:41:17 +0100	[thread overview]
Message-ID: <f7bbc59b-794f-2675-a044-1e3a58ad1495@huawei.com> (raw)
In-Reply-To: <20210916060525.1890638-1-irogers@google.com>

On 16/09/2021 07:05, Ian Rogers wrote:
> Test every metric and metricgroup with 'true' as a workload.
> 
> Signed-off-by: Ian Rogers<irogers@google.com>

Reviewed-by: John Garry <john.garry@huawei.com>

Note that I also had a local test for pmu events:
for e in `$PERF list --raw-dump pmu`; do
   echo "Testing $e"
   result=$($PERF stat -v -e "$e" perf bench internals synthesize)
   if [[ "$result" =~ "$e" ]]; then
     echo "Event not printed: $e"
     exit 1
   fi
done

Is there any value in upstreaming this? I could not see same already 
there. Or else make your new script generic, so that it accepts an 
argument whether to test events or metrics or metricgroups