All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Orzel <michal.orzel@amd.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>,
	<xen-devel@lists.xenproject.org>
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v4 2/3] automation: Add a clean rule for containers
Date: Fri, 18 Nov 2022 09:58:55 +0100	[thread overview]
Message-ID: <f7c65c1f-c566-af6f-e1c3-c1c27e5abeea@amd.com> (raw)
In-Reply-To: <3a127e836d744fbb2954690293ee47d2c0c899e2.1668677493.git.bertrand.marquis@arm.com>

Hi Bertrand,

On 17/11/2022 10:39, Bertrand Marquis wrote:
> 
> 
> Add make clean support to remove the containers from the local docker
> registry:
I have to say that I am a bit scared of adding a clean rule.
make clean is something that can easily sneak into this directory and can
remove the yocto images that we had to spent several hours to build.
The accidental clean can have severe consequences :)

In any case, if we want to add such possibility I would stick to calling always:
make clean-<image>
and remove the option to call "make clean" to remove all the images.

~Michal


  reply	other threads:[~2022-11-18  8:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  9:39 [PATCH v4 0/3] Yocto Gitlab CI Bertrand Marquis
2022-11-17  9:39 ` [PATCH v4 1/3] automation: Create Yocto docker images Bertrand Marquis
2022-11-18  8:53   ` Michal Orzel
2022-11-18 11:44     ` Bertrand Marquis
2022-11-18 11:54       ` Michal Orzel
2022-11-18 13:08         ` Bertrand Marquis
2022-11-18 23:34   ` Stefano Stabellini
2022-11-17  9:39 ` [PATCH v4 2/3] automation: Add a clean rule for containers Bertrand Marquis
2022-11-18  8:58   ` Michal Orzel [this message]
2022-11-18 13:09     ` Bertrand Marquis
2022-11-17  9:39 ` [PATCH v4 3/3] automation: Add CI test jobs for Yocto Bertrand Marquis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7c65c1f-c566-af6f-e1c3-c1c27e5abeea@amd.com \
    --to=michal.orzel@amd.com \
    --cc=bertrand.marquis@arm.com \
    --cc=cardoe@cardoe.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.