From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by arago-project.org (Postfix) with ESMTPS id 8B39B529E8 for ; Wed, 30 Oct 2019 15:03:05 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9UF1i8x006615 for ; Wed, 30 Oct 2019 10:01:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572447704; bh=ieGcIHYWFYfB8Qc/EcFHwnIM0+7PGMXlYmpxeZYldGE=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=UuE9S1oNeuKeqKmr2VyB6TQDBT1Fr/B0bFFHvneZbEKN/ZH9IEUgrkWvVAFR46ju/ dS19tprE28kfTPnNpj0Ci988oGMQC99F1YY7tsnH9DWNOLGGflzkQr+hq+12x6igNO HbiOk76Z8WgFmEVzI1VfmU2y9PxDC4dSwC9StQaI= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9UF1iwe117442 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 30 Oct 2019 10:01:44 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 30 Oct 2019 10:01:44 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 30 Oct 2019 10:01:32 -0500 Received: from [10.250.45.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9UF1iKg055739; Wed, 30 Oct 2019 10:01:44 -0500 To: "Ruei, Eric" , Denys Dmytriyenko , Eric Ruei References: <20191029135349.31792-1-e-ruei1@ti.com> <20191029135349.31792-4-e-ruei1@ti.com> <20191029211322.GJ7518@beryl> <622a87d9-d036-a988-1535-414230b68531@ti.com> From: "Andrew F. Davis" Message-ID: Date: Wed, 30 Oct 2019 11:01:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <622a87d9-d036-a988-1535-414230b68531@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [PATCH 3/7] HACK: weston: undefine HAVE_GBM_MODIFIERS explicitly X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2019 15:03:06 -0000 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/30/19 10:41 AM, Ruei, Eric wrote: > On 10/29/2019 5:13 PM, Denys Dmytriyenko wrote: >> On Tue, Oct 29, 2019 at 09:53:45AM -0400, Eric Ruei wrote: >>> This hack is required tentatively until GBM_MODIFIERS is fully supported >>> by Mesa-based EGL. >>> >>> Signed-off-by: Eric Ruei >>> --- >>>   ...mposito-drm-undef-HAVE_GBM_MODIFIERS.patch | 29 +++++++++++++++++++ >>>   .../wayland/weston_5.0.0.bbappend             |  3 +- >>>   2 files changed, 31 insertions(+), 1 deletion(-) >>>   create mode 100644 >>> meta-arago-distro/recipes-graphics/wayland/weston/0001-HACK-composito-drm-undef-HAVE_GBM_MODIFIERS.patch >>> >>> >>> diff --git >>> a/meta-arago-distro/recipes-graphics/wayland/weston/0001-HACK-composito-drm-undef-HAVE_GBM_MODIFIERS.patch >>> b/meta-arago-distro/recipes-graphics/wayland/weston/0001-HACK-composito-drm-undef-HAVE_GBM_MODIFIERS.patch >>> >>> new file mode 100644 >>> index 00000000..56a78e46 >>> --- /dev/null >>> +++ >>> b/meta-arago-distro/recipes-graphics/wayland/weston/0001-HACK-composito-drm-undef-HAVE_GBM_MODIFIERS.patch >>> >>> @@ -0,0 +1,29 @@ >>> +From e406b4141c23fb762a14a09d565c363ebaccb5a4 Mon Sep 17 00:00:00 2001 >>> +From: Eric Ruei >>> +Date: Sun, 1 Sep 2019 08:28:27 -0400 >>> +Subject: [PATCH] HACK: composito-drm: undef HAVE_GBM_MODIFIERS >>> + >>> +HAVE_GBM_MODIFIERS is defined, but not fully supported by the gbm >>> module >>> +yet. >> >> Upstream-Status: Inappropriate [reason] >> >> > > Denys: > > Thanks!This patch is no longer needed and I shall remove it at v2. > Why is this no longer needed? Last time I built this we still had failures without explicitly disabling GBM_MODIFIERS. Andrew > Eric > >>> +Signed-off-by: Eric Ruei >>> +--- >>> + libweston/compositor-drm.c | 2 ++ >>> + 1 file changed, 2 insertions(+) >>> + >>> +diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c >>> +index d92ecfcd..88f845a8 100644 >>> +--- a/libweston/compositor-drm.c >>> ++++ b/libweston/compositor-drm.c >>> +@@ -68,6 +68,8 @@ >>> + #include "linux-dmabuf-unstable-v1-server-protocol.h" >>> + #include "linux-explicit-synchronization.h" >>> + >>> ++#undef HAVE_GBM_MODIFIERS >>> ++ >>> + #ifndef DRM_CLIENT_CAP_ASPECT_RATIO >>> + #define DRM_CLIENT_CAP_ASPECT_RATIO    4 >>> + #endif >>> +-- >>> +2.17.1 >>> + >>> diff --git >>> a/meta-arago-distro/recipes-graphics/wayland/weston_5.0.0.bbappend >>> b/meta-arago-distro/recipes-graphics/wayland/weston_5.0.0.bbappend >>> index 1bdcf7e4..94a5bc60 100644 >>> --- a/meta-arago-distro/recipes-graphics/wayland/weston_5.0.0.bbappend >>> +++ b/meta-arago-distro/recipes-graphics/wayland/weston_5.0.0.bbappend >>> @@ -2,7 +2,7 @@ >>>   PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor >>> WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev >>> mtdev" >>>   PACKAGECONFIG[kms] = >>> "--enable-drm-compositor,--disable-drm-compositor,drm udev >>> virtual/libgbm mtdev" >>>   -PR_append = ".arago34" >>> +PR_append = ".arago35" >>>     FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" >>>   @@ -26,6 +26,7 @@ SRC_URI += " \ >>>           file://0011-compositor-Add-scene-graph-debug-scope.patch \ >>>           >>> file://0012-compositor-drm-Add-backend-pointer-to-drm_output.patch \ >>>           >>> file://0013-compositor-drm-Add-drm-backend-log-debug-scope.patch \ >>> +    file://0001-HACK-composito-drm-undef-HAVE_GBM_MODIFIERS.patch \ >>>   " >>>     INHIBIT_PACKAGE_STRIP = "1" >>> --  >>> 2.17.1 >>> >>> _______________________________________________ >>> meta-arago mailing list >>> meta-arago@arago-project.org >>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >