From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703ADC433F5 for ; Wed, 13 Oct 2021 19:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40A28611C0 for ; Wed, 13 Oct 2021 19:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhJMTS1 (ORCPT ); Wed, 13 Oct 2021 15:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237747AbhJMTST (ORCPT ); Wed, 13 Oct 2021 15:18:19 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4428DC061570 for ; Wed, 13 Oct 2021 12:16:15 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id j21so16666922lfe.0 for ; Wed, 13 Oct 2021 12:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=u/texRWtJ2KbD0oQrB97AzLXUWEuY++oRPe+Tjc/3gA=; b=OiLv79C5RwizCegkjzE//+3Rb0Uzvw8wtC/+DjFOYjoMOwuIWUQF341uXNSbDJwlpl n+6o1ogkumsOLxhD1Gj/HwBtAg0Ynvpovk94twIeNuf5ufmJup+Cl5H9mWuvDNl0TPZ1 uFn4IkQpCSQR5qWrRGmdAZZEMeIQvsbwPiwVzX2OGVSX5Fs1FNenppvyGngvBBnnN7b4 Vq5nnXfZIk/xbmk/cPFstKNJlTl1QjSYmev9KxOFVxQX7WCXUng1G6p+jPQTgx3KRit/ /Py5u0uKDyav9WI5DO1kh6S8T+qF/u1D5mSzWsviKdAtav0/0pGNHqbxwamqV/BZB2qQ rZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u/texRWtJ2KbD0oQrB97AzLXUWEuY++oRPe+Tjc/3gA=; b=uosyKVKec/Pzw4TRTdtyE7VFA2OJ+9rtcB+pI9YAQwAkYlObUN3d7XDUTpW5wto30O AvF5z0OXZgaeC/mJS2XZRJui+r3l/UhyA+7cvxvweBuUsrUiAwXhNW1dOYB2d2p48ifp 0VHmq4iG0coweqmX8oH0yI7RFXrloec+8W0ajFdC4/qrIWVGVi6GXq74fU0TbtyQN31W EXckKPB2RQUwqh72pkdzrpMxftZlEK6kmDzwfstFs1JHnYrgpGwvQSuqUL1jHUrWA++8 8n36R27qIEdM+r62gahY4tYOAN1hrhsx3DSWLk4jmacSdZ5bzJkkZUo2tr1Hrpr1R/f7 dCUQ== X-Gm-Message-State: AOAM533pn7mM33KW7BqeQRacmtitA32Z2kviA2MgdkUyrpLChex9wVwx uhWhkWxfGC8PUwHm/Isv2F4g4A== X-Google-Smtp-Source: ABdhPJzzY0eVMSGVG8XPuoef9sBLmgKFgZrRE0vF81n9m20q0PBBM+njve8V91z6kQGhiJ2hnCpFkw== X-Received: by 2002:a2e:4e01:: with SMTP id c1mr1271836ljb.460.1634152573513; Wed, 13 Oct 2021 12:16:13 -0700 (PDT) Received: from [192.168.1.102] (62-248-207-242.elisa-laajakaista.fi. [62.248.207.242]) by smtp.gmail.com with ESMTPSA id v5sm30716lfo.49.2021.10.13.12.16.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 12:16:13 -0700 (PDT) Subject: Re: [PATCH v4 13/20] dma: qcom: bam_dma: Add support to initialize interconnect path To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org Cc: bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, Thara Gopinath , Bjorn Andersson References: <20211013105541.68045-1-bhupesh.sharma@linaro.org> <20211013105541.68045-14-bhupesh.sharma@linaro.org> From: Vladimir Zapolskiy Message-ID: Date: Wed, 13 Oct 2021 22:15:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20211013105541.68045-14-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Bhupesh, Thara, On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > From: Thara Gopinath > > BAM dma engine associated with certain hardware blocks could require > relevant interconnect pieces be initialized prior to the dma engine > initialization. For e.g. crypto bam dma engine on sm8250. Such requirement > is passed on to the bam dma driver from dt via the "interconnects" > property. Add support in bam_dma driver to check whether the interconnect > path is accessible/enabled prior to attempting driver intializations. > > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma > [Make header file inclusion alphabetical] > Signed-off-by: Thara Gopinath > --- > drivers/dma/qcom/bam_dma.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > index c8a77b428b52..fc84ef42507d 100644 > --- a/drivers/dma/qcom/bam_dma.c > +++ b/drivers/dma/qcom/bam_dma.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -392,6 +393,7 @@ struct bam_device { > const struct reg_offset_data *layout; > > struct clk *bamclk; > + struct icc_path *mem_path; > int irq; > > /* dma start transaction tasklet */ > @@ -1284,9 +1286,18 @@ static int bam_dma_probe(struct platform_device *pdev) > return ret; > } > > + /* Ensure that interconnects are initialized */ > + bdev->mem_path = of_icc_get(bdev->dev, "memory"); I suppose devm_of_icc_get() usage could leave the error path and bam_dma_remove() intact. > + > + if (IS_ERR(bdev->mem_path)) { > + ret = PTR_ERR(bdev->mem_path); > + dev_err(bdev->dev, "failed to acquire icc path %d\n", ret); > + goto err_disable_clk; > + } > + > ret = bam_init(bdev); > if (ret) > - goto err_disable_clk; > + goto err_icc_path_put; > > tasklet_setup(&bdev->task, dma_tasklet); > > @@ -1371,6 +1382,8 @@ static int bam_dma_probe(struct platform_device *pdev) > tasklet_kill(&bdev->channels[i].vc.task); > err_tasklet_kill: > tasklet_kill(&bdev->task); > +err_icc_path_put: > + icc_put(bdev->mem_path); > err_disable_clk: > clk_disable_unprepare(bdev->bamclk); > > @@ -1406,6 +1419,7 @@ static int bam_dma_remove(struct platform_device *pdev) > > tasklet_kill(&bdev->task); > > + icc_put(bdev->mem_path); > clk_disable_unprepare(bdev->bamclk); > > return 0; > -- Best wishes, Vladimir