From: David Ahern <dsa@cumulusnetworks.com>
To: Jakub Sitnicki <jkbs@redhat.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2] Enable use of extra debugging information
Date: Wed, 22 Jun 2016 10:55:34 -0600 [thread overview]
Message-ID: <f7d1368f-c71e-d2fe-bf79-caa631f4ecc9@cumulusnetworks.com> (raw)
In-Reply-To: <87oa6tmxgo.fsf@frog.home>
On 6/22/16 2:36 AM, Jakub Sitnicki wrote:
>> diff --git a/Makefile b/Makefile
>> index 15c81ecfdca3..8e006759079d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -39,7 +39,11 @@ HOSTCC = gcc
>> DEFINES += -D_GNU_SOURCE
>> # Turn on transparent support for LFS
>> DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>> +ifdef DEBUG
>> +CCOPTS = -g
>> +else
>> CCOPTS = -O2
>> +endif
>> WFLAGS := -Wall -Wstrict-prototypes -Wmissing-prototypes
>> WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
>
> This implies a change of optimization level to -O0 when building with
> DEBUG set, doesn't it? Was it intentional?
yes it is intentional.
> Perhaps it would be less surprising to explicitly set -O0, if that was
> your intention. Just a thought.
>
> Thanks,
> Jakub
>
next prev parent reply other threads:[~2016-06-22 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 23:27 [PATCH iproute2] Enable use of extra debugging information David Ahern
2016-06-22 8:36 ` Jakub Sitnicki
2016-06-22 16:55 ` David Ahern [this message]
2016-06-27 17:52 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d1368f-c71e-d2fe-bf79-caa631f4ecc9@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=jkbs@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.