From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9405C433EF for ; Thu, 14 Oct 2021 06:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9349460D07 for ; Thu, 14 Oct 2021 06:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbhJNG4w (ORCPT ); Thu, 14 Oct 2021 02:56:52 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:45655 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229619AbhJNG4p (ORCPT ); Thu, 14 Oct 2021 02:56:45 -0400 Received: from [192.168.0.2] (ip5f5ae921.dynamic.kabel-deutschland.de [95.90.233.33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id EF74161E64760; Thu, 14 Oct 2021 08:54:39 +0200 (CEST) Subject: Re: [PATCH 6/6] media: aspeed: richer debugfs To: Jammy Huang References: <20211014034819.2283-1-jammy_huang@aspeedtech.com> <20211014034819.2283-7-jammy_huang@aspeedtech.com> Cc: eajames@linux.ibm.com, mchehab@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Paul Menzel Message-ID: Date: Thu, 14 Oct 2021 08:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211014034819.2283-7-jammy_huang@aspeedtech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Jammy, Am 14.10.21 um 05:48 schrieb Jammy Huang: > updated as below: > > Caputre: Capture > Mode : Direct fetch > VGA bpp mode : 32 > Signal : Unlock > Width : 1920 > Height : 1080 > FRC : 30 > > Compression: > Format : JPEG > Subsampling : 444 > Quality : 0 > HQ Mode : N/A > HQ Quality : 0 > Mode : N/A > > Performance: > Frame# : 0 > Frame Duration(ms) : > Now : 0 > Min : 0 > Max : 0 > FPS : 0 Do you have output with non-zero values? ;-) On what device did you test this? > Signed-off-by: Jammy Huang > --- > drivers/media/platform/aspeed-video.c | 41 +++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index e1031fd09ac6..f2e5c49ee906 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -464,6 +464,9 @@ static const struct v4l2_dv_timings_cap aspeed_video_timings_cap = { > }, > }; > > +static const char * const compress_mode_str[] = {"DCT Only", > + "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > + > static unsigned int debug; > > static void aspeed_video_init_jpeg_table(u32 *table, bool yuv420) > @@ -1077,8 +1080,6 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) > > static void aspeed_video_update_regs(struct aspeed_video *video) > { > - static const char * const compress_mode_str[] = {"DCT Only", > - "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > u32 comp_ctrl = FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | > FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10) | > FIELD_PREP(VE_COMP_CTRL_EN_HQ, video->hq_mode) | > @@ -1795,9 +1796,29 @@ static const struct vb2_ops aspeed_video_vb2_ops = { > static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > { > struct aspeed_video *v = s->private; > + u32 val08; Why does `08` refer to? > > seq_puts(s, "\n"); > > + val08 = aspeed_video_read(v, VE_CTRL); > + seq_puts(s, "Caputre:\n"); > + if (FIELD_GET(VE_CTRL_DIRECT_FETCH, val08)) { > + seq_printf(s, " %-20s:\tDirect fetch\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "VGA bpp mode", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? "16" : "32"); > + } else { > + seq_printf(s, " %-20s:\tSync\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "Video source", > + FIELD_GET(VE_CTRL_SOURCE, val08) ? > + "external" : "internal"); > + seq_printf(s, " %-20s:\t%s\n", "DE source", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? > + "internal" : "external"); > + seq_printf(s, " %-20s:\t%s\n", "Cursor overlay", > + FIELD_GET(VE_CTRL_AUTO_OR_CURSOR, val08) ? > + "Without" : "With"); > + } > + > seq_printf(s, " %-20s:\t%s\n", "Signal", > v->v4l2_input_status ? "Unlock" : "Lock"); > seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); > @@ -1806,6 +1827,21 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > > seq_puts(s, "\n"); > > + seq_puts(s, "Compression:\n"); > + seq_printf(s, " %-20s:\t%s\n", "Format", > + v->partial_jpeg ? "Aspeed" : "JPEG"); > + seq_printf(s, " %-20s:\t%s\n", "Subsampling", > + v->yuv420 ? "420" : "444"); > + seq_printf(s, " %-20s:\t%d\n", "Quality", v->jpeg_quality); > + seq_printf(s, " %-20s:\t%s\n", "HQ Mode", > + v->partial_jpeg ? (v->hq_mode ? "on" : "off") : "N/A"); > + seq_printf(s, " %-20s:\t%d\n", "HQ Quality", v->jpeg_hq_quality); > + seq_printf(s, " %-20s:\t%s\n", "Mode", > + v->partial_jpeg ? compress_mode_str[v->compression_mode] > + : "N/A"); > + > + seq_puts(s, "\n"); > + > seq_puts(s, "Performance:\n"); > seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); > seq_printf(s, " %-20s:\n", "Frame Duration(ms)"); Remove the colon, and add a space before (? > @@ -1814,7 +1850,6 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); > seq_printf(s, " %-20s:\t%d\n", "FPS", 1000/(v->perf.totaltime/v->sequence)); > > - > return 0; > } Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8909C433EF for ; Thu, 14 Oct 2021 06:55:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56CB5610F9 for ; Thu, 14 Oct 2021 06:55:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 56CB5610F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HVKsV5C3xz2yw6 for ; Thu, 14 Oct 2021 17:55:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=molgen.mpg.de (client-ip=141.14.17.11; helo=mx1.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de; receiver=) Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HVKrz5x08z2xX6; Thu, 14 Oct 2021 17:54:43 +1100 (AEDT) Received: from [192.168.0.2] (ip5f5ae921.dynamic.kabel-deutschland.de [95.90.233.33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id EF74161E64760; Thu, 14 Oct 2021 08:54:39 +0200 (CEST) Subject: Re: [PATCH 6/6] media: aspeed: richer debugfs To: Jammy Huang References: <20211014034819.2283-1-jammy_huang@aspeedtech.com> <20211014034819.2283-7-jammy_huang@aspeedtech.com> From: Paul Menzel Message-ID: Date: Thu, 14 Oct 2021 08:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211014034819.2283-7-jammy_huang@aspeedtech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, openbmc@lists.ozlabs.org, eajames@linux.ibm.com, linux-kernel@vger.kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Jammy, Am 14.10.21 um 05:48 schrieb Jammy Huang: > updated as below: > > Caputre: Capture > Mode : Direct fetch > VGA bpp mode : 32 > Signal : Unlock > Width : 1920 > Height : 1080 > FRC : 30 > > Compression: > Format : JPEG > Subsampling : 444 > Quality : 0 > HQ Mode : N/A > HQ Quality : 0 > Mode : N/A > > Performance: > Frame# : 0 > Frame Duration(ms) : > Now : 0 > Min : 0 > Max : 0 > FPS : 0 Do you have output with non-zero values? ;-) On what device did you test this? > Signed-off-by: Jammy Huang > --- > drivers/media/platform/aspeed-video.c | 41 +++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index e1031fd09ac6..f2e5c49ee906 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -464,6 +464,9 @@ static const struct v4l2_dv_timings_cap aspeed_video_timings_cap = { > }, > }; > > +static const char * const compress_mode_str[] = {"DCT Only", > + "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > + > static unsigned int debug; > > static void aspeed_video_init_jpeg_table(u32 *table, bool yuv420) > @@ -1077,8 +1080,6 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) > > static void aspeed_video_update_regs(struct aspeed_video *video) > { > - static const char * const compress_mode_str[] = {"DCT Only", > - "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > u32 comp_ctrl = FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | > FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10) | > FIELD_PREP(VE_COMP_CTRL_EN_HQ, video->hq_mode) | > @@ -1795,9 +1796,29 @@ static const struct vb2_ops aspeed_video_vb2_ops = { > static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > { > struct aspeed_video *v = s->private; > + u32 val08; Why does `08` refer to? > > seq_puts(s, "\n"); > > + val08 = aspeed_video_read(v, VE_CTRL); > + seq_puts(s, "Caputre:\n"); > + if (FIELD_GET(VE_CTRL_DIRECT_FETCH, val08)) { > + seq_printf(s, " %-20s:\tDirect fetch\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "VGA bpp mode", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? "16" : "32"); > + } else { > + seq_printf(s, " %-20s:\tSync\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "Video source", > + FIELD_GET(VE_CTRL_SOURCE, val08) ? > + "external" : "internal"); > + seq_printf(s, " %-20s:\t%s\n", "DE source", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? > + "internal" : "external"); > + seq_printf(s, " %-20s:\t%s\n", "Cursor overlay", > + FIELD_GET(VE_CTRL_AUTO_OR_CURSOR, val08) ? > + "Without" : "With"); > + } > + > seq_printf(s, " %-20s:\t%s\n", "Signal", > v->v4l2_input_status ? "Unlock" : "Lock"); > seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); > @@ -1806,6 +1827,21 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > > seq_puts(s, "\n"); > > + seq_puts(s, "Compression:\n"); > + seq_printf(s, " %-20s:\t%s\n", "Format", > + v->partial_jpeg ? "Aspeed" : "JPEG"); > + seq_printf(s, " %-20s:\t%s\n", "Subsampling", > + v->yuv420 ? "420" : "444"); > + seq_printf(s, " %-20s:\t%d\n", "Quality", v->jpeg_quality); > + seq_printf(s, " %-20s:\t%s\n", "HQ Mode", > + v->partial_jpeg ? (v->hq_mode ? "on" : "off") : "N/A"); > + seq_printf(s, " %-20s:\t%d\n", "HQ Quality", v->jpeg_hq_quality); > + seq_printf(s, " %-20s:\t%s\n", "Mode", > + v->partial_jpeg ? compress_mode_str[v->compression_mode] > + : "N/A"); > + > + seq_puts(s, "\n"); > + > seq_puts(s, "Performance:\n"); > seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); > seq_printf(s, " %-20s:\n", "Frame Duration(ms)"); Remove the colon, and add a space before (? > @@ -1814,7 +1850,6 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); > seq_printf(s, " %-20s:\t%d\n", "FPS", 1000/(v->perf.totaltime/v->sequence)); > > - > return 0; > } Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E9BCC433EF for ; Thu, 14 Oct 2021 06:56:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73AFA61053 for ; Thu, 14 Oct 2021 06:56:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73AFA61053 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rpP4hljs9C2A3TqnoGHuafBfLK2JwByAPPL1Re7G5V4=; b=rNdTxJHN+Cz60I/CyzUGdMNwdq q2/SiBUFjlfoygYEgno4zKRhOutSjPptG3kZJsc60zamS4WHngQ/qmN3ojZAPzvS7juM+f/ckoO3v P2nNrOxyzJjFXG2P2lIrlD3R7XHwoZ4vHm+Gb9zah3TufldyfkPC5+I42C3pKIwAA6RNxQjWnY/GD gGFsdKWriFSiaDjYw/DZLpJJfTRhMjFiDxMUce8yO+G+b/FkafUDU2kgOVeqV6RDw5Joz8ciypjBq E+ABaHj3VLT4KCR9sNXH77xcxIgU/2NLfqXjkaFpkDRoLDHEy+9jW4P7m1bRkGJk4km3CkJkqZ1Uw EHmo1bmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maudc-001m6t-Oj; Thu, 14 Oct 2021 06:54:48 +0000 Received: from mx3.molgen.mpg.de ([141.14.17.11] helo=mx1.molgen.mpg.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maudW-001m3i-4W for linux-arm-kernel@lists.infradead.org; Thu, 14 Oct 2021 06:54:44 +0000 Received: from [192.168.0.2] (ip5f5ae921.dynamic.kabel-deutschland.de [95.90.233.33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id EF74161E64760; Thu, 14 Oct 2021 08:54:39 +0200 (CEST) Subject: Re: [PATCH 6/6] media: aspeed: richer debugfs To: Jammy Huang References: <20211014034819.2283-1-jammy_huang@aspeedtech.com> <20211014034819.2283-7-jammy_huang@aspeedtech.com> Cc: eajames@linux.ibm.com, mchehab@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Paul Menzel Message-ID: Date: Thu, 14 Oct 2021 08:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211014034819.2283-7-jammy_huang@aspeedtech.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_235442_372974_26DAD1FB X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Jammy, Am 14.10.21 um 05:48 schrieb Jammy Huang: > updated as below: > > Caputre: Capture > Mode : Direct fetch > VGA bpp mode : 32 > Signal : Unlock > Width : 1920 > Height : 1080 > FRC : 30 > > Compression: > Format : JPEG > Subsampling : 444 > Quality : 0 > HQ Mode : N/A > HQ Quality : 0 > Mode : N/A > > Performance: > Frame# : 0 > Frame Duration(ms) : > Now : 0 > Min : 0 > Max : 0 > FPS : 0 Do you have output with non-zero values? ;-) On what device did you test this? > Signed-off-by: Jammy Huang > --- > drivers/media/platform/aspeed-video.c | 41 +++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index e1031fd09ac6..f2e5c49ee906 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -464,6 +464,9 @@ static const struct v4l2_dv_timings_cap aspeed_video_timings_cap = { > }, > }; > > +static const char * const compress_mode_str[] = {"DCT Only", > + "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > + > static unsigned int debug; > > static void aspeed_video_init_jpeg_table(u32 *table, bool yuv420) > @@ -1077,8 +1080,6 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) > > static void aspeed_video_update_regs(struct aspeed_video *video) > { > - static const char * const compress_mode_str[] = {"DCT Only", > - "DCT VQ mix 2-color", "DCT VQ mix 4-color"}; > u32 comp_ctrl = FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | > FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10) | > FIELD_PREP(VE_COMP_CTRL_EN_HQ, video->hq_mode) | > @@ -1795,9 +1796,29 @@ static const struct vb2_ops aspeed_video_vb2_ops = { > static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > { > struct aspeed_video *v = s->private; > + u32 val08; Why does `08` refer to? > > seq_puts(s, "\n"); > > + val08 = aspeed_video_read(v, VE_CTRL); > + seq_puts(s, "Caputre:\n"); > + if (FIELD_GET(VE_CTRL_DIRECT_FETCH, val08)) { > + seq_printf(s, " %-20s:\tDirect fetch\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "VGA bpp mode", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? "16" : "32"); > + } else { > + seq_printf(s, " %-20s:\tSync\n", "Mode"); > + seq_printf(s, " %-20s:\t%s\n", "Video source", > + FIELD_GET(VE_CTRL_SOURCE, val08) ? > + "external" : "internal"); > + seq_printf(s, " %-20s:\t%s\n", "DE source", > + FIELD_GET(VE_CTRL_INT_DE, val08) ? > + "internal" : "external"); > + seq_printf(s, " %-20s:\t%s\n", "Cursor overlay", > + FIELD_GET(VE_CTRL_AUTO_OR_CURSOR, val08) ? > + "Without" : "With"); > + } > + > seq_printf(s, " %-20s:\t%s\n", "Signal", > v->v4l2_input_status ? "Unlock" : "Lock"); > seq_printf(s, " %-20s:\t%d\n", "Width", v->pix_fmt.width); > @@ -1806,6 +1827,21 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > > seq_puts(s, "\n"); > > + seq_puts(s, "Compression:\n"); > + seq_printf(s, " %-20s:\t%s\n", "Format", > + v->partial_jpeg ? "Aspeed" : "JPEG"); > + seq_printf(s, " %-20s:\t%s\n", "Subsampling", > + v->yuv420 ? "420" : "444"); > + seq_printf(s, " %-20s:\t%d\n", "Quality", v->jpeg_quality); > + seq_printf(s, " %-20s:\t%s\n", "HQ Mode", > + v->partial_jpeg ? (v->hq_mode ? "on" : "off") : "N/A"); > + seq_printf(s, " %-20s:\t%d\n", "HQ Quality", v->jpeg_hq_quality); > + seq_printf(s, " %-20s:\t%s\n", "Mode", > + v->partial_jpeg ? compress_mode_str[v->compression_mode] > + : "N/A"); > + > + seq_puts(s, "\n"); > + > seq_puts(s, "Performance:\n"); > seq_printf(s, " %-20s:\t%d\n", "Frame#", v->sequence); > seq_printf(s, " %-20s:\n", "Frame Duration(ms)"); Remove the colon, and add a space before (? > @@ -1814,7 +1850,6 @@ static int aspeed_video_debugfs_show(struct seq_file *s, void *data) > seq_printf(s, " %-18s:\t%d\n", "Max", v->perf.duration_max); > seq_printf(s, " %-20s:\t%d\n", "FPS", 1000/(v->perf.totaltime/v->sequence)); > > - > return 0; > } Kind regards, Paul _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel