From: Luciano Coelho <luciano.coelho@intel.com>
To: coverity-bot <keescook@chromium.org>,
Shahar S Matityahu <shahar.s.matityahu@intel.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Re: Coverity: _iwl_dbgfs_fw_dbg_domain_write(): Insecure data handling
Date: Mon, 25 Nov 2019 12:35:22 +0200 [thread overview]
Message-ID: <f7d56013bc4b9f52c48ceeb44f2b03b65370ce61.camel@intel.com> (raw)
In-Reply-To: <201911040942.30D0EBA@keescook>
On Mon, 2019-11-04 at 09:42 -0800, coverity-bot wrote:
> Hello!
>
> This is an experimental automated report about issues detected by Coverity
> from a scan of next-20191031 as part of the linux-next weekly scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by recent commits:
>
> 068893b7a28f ("iwlwifi: dbg_ini: support domain changing via debugfs")
>
> Coverity reported the following:
>
> *** CID 1487394: Insecure data handling (TAINTED_SCALAR)
> /drivers/net/wireless/intel/iwlwifi/fw/debugfs.c: 355 in _iwl_dbgfs_fw_dbg_domain_write()
> 349 size_t size, char *buf)
> 350 {
> 351 return scnprintf(buf, size, "0x%08x\n",
> 352 fwrt->trans->dbg.domains_bitmap);
> 353 }
> 354
> vvv CID 1487394: Insecure data handling (TAINTED_SCALAR)
> vvv Passing tainted variable "buf" to a tainted sink.
> 355 FWRT_DEBUGFS_READ_WRITE_FILE_OPS(fw_dbg_domain, 20);
> 356
> 357 void iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,
> 358 struct dentry *dbgfs_dir)
> 359 {
> 360 INIT_DELAYED_WORK(&fwrt->timestamp.wk, iwl_fw_timestamp_marker_wk);
> 361 FWRT_DEBUGFS_ADD_FILE(timestamp_marker, dbgfs_dir, 0200);
> 362 FWRT_DEBUGFS_ADD_FILE(send_hcmd, dbgfs_dir, 0200);
> 363 FWRT_DEBUGFS_ADD_FILE(fw_dbg_domain, dbgfs_dir, 0600);
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487394 ("Insecure data handling")
> Fixes: 068893b7a28f ("iwlwifi: dbg_ini: support domain changing via debugfs")
>
>
> Thanks for your attention!
We have removed the "write" part of this debugfs entry, so this is not
applicable anymore.
Thanks for reporting!
--
Cheers,
Luca.
prev parent reply other threads:[~2019-11-25 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 17:42 Coverity: _iwl_dbgfs_fw_dbg_domain_write(): Insecure data handling coverity-bot
2019-11-25 10:35 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d56013bc4b9f52c48ceeb44f2b03b65370ce61.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-next@vger.kernel.org \
--cc=shahar.s.matityahu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.