From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH for-4.7 1/7] tools/xenstat: Avoid comparing '0 <= unsigned integer' Date: Wed, 27 Apr 2016 14:18:02 -0500 Message-ID: References: <1461776486-31484-1-git-send-email-andrew.cooper3@citrix.com> <1461776486-31484-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6838014665802450357==" Return-path: In-Reply-To: <1461776486-31484-2-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6838014665802450357== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jdhjRFf7XsJjHTskuVxvSpWm5DF1UHbEG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jdhjRFf7XsJjHTskuVxvSpWm5DF1UHbEG Content-Type: multipart/mixed; boundary="fUhcoN9OTb6EsdwjiFiDbhaObjXKbFpMB" From: Doug Goldstein To: Andrew Cooper , Xen-devel Cc: Ian Jackson , Wei Liu Message-ID: Subject: Re: [Xen-devel] [PATCH for-4.7 1/7] tools/xenstat: Avoid comparing '0 <= unsigned integer' References: <1461776486-31484-1-git-send-email-andrew.cooper3@citrix.com> <1461776486-31484-2-git-send-email-andrew.cooper3@citrix.com> In-Reply-To: <1461776486-31484-2-git-send-email-andrew.cooper3@citrix.com> --fUhcoN9OTb6EsdwjiFiDbhaObjXKbFpMB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/27/16 12:01 PM, Andrew Cooper wrote: > Clang points out that this is tautological. >=20 > src/xenstat.c:325:8: warning: comparison of 0 <=3D unsigned expressio= n is > always true [-Wtautological-compare] > if (0 <=3D index && index < node->num_domains) > ~ ^ ~~~~~ >=20 > Signed-off-by: Andrew Cooper > --- Reviewed-by: Doug Goldstein --=20 Doug Goldstein --fUhcoN9OTb6EsdwjiFiDbhaObjXKbFpMB-- --jdhjRFf7XsJjHTskuVxvSpWm5DF1UHbEG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJXIRBrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUMZYQAISnv6GF+5SmkR4+mEj6oGDk 7sWWCEhE8AvKNPnpEXo/u/yABKCxFSunQHAyg2Ck3lcV6TJlB/jJ0qpaHz4Mm0Px 49JLiA5kXwUdu4glUUljm99bTv8YBHX61mnNIvjh7dTVGLojAXaFuegb5XAaU5os Q3qmhgxt9ouaUXUpe347eMYVrSST6J0aSGc1wSn+HEcl0CfsDvswFBT9/wVbtnvL iwTQ17pBz3RggI/GTYTH3WQQRWsAJjxaz/rtNSrtdmjQj1C72rnXs1hVJf0lDu9k O2NUp6xUXlyVZ5WU4Oj5gKkSYTXstXFgbbhz9ewFEtWL2B0tboy6PobVY1EKsk55 3fFpGn0Ruc8wzsWDmKeUJ1HILKKwMjONkiJ1Dbm8PL344gNJIB5g6xfkBnuyWyI+ aELAcZ76knJvFzNDACIUAR3BTrWFsNh7GwJGLnTzBLBKcvTXn03Q8EFrwpTyNe8f /lTFU+K+Jturulz+sdCSgXHoLw0VZexcHbsx3GbL9Jg1SBZp6wFbOQ5h6WICfWHj y0z8hlveJp8inacwvO+GZzPC69MFkR4AD6mWXfuoM6MkI0Nf3YDzMT8qMelx6SO4 h0/FuSipTwDUA0tT4YTP/b0mbJORs34ZwFjtoD0//5LrecrJmu6NTucj4ZV1H3g9 jPPTbc+ljGV8muRsjBpp =OPHZ -----END PGP SIGNATURE----- --jdhjRFf7XsJjHTskuVxvSpWm5DF1UHbEG-- --===============6838014665802450357== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============6838014665802450357==--