Re: [PATCH] nvme: duplicate NQNs check if devices needed

From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Liguang Zhang <zhangliguang@linux.alibaba.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: duplicate NQNs check if devices needed
Date: Mon, 29 Nov 2021 18:48:38 +0000	[thread overview]
Message-ID: <f7dedda8-a739-0af7-95c7-5e4c1f574ff7@nvidia.com> (raw)
In-Reply-To: <20211129163406.GA3582042@dhcp-10-100-145-180.wdc.com>

Liguang,

On 11/29/21 8:34 AM, Keith Busch wrote:
> On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
>> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>>   
>>   	lockdep_assert_held(&nvme_subsystems_lock);
>>   
>> +	if (strncmp(subsysnqn, "nqn.", 4))
>> +		return NULL;
> 
> This seems like an arbitrary way to decide not to check for duplicates.
> Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
> broken controllers?
> 

Please add t he quirk for a specific controller(s) as mentioned
by Keith.

-ck