From: Wolfgang Grandegger <wg@grandegger.com>
To: Martin Sperl <kernel@martin.sperl.org>
Cc: linux-can@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Mark Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Marcel Birthelmer <Marcel.Birthelmer@microchip.com>,
Sukkin Pang <skp@skpang.co.uk>,
Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
Subject: [PATCH V4 0/3] Microchip mcp25xxfd can controller driver
Date: Thu, 14 Jun 2018 18:05:07 +0200 [thread overview]
Message-ID: <f7e6e838-3ef7-12b5-55cb-51ff39f5e449@grandegger.com> (raw)
In-Reply-To: <51FF051D-FB8D-43B4-ADD8-7FEA380E6DEF@martin.sperl.org>
Hello Martin,
Am 14.06.2018 um 07:19 schrieb Martin Sperl:
>
>> On 12.06.2018, at 16:38, Wolfgang Grandegger <wg@grandegger.com> wrote:
>>
>> Hello Martin,
>>
>> this driver is huge... more than 4300 lines of code. That's maybe one
>> reason why it has not yet been reviewed. The driver includes a debugfs
>> interface and is also very verbose in general. I'm not sure if the
>> debugging code is really useful for the end user, but well, debugfs is
>> exactly for that purpose. What about splitting up the driver in a
>> subdirectory "mcp2517fd" into core, spi, debugfs, etc. Other opinions?
>
> Splitting does unfortunately strip the compiler from the opportunity to
> Automatically inline code.
>
> What I was thinking is maybe to split up the patch into:
> * basic functionality
> * debugfs
> * optimization code
> * gpio lib related (already separated)
> * documentation comments
And Header files.
> Would that be helpful?
Other opinions?
Wolfgang.
next prev parent reply other threads:[~2018-06-14 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 16:03 [PATCH V4 0/3] Microchip mcp25xxfd can controller driver kernel
2018-05-14 16:03 ` [PATCH V4 1/3] dt-binding: can: mcp25xxfd: document device tree bindings kernel
2018-05-14 16:03 ` [PATCH V4 2/3] can: mcp25xxfd: Add Microchip mcp25xxfd CAN FD driver kernel
2018-05-14 16:03 ` [PATCH V4 3/3] can: mcp25xxfd: add gpiolib support for GPIO0/1 (aka. INT0/INT1) kernel
2018-06-06 17:32 ` [PATCH V4 0/3] Microchip mcp25xxfd can controller driver kernel
2018-06-12 14:38 ` Wolfgang Grandegger
2018-06-14 5:19 ` Martin Sperl
2018-06-14 16:05 ` Wolfgang Grandegger [this message]
2018-06-21 7:38 ` Wolfgang Grandegger
2018-06-21 15:46 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7e6e838-3ef7-12b5-55cb-51ff39f5e449@grandegger.com \
--to=wg@grandegger.com \
--cc=Marcel.Birthelmer@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=info@gerhard-bertelsmann.de \
--cc=kernel@martin.sperl.org \
--cc=linux-can@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=skp@skpang.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.