From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= Date: Thu, 8 Mar 2018 20:38:27 +0100 Subject: [U-Boot] [PATCH v5 07/15] phy: add support for internal phys In-Reply-To: References: <20180212163858.25601-1-noltari@gmail.com> <20180305200546.12744-1-noltari@gmail.com> <20180305200546.12744-8-noltari@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Joe, El 07/03/2018 a las 21:28, Joe Hershberger escribió: > On Mon, Mar 5, 2018 at 2:05 PM, Álvaro Fernández Rojas > wrote: >> Signed-off-by: Álvaro Fernández Rojas >> --- >> v5: no changes >> v4: no changes >> v3: no changes >> v2: no changes >> >> include/phy.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/phy.h b/include/phy.h >> index 0543ec10c2..8f3e53db01 100644 >> --- a/include/phy.h >> +++ b/include/phy.h >> @@ -50,6 +50,7 @@ >> >> >> typedef enum { >> + PHY_INTERFACE_MODE_INTERNAL, > In Linux this is handled as a flag instead of a different mode. It > seems we should do it the same way. Not really, in Linux this is handled as both: - As a flag (https://elixir.bootlin.com/linux/latest/ident/PHY_IS_INTERNAL): https://github.com/torvalds/linux/blob/master/include/linux/phy.h#L61 https://github.com/torvalds/linux/blob/master/drivers/net/phy/phy_device.c#L1792 https://github.com/torvalds/linux/blob/master/include/linux/phy.h#L832 - As a mode (https://elixir.bootlin.com/linux/latest/ident/PHY_INTERFACE_MODE_INTERNAL): https://github.com/torvalds/linux/blob/master/include/linux/phy.h#L68 https://github.com/torvalds/linux/blob/master/include/linux/phy.h#L119 > >> PHY_INTERFACE_MODE_MII, >> PHY_INTERFACE_MODE_GMII, >> PHY_INTERFACE_MODE_SGMII, >> @@ -72,6 +73,7 @@ typedef enum { >> } phy_interface_t; >> >> static const char *phy_interface_strings[] = { >> + [PHY_INTERFACE_MODE_INTERNAL] = "internal", >> [PHY_INTERFACE_MODE_MII] = "mii", >> [PHY_INTERFACE_MODE_GMII] = "gmii", >> [PHY_INTERFACE_MODE_SGMII] = "sgmii", >> -- >> 2.11.0 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot at lists.denx.de >> https://lists.denx.de/listinfo/u-boot ~Álvaro.