From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CEAC11F66 for ; Tue, 29 Jun 2021 06:08:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8B1D61D9A for ; Tue, 29 Jun 2021 06:08:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8B1D61D9A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A68282FE7; Tue, 29 Jun 2021 08:08:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624946913; bh=SnPJ14D+43K+Nu/t3f/Lg3DHClUeufCIVMF13R4BsRA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=0BwKRklJY69IASfQy0zs7+/M2bDt33zf4zgi3cTJLioWu5LlRnCIfWZNdsN3sU8T3 wtUIfTJf2SBTW2GPl21xEXE8+aScoE+qvSxGgrFODu8v3mwtdO0h/Cr/1BC7ojBVCj wGiumsm1cFzRPx2Ub7H7zEOCglxy2POzVfc+ZmiGk2NC3pcdqNyPQPS8ZU/xHalFCI YYj0XS0MOvPm0BdDzEJLFtzRrryt4ai4A2bpfcyVlxEheCE5oOXaMncESyey1mD/+q d1c8CMmWw6AdL977LAKkPDKif83qzGwFosJOF4fJ2wFi4URG/o6rEIyzVuvdDO7I3f YNZiBzEcfozOQ== Received: by phobos.denx.de (Postfix, from userid 109) id D658E83111; Tue, 29 Jun 2021 08:08:31 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4CF9482FC0 for ; Tue, 29 Jun 2021 08:08:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4GDYv11dgVzQjb8; Tue, 29 Jun 2021 08:08:29 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id T0b6ml5LVWLt; Tue, 29 Jun 2021 08:08:26 +0200 (CEST) Subject: Re: [PATCH v2 09/10] sandbox: add test of wdt_gpio driver To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Tom Rini , Simon Glass References: <20210527220017.1266765-1-rasmus.villemoes@prevas.dk> <20210527220017.1266765-10-rasmus.villemoes@prevas.dk> From: Stefan Roese Message-ID: Date: Tue, 29 Jun 2021 08:08:25 +0200 MIME-Version: 1.0 In-Reply-To: <20210527220017.1266765-10-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.43 / 15.00 / 15.00 X-Rspamd-Queue-Id: 54B1D180C X-Rspamd-UID: 12479b X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 28.05.21 00:00, Rasmus Villemoes wrote: > It seems that no other test has claimed gpio_a:7 yet, so use that. > > The only small wrinkle is modifying the existing wdt test to use > uclass_get_device_by_driver() since we now have two UCLASS_WDT > instances in play, so it's a little more robust to fetch the device by > driver and not merely uclass+index. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/sandbox/dts/test.dts | 6 ++++++ > configs/sandbox64_defconfig | 1 + > configs/sandbox_defconfig | 1 + > test/dm/wdt.c | 36 +++++++++++++++++++++++++++++++++++- > 4 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts > index 5ca3bc502a..cee5b14ecb 100644 > --- a/arch/sandbox/dts/test.dts > +++ b/arch/sandbox/dts/test.dts > @@ -755,6 +755,12 @@ > }; > }; > > + gpio-wdt { > + gpios = <&gpio_a 7 0>; > + compatible = "linux,wdt-gpio"; > + always-running; > + }; > + > mbox: mbox { > compatible = "sandbox,mbox"; > #mbox-cells = <1>; > diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig > index 8b934698b5..3e4ee6e8e1 100644 > --- a/configs/sandbox64_defconfig > +++ b/configs/sandbox64_defconfig > @@ -225,6 +225,7 @@ CONFIG_SPLASH_SCREEN_ALIGN=y > CONFIG_VIDEO_BMP_RLE8=y > # CONFIG_WATCHDOG_AUTOSTART is not set > CONFIG_WDT=y > +CONFIG_WDT_GPIO=y > CONFIG_WDT_SANDBOX=y > CONFIG_FS_CBFS=y > CONFIG_FS_CRAMFS=y > diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig > index 8911463d58..faea4d763c 100644 > --- a/configs/sandbox_defconfig > +++ b/configs/sandbox_defconfig > @@ -272,6 +272,7 @@ CONFIG_W1_EEPROM=y > CONFIG_W1_EEPROM_SANDBOX=y > # CONFIG_WATCHDOG_AUTOSTART is not set > CONFIG_WDT=y > +CONFIG_WDT_GPIO=y > CONFIG_WDT_SANDBOX=y > CONFIG_FS_CBFS=y > CONFIG_FS_CRAMFS=y > diff --git a/test/dm/wdt.c b/test/dm/wdt.c > index 24b991dff6..abff853a02 100644 > --- a/test/dm/wdt.c > +++ b/test/dm/wdt.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -19,7 +20,8 @@ static int dm_test_wdt_base(struct unit_test_state *uts) > struct udevice *dev; > const u64 timeout = 42; > > - ut_assertok(uclass_get_device(UCLASS_WDT, 0, &dev)); > + ut_assertok(uclass_get_device_by_driver(UCLASS_WDT, > + DM_DRIVER_GET(wdt_sandbox), &dev)); > ut_assertnonnull(dev); > ut_asserteq(0, state->wdt.counter); > ut_asserteq(false, state->wdt.running); > @@ -39,3 +41,35 @@ static int dm_test_wdt_base(struct unit_test_state *uts) > return 0; > } > DM_TEST(dm_test_wdt_base, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); > + > +static int dm_test_wdt_gpio(struct unit_test_state *uts) > +{ > + /* > + * The sandbox wdt gpio is "connected" to gpio bank a, offset > + * 7. Use the sandbox back door to verify that the gpio-wdt > + * driver behaves as expected. > + */ > + struct udevice *wdt, *gpio; > + const u64 timeout = 42; > + const int offset = 7; > + int val; > + > + ut_assertok(uclass_get_device_by_driver(UCLASS_WDT, > + DM_DRIVER_GET(wdt_gpio), &wdt)); > + ut_assertnonnull(wdt); > + > + ut_assertok(uclass_get_device_by_name(UCLASS_GPIO, "base-gpios", &gpio)); > + ut_assertnonnull(gpio); > + ut_assertok(wdt_start(wdt, timeout, 0)); > + > + val = sandbox_gpio_get_value(gpio, offset); > + ut_assertok(wdt_reset(wdt)); > + ut_asserteq(!val, sandbox_gpio_get_value(gpio, offset)); > + ut_assertok(wdt_reset(wdt)); > + ut_asserteq(val, sandbox_gpio_get_value(gpio, offset)); > + > + ut_asserteq(-ENOSYS, wdt_stop(wdt)); > + > + return 0; > +} > +DM_TEST(dm_test_wdt_gpio, UT_TESTF_SCAN_FDT); > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de