All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,  Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: do not dump error logs in GHA containers
Date: Tue, 26 Apr 2022 11:05:53 -0400	[thread overview]
Message-ID: <f7t1qxjnaum.fsf@redhat.com> (raw)
In-Reply-To: <CAJFAV8y1jT5ZMr+g1YDC=OCpJoEnEvUr8ssy9xU5vLpiKz-oMg@mail.gmail.com> (David Marchand's message of "Tue, 26 Apr 2022 09:18:01 +0200")

David Marchand <david.marchand@redhat.com> writes:

> On Tue, Apr 26, 2022 at 9:09 AM David Marchand
> <david.marchand@redhat.com> wrote:
>>
>> On error, the build logs are displayed in GHA console and logs unless
>> the GITHUB_WORKFLOW env variable is set.
>> However, containers in GHA do not automatically inherit this variable.
>> We could pass this variable in the container environment, but in the
>> end, dumping those logs is only for Travis which we don't really care
>> about anymore.
>>
>> Let's make the linux-build.sh more generic and dump logs from Travis
>> yaml itself.
>>
>> Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> TBH, I did not test Travis by lack of interest (plus I don't want to
> be bothered with their ui / credit stuff).
> We could consider dropping Travis in the near future.
>
> Opinions?

I think it makes sense.  We haven't had travis reports in a while
because their credit system made it impossible to use.  We had kept it
around for users of travis, but at this point, I think most people have
migrated to GHA.


  reply	other threads:[~2022-04-26 15:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  7:09 [PATCH] ci: do not dump error logs in GHA containers David Marchand
2022-04-26  7:18 ` David Marchand
2022-04-26 15:05   ` Aaron Conole [this message]
2022-04-28  9:51     ` David Marchand
2022-04-29  4:16       ` Honnappa Nagarahalli
2022-04-29 20:12         ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7t1qxjnaum.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maicolgabriel@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.