From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org, ci@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH v2] doc: add dependency syntax to contributing guide
Date: Mon, 06 Jul 2020 14:02:27 -0400 [thread overview]
Message-ID: <f7td0581pzg.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <2764957.7Ma0oT34CT@thomas> (Thomas Monjalon's message of "Mon, 06 Jul 2020 17:12:18 +0200")
Thomas Monjalon <thomas@monjalon.net> writes:
> 06/07/2020 17:09, Aaron Conole:
>> Ferruh Yigit <ferruh.yigit@intel.com> writes:
>>
>> > To help managing patch dependencies, both for maintainers or automation
>> > tasks, document a syntax for commit logs or cover letters to express
>> > their dependencies.
>> >
>> > Using the syntax proposed in Bugzilla ID 210:
>> > [https://bugs.dpdk.org/show_bug.cgi?id=210]
>> >
>> > "Depends-on: series-NNNNN ("Title of the series")'
>> > OR
>> > 'Depends-on: patch-NNNNN ("Title of the patch")'
>> >
>> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> > ---
>>
>> Is the plan that these must be scrubbed before committing?
>>
>> This data doesn't seem useful in the history. I would prefer it in the
>> subject like
>>
>> [PATCH series-xxxx] lorem ipsum
>>
>> Since the metadata gets scrubbed.
>
> Look below:
>
>> > + Signed-off-by: Alex Smith <alex.smith@example.com>
>> > + ---
>> > + Depends-on: series-10000 ("Title of the series")
>
> Added after line ---
> so it won't be kept in the git history.
Ahh, I missed it for some reason.
next prev parent reply other threads:[~2020-07-06 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 11:35 [dpdk-dev] [PATCH] doc: add dependency syntax to contributing guide Ferruh Yigit
2020-07-01 11:59 ` [dpdk-dev] [dpdk-ci] " Thomas Monjalon
2020-07-02 16:13 ` Ferruh Yigit
2020-07-03 9:01 ` Thomas Monjalon
2020-07-03 9:03 ` Ferruh Yigit
2020-07-03 9:53 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-07-06 15:09 ` [dpdk-dev] [dpdk-ci] " Aaron Conole
2020-07-06 15:12 ` Thomas Monjalon
2020-07-06 18:02 ` Aaron Conole [this message]
2020-07-30 23:13 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7td0581pzg.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.