From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [RFC 1/2] nfp: unlink the appropriate lock file
Date: Fri, 13 Apr 2018 09:24:57 -0400
Message-ID: <f7tefjjz1au.fsf@dhcp-25.97.bos.redhat.com>
References: <20180412222208.11770-1-aconole@redhat.com>
 <20180412222208.11770-2-aconole@redhat.com>
 <CAD+H993G4oUxPEgvVUY6de0b0PD0yN09zbpy8zvwPi9gE9Q+Zw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: dev <dev@dpdk.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 63C9F1C30C
 for <dev@dpdk.org>; Fri, 13 Apr 2018 15:24:58 +0200 (CEST)
In-Reply-To: <CAD+H993G4oUxPEgvVUY6de0b0PD0yN09zbpy8zvwPi9gE9Q+Zw@mail.gmail.com>
 (Alejandro Lucero's message of "Fri, 13 Apr 2018 09:31:41 +0200")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Alejandro Lucero <alejandro.lucero@netronome.com> writes:

> Although the patch is correct, the truth is there was not option for locks but "nfp0", because
> the PMD did not support more than one NFP card. 
>
> After commit with CPP support, the PMD can support more than one NFP card, but this
> interface is not supported anymore and this file was removed.
>
> is this patch coming from some code revision or from a problem you found?

Just a code review - we were reported a problem initializing the driver,
and in looking at the lock/unlock code, it seems that it was always
releasing the nfp0 lock.  Good to know that in practice it likely
wouldn't cause real harm.  I intend to resubmit this as is.

Thanks, Alejandro!

> On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole <aconole@redhat.com> wrote:
>
>  The nfpu_close needs to unlink the lock file associated with the
>  nfp descriptor, not lock file 0.
>
>  Fixes: d12206e00590 ("net/nfp: add NSP user space interface")
>
>  Cc: stable@dpdk.org
>  Signed-off-by: Aaron Conole <aconole@redhat.com>
>  ---
>   drivers/net/nfp/nfp_nfpu.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
>  diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>  index f11afef35..2ed985ff4 100644
>  --- a/drivers/net/nfp/nfp_nfpu.c
>  +++ b/drivers/net/nfp/nfp_nfpu.c
>  @@ -101,8 +101,12 @@ nfpu_open(struct rte_pci_device *pci_dev, nfpu_desc_t *desc,
>  int nfp)
>   int
>   nfpu_close(nfpu_desc_t *desc)
>   {
>  +       char lockname[30];
>  +
>          rte_free(desc->nspu);
>          close(desc->lock);
>  -       unlink("/var/lock/nfp0");
>  +
>  +       snprintf(lockname, sizeof(lockname), "/var/lock/nfp%d", desc->nfp);
>  +       unlink(lockname);
>          return 0;
>   }
>  -- 
>  2.14.3