From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH] mk: fix the combined library problems by replacing it with a linker script Date: Tue, 24 Nov 2015 16:28:25 -0500 Message-ID: References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <20151124145518.GA3364@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org To: Neil Horman Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A3FFC567E for ; Tue, 24 Nov 2015 22:28:27 +0100 (CET) In-Reply-To: <20151124145518.GA3364@hmsreliant.think-freely.org> (Neil Horman's message of "Tue, 24 Nov 2015 09:55:18 -0500") List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Neil Horman writes: > On Tue, Nov 24, 2015 at 04:31:17PM +0200, Panu Matilainen wrote: >> The physically linked-together combined library has been an increasing >> source of problems, as was predicted when library and symbol versioning >> was introduced. Replace the complex and fragile construction with a >> simple linker script which achieves the same without all the problems, >> remove the related kludges from eg mlx drivers. >> >> Since creating the linker script is practically zero cost, remove the >> config option and just create it always. >> >> Based on a patch by Sergio Gonzales Monroy, linker script approach >> initially suggested by Neil Horman. >> >> Suggested-by: Sergio Gonzalez Monroy >> Suggested-by: Neil Horman >> Signed-off-by: Panu Matilainen > Acked-by: Neil Horman > Nice work +1, and just for good measure: Acked-by: Aaron Conole