From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDF3C43331 for ; Fri, 6 Sep 2019 19:29:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CD53E2173B for ; Fri, 6 Sep 2019 19:29:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD53E2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F2871F3E6; Fri, 6 Sep 2019 21:29:22 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 36AD21F3E4 for ; Fri, 6 Sep 2019 21:29:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86B9E30860DE; Fri, 6 Sep 2019 19:29:20 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1BBB3DB4; Fri, 6 Sep 2019 19:29:19 +0000 (UTC) From: Aaron Conole To: Hemant Agrawal Cc: dev@dpdk.org, jerinj@marvell.com References: <20190906103410.14996-1-hemant.agrawal@nxp.com> <20190906103410.14996-5-hemant.agrawal@nxp.com> Date: Fri, 06 Sep 2019 15:29:19 -0400 In-Reply-To: <20190906103410.14996-5-hemant.agrawal@nxp.com> (Hemant Agrawal's message of "Fri, 6 Sep 2019 16:04:09 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 06 Sep 2019 19:29:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 4/5] event/dpaa2: add selftest cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hemant Agrawal writes: > Signed-off-by: Hemant Agrawal > --- > drivers/event/dpaa2/Makefile | 1 + > drivers/event/dpaa2/dpaa2_eventdev.c | 1 + > drivers/event/dpaa2/dpaa2_eventdev.h | 2 ++ > drivers/event/dpaa2/dpaa2_eventdev_logs.h | 6 ++++++ > drivers/event/dpaa2/meson.build | 3 ++- > 5 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/event/dpaa2/Makefile b/drivers/event/dpaa2/Makefile > index e0bb527b1..634179383 100644 > --- a/drivers/event/dpaa2/Makefile > +++ b/drivers/event/dpaa2/Makefile > @@ -40,5 +40,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API > # > SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) += dpaa2_hw_dpcon.c > SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) += dpaa2_eventdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) += dpaa2_eventdev_selftest.c > > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c > index 9255de16f..902a80f36 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -951,6 +951,7 @@ static struct rte_eventdev_ops dpaa2_eventdev_ops = { > .port_unlink = dpaa2_eventdev_port_unlink, > .timeout_ticks = dpaa2_eventdev_timeout_ticks, > .dump = dpaa2_eventdev_dump, > + .dev_selftest = test_eventdev_dpaa2, > .eth_rx_adapter_caps_get = dpaa2_eventdev_eth_caps_get, > .eth_rx_adapter_queue_add = dpaa2_eventdev_eth_queue_add, > .eth_rx_adapter_queue_del = dpaa2_eventdev_eth_queue_del, > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.h b/drivers/event/dpaa2/dpaa2_eventdev.h > index bdac1aa56..abc038e49 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.h > +++ b/drivers/event/dpaa2/dpaa2_eventdev.h > @@ -98,4 +98,6 @@ struct dpaa2_eventdev { > struct dpaa2_dpcon_dev *rte_dpaa2_alloc_dpcon_dev(void); > void rte_dpaa2_free_dpcon_dev(struct dpaa2_dpcon_dev *dpcon); > > +int test_eventdev_dpaa2(void); > + > #endif /* __DPAA2_EVENTDEV_H__ */ > diff --git a/drivers/event/dpaa2/dpaa2_eventdev_logs.h b/drivers/event/dpaa2/dpaa2_eventdev_logs.h > index 86f2e5393..bb5a0e26c 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev_logs.h > +++ b/drivers/event/dpaa2/dpaa2_eventdev_logs.h > @@ -35,4 +35,10 @@ extern int dpaa2_logtype_event; > #define DPAA2_EVENTDEV_DP_WARN(fmt, args...) \ > DPAA2_EVENTDEV_DP_LOG(WARNING, fmt, ## args) > > +#define dpaa2_evdev_info(fmt, ...) DPAA2_EVENTDEV_LOG(INFO, fmt, ##__VA_ARGS__) > +#define dpaa2_evdev_dbg(fmt, ...) DPAA2_EVENTDEV_LOG(DEBUG, fmt, ##__VA_ARGS__) > +#define dpaa2_evdev_err(fmt, ...) DPAA2_EVENTDEV_LOG(ERR, fmt, ##__VA_ARGS__) > +#define dpaa2_evdev__func_trace dpaa2_evdev_dbg > +#define dpaa2_evdev_selftest dpaa2_evdev_info > + > #endif /* _DPAA2_EVENTDEV_LOGS_H_ */ > diff --git a/drivers/event/dpaa2/meson.build b/drivers/event/dpaa2/meson.build > index f7da7fad5..cea87d77b 100644 > --- a/drivers/event/dpaa2/meson.build > +++ b/drivers/event/dpaa2/meson.build > @@ -9,7 +9,8 @@ if not is_linux > endif > deps += ['bus_vdev', 'pmd_dpaa2', 'pmd_dpaa2_sec'] > sources = files('dpaa2_hw_dpcon.c', > - 'dpaa2_eventdev.c') > + 'dpaa2_eventdev.c', > + 'dpaa2_eventdev_selftest.c) Unterminated string. > allow_experimental_apis = true > includes += include_directories('../../crypto/dpaa2_sec/')